Hi Lianbo,
On Sat, Nov 21, 2020 at 11:46 AM lijiang <lijiang(a)redhat.com> wrote:
Hi, Kairui
Thanks for this series.
在 2020年11月20日 15:11, Kairui Song 写道:
> Block driver detection now doesn't work for raw targets, this will fix
> it. And watchdog driver detection is broken after we enabled the squash
> module, this also fixed that problem.
>
> The driver detection code are coupled together so fix them together in
> this series.
>
> Patch 7/7 will include watchdog-modules by default, but dracut
> haven't make a release containing this module yet, so the last
> patch may be merged later.
>
> --
After applied this patch series, I tested it on a dell machine, and got
the following errors:
[root@dell-per710-01 kexec-tools]# kdumpctl restart
kdump: kexec: unloaded kdump kernel
kdump: Stopping kdump: [OK]
kdump: Detected change(s) in the following file(s): /etc/kdump.conf
/usr/sbin/makedumpfile /etc/kdump/post.d/ /etc/kdump/pre.d/
kdump: Rebuilding /boot/initramfs-5.9.8-100.fc32.x86_64kdump.img
kdump: Warning: There might not be enough space to save a vmcore.
kdump: The size of /dev/mapper/fedora_dell--per710--01-root should be greater
than 24330132 kilo bytes.
kdump: mkdumprd: failed to make kdump initrd
kdump: Starting kdump: [FAILED]
The mkdumprd always fails to make the kdump initrd, do you happen to run into
this issue?
Thanks.
Lianbo
You have to drop patch 7/7 for now as it will try to load a still
non-exist dracut module "watchdog-module". Dracut will include that
module in next release.
>
> Update from V1:
> - Fix a few bugs in the patch
> - Set watchdog's pretimeout to 0 in second kernel
>
> Kairui Song (7):
> kdumpctl: split the driver detection from fs dection function
> Remove a redundant nfs check
> Add a helper for detecting watchdog drivers
> Fix the watchdog drivers detection code
> kdump-lib.sh: Use a more generic helper to detect omitted dracut
> module
> Set watchdog's pretimeout to zero in kdump kernel
> Always include watchdog-modules
>
> dracut-module-setup.sh | 1 +
> kdump-lib.sh | 68 +++++++++++-----
> kdumpctl | 178 ++++++++++++++---------------------------
> 3 files changed, 107 insertions(+), 140 deletions(-)
>
--
Best Regards,
Kairui Song