[PATCH] mkdumprd: Improve error messages on non-existing NFS target directories

[Lichen Liu]

When kdump is configured with a NFS location, and the remote directory does
not exist, kdump.service fails with a confusing error message.

kdumpctl[2172]: kdump: Dump path "/tmp/mkdumprd.ftWhOF/target/dumps"
    does not exist in dump target "10.111.113.2:/srv/kdump"

We just need to print the remote directory "dumps" in such case, because
"/tmp/mkdumprd.ftWhOF/target" is the local temporary mount point.

Signed-off-by: Lichen Liu 
---
 mkdumprd | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mkdumprd b/mkdumprd
index 3e250e0..c0f131d 100644
--- a/mkdumprd
+++ b/mkdumprd
@@ -242,7 +242,7 @@ check_user_configured_target()

# For user configured target, use $SAVE_PATH as the dump path within the target
    if [[ ! -d "$_mnt/$SAVE_PATH" ]]; then
-		perror_exit "Dump path "$_mnt/$SAVE_PATH" does not exist in dump target "$_target""
+		perror_exit "Dump path "$SAVE_PATH" does not exist in dump target "$_target""
    fi

check_size fs "$_target"

[Coiby Xu]

Thanks for the patch!

Reviewed-by: Coiby Xu

On Tue, Sep 06, 2022 at 11:15:15AM +0800, Lichen Liu wrote:
> When kdump is configured with a NFS location, and the remote directory does
> not exist, kdump.service fails with a confusing error message.
>
> kdumpctl[2172]: kdump: Dump path "/tmp/mkdumprd.ftWhOF/target/dumps"
>    does not exist in dump target "10.111.113.2:/srv/kdump"
>
> We just need to print the remote directory "dumps" in such case, because
> "/tmp/mkdumprd.ftWhOF/target" is the local temporary mount point.
> Signed-off-by: Lichen Liu
>
> mkdumprd | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mkdumprd b/mkdumprd
> index 3e250e0..c0f131d 100644
> --- a/mkdumprd
> +++ b/mkdumprd
> @@ -242,7 +242,7 @@ check_user_configured_target()
>
> # For user configured target, use $SAVE_PATH as the dump path within the target
>    if [[ ! -d "$_mnt/$SAVE_PATH" ]]; then
> perror_exit "Dump path \"$_mnt/$SAVE_PATH\" does not exist in dump target \"$_target\""
> perror_exit "Dump path \"$SAVE_PATH\" does not exist in dump target \"$_target\""
>
> fi
>
> check_size fs "$_target"
>
> -- 
> 2.31.1
> _______________________________________________
> kexec mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedoraproject.org/archives/list/[e-mail]
> Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue