[PATCH] kdump.conf: uncomment default core_collector line

[WANG Chao]

Having uncommented core_collector line in default kdump.conf would help
s-c-kdump determine which arguments to use without relying on hardcoded
values.

Signed-off-by: WANG Chao <chaowang(a)redhat.com&gt;
---
 kdump.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kdump.conf b/kdump.conf
index 3c411fb..a106462 100644
--- a/kdump.conf
+++ b/kdump.conf
@@ -132,7 +132,7 @@
 #ssh user(a)my.server.com
 #sshkey /root/.ssh/kdump_id_rsa
 path /var/crash
-#core_collector makedumpfile -l --message-level 1 -d 31
+core_collector makedumpfile -l --message-level 1 -d 31
 #core_collector scp
 #kdump_post /var/crash/scripts/kdump-post.sh
 #kdump_pre /var/crash/scripts/kdump-pre.sh
-- 
1.8.4.2

[Vivek Goyal]

On Thu, Jan 02, 2014 at 11:43:17PM +0800, WANG Chao wrote:
>  Having uncommented core_collector line in default kdump.conf would
> help
>  s-c-kdump determine which arguments to use without relying on hardcoded
>  values.
>  
>  Signed-off-by: WANG Chao <chaowang(a)redhat.com&gt; 
Looks good.

Chao, if I change dump target to raw, does kdumpctl error out warning
that core collector is not appropriate for the dump target?

Thanks
Vivek

>  ---
>   kdump.conf | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>  
>  diff --git a/kdump.conf b/kdump.conf
>  index 3c411fb..a106462 100644
>  --- a/kdump.conf
>  +++ b/kdump.conf
>  @@ -132,7 +132,7 @@
>   #ssh user(a)my.server.com
>   #sshkey /root/.ssh/kdump_id_rsa
>   path /var/crash
>  -#core_collector makedumpfile -l --message-level 1 -d 31
>  +core_collector makedumpfile -l --message-level 1 -d 31
>   #core_collector scp
>   #kdump_post /var/crash/scripts/kdump-post.sh
>   #kdump_pre /var/crash/scripts/kdump-pre.sh
>  -- 
>  1.8.4.2
>  
>  _______________________________________________
>  kexec mailing list
>  kexec(a)lists.fedoraproject.org
>  https://lists.fedoraproject.org/mailman/listinfo/kexec

[WANG Chao]

On 01/02/14 at 05:41pm, Vivek Goyal wrote:
>  On Thu, Jan 02, 2014 at 11:43:17PM +0800, WANG Chao wrote:
>  > Having uncommented core_collector line in default kdump.conf would help
>  > s-c-kdump determine which arguments to use without relying on hardcoded
>  > values.
>  > 
>  > Signed-off-by: WANG Chao <chaowang(a)redhat.com&gt;
>  
>  Looks good.
>  
>  Chao, if I change dump target to raw, does kdumpctl error out warning
>  that core collector is not appropriate for the dump target? 
Yes, for both ssh and raw dump,

# kdumpctl restart
kexec: unloaded kdump kernel
Stopping kdump: [OK]
Detected change(s) the following file(s):
  
    /etc/kdump.conf
Rebuilding /boot/initramfs-3.11.10-301.fc20.x86_64kdump.img
The specified dump target needs makedumpfile "-F" option.
mkdumprd: failed to make kdump initrd
Starting kdump: [FAILED]

-- 
Thanks
WANG Chao

[Vivek Goyal]

On Fri, Jan 03, 2014 at 02:16:43PM +0800, WANG Chao wrote:
>  On 01/02/14 at 05:41pm, Vivek Goyal wrote:
>  > On Thu, Jan 02, 2014 at 11:43:17PM +0800, WANG Chao wrote:
>  > > Having uncommented core_collector line in default kdump.conf would help
>  > > s-c-kdump determine which arguments to use without relying on hardcoded
>  > > values.
>  > > 
>  > > Signed-off-by: WANG Chao <chaowang(a)redhat.com&gt;
>  > 
>  > Looks good.
>  > 
>  > Chao, if I change dump target to raw, does kdumpctl error out warning
>  > that core collector is not appropriate for the dump target?
>  
>  Yes, for both ssh and raw dump,
>  
>  # kdumpctl restart
>  kexec: unloaded kdump kernel
>  Stopping kdump: [OK]
>  Detected change(s) the following file(s):
>    
>      /etc/kdump.conf
>  Rebuilding /boot/initramfs-3.11.10-301.fc20.x86_64kdump.img
>  The specified dump target needs makedumpfile "-F" option.
>  mkdumprd: failed to make kdump initrd
>  Starting kdump: [FAILED] 
Thanks for checking this chao.

Acked-by: Vivek Goyal <vgoyal(a)redhat.com&gt;

Thanks
Vivek