Re: Bug in lib/kdump/kdump-lib.sh ... on LVM crypto volumes

[Baoquan He]

On 05/25/22 at 09:47pm, John Donnelly wrote:
> On 3/23/22 03:17, Baoquan He wrote:
> > On 03/22/22 at 10:05pm, [e-mail] wrote:
> > > Hi
> > >
> > > There is a bug in /lib/kdump/kdump-lib.sh when there are LVM crypto volumes
> > > on the system :
> > >
> > > Provisioning during the installation. In this case lvm pool is created:
> > > # lvdisplay
> > >    --- Logical volume ---
> > >    LV Name                pool00
> > >    VG Name                ol
> > >    LV UUID                LARWgk-Fgdq-naoV-R2eN-ooWQ-mcIF-N34LbR
> > >    LV Write Access        read/write (activated read only)
> > >    LV Creation host, time localhost, 2021-11-16 14:06:22 -0500
> > >    LV Pool metadata       pool00_tmeta
> > >    LV Pool data           pool00_tdata
> > >    LV Status              available
> > >    # open                 0
> > >    LV Size                <20.15 GiB
> > >    Allocated pool data    27.26%
> > >    Allocated metadata     21.96%
> > >    Current LE             5158
> > >    Segments               1
> > >    Allocation             inherit
> > >    Read ahead sectors     auto
> > > currently set to     8192
> > >
> > > Block device           252:5
> > >
> > > # kdumpctl rebuild
> > > kdump: Rebuilding /boot/initramfs-86_64kdump.img
> > >
> > > /lib/kdump/kdump-lib.sh: eval: line 939: syntax error near unexpected token
> > > `;'
> > > /lib/kdump/kdump-lib.sh: eval: line 939: `; echo $TYPE'
> > > /lib/kdump/kdump-lib.sh: eval: line 939: syntax error near unexpected token
> > > `;'
> > > /lib/kdump/kdump-lib.sh: eval: line 939: `; echo $TYPE'
> > > /lib/kdump/kdump-lib.sh: eval: line 939: syntax error near unexpected token
> > > `;'
> > > /lib/kdump/kdump-lib.sh: eval: line 939: `; echo $TYPE'
> > >
> > > # blkid -u filesystem,crypto -o export -- /dev/block/253:0
> > > DEVNAME=/dev/block/253:0
> > > UUID=a5ff3f28-3a29-4353-9a12-2c39e2b6d399
> > > TYPE=ext4
> > >
> > > kexec-tools]# eval "$(blkid -u filesystem,crypto -o export
> > > -- /dev/block/253:0); echo $TYPE"
> > > ext4
> > >
> > > [ kexec-tools]# blkid -u filesystem,crypto -o export --
> > > /dev/block/11:0
> > > [root@ca-ostest469 kexec-tools]# eval "$(blkid -u filesystem,crypto -o
> > > export
> > > -- /dev/block/11:0); echo $TYPE"
> > >
> > > bash: syntax error near unexpected token `;'
> > >
> > > so the error is seen if blkid is not able to extract information from block
> > > device
> > >
> > > The fix :
> > >
> > > Applying this patch will avoid printing the error message.
> > >
> > > --- kdump-lib.sh.org    2022-02-03 17:23:48.654000000 -0600
> > > +++ kdump-lib.sh        2022-02-03 17:25:53.962000000 -0600
> > > @@ -936,6 +936,13 @@
> > >   {
> > >       [[ -b /dev/block/$1 ]] || return 1
> > > # If the given device is LVM private, skip.
> > > blkid -u filesystem,crypto -o export -- /dev/block/$1 > /dev/null
> > > if [ $? -ne 0 ]
> > > then
> > >    return 1
> > > fi
> > > local _type=$(eval "$(blkid -u filesystem,crypto -o export --
> > >
> > > /dev/block/$1); echo $TYPE")
> > >       [[ $_type == "crypto_LUKS" ]] && echo $1
> > >
> > > It is a non-fatal error. kdumpclt rebuild still works.
> > >
> > > Is there a upstream github for this ?  Or a contact you can share ?
> >
> > This is the mailing list where kexec-tools package is maintianed. You
> > can subscribe, send your problem description and finding, our colleages
> > may check it.
> >
> > [e-mail]
> >
> > By the way, John, are you working on kexec/kdump maintaining in Oracle
> > linux distros?
>
> Hi,
>
> This appears to be a dead list . No one ever replies and I can't find it at
> :
>
> https://accounts.fedoraproject.org/groups/
>
> ...
>
> Your mail to '[e-mail]' with the subject
> Re: Bug in lib/kdump/kdump-lib.sh ... on LVM crypto volumes
>
> Is being held until the list moderator can review it for approval.

You subscribed to the list, and got no response?

Hi Dave,

Do you know who is the moderator of the kexec fedora list?

Bug in lib/kdump/kdump-lib.sh ... on LVM crypto volumes

[Coiby Xu]

Hi Baoquan,

On Thu, May 26, 2022 at 12:00:32PM +0800, Baoquan He wrote:
> On 05/25/22 at 09:47pm, John Donnelly wrote:
> > On 3/23/22 03:17, Baoquan He wrote:
> > > On 03/22/22 at 10:05pm, [e-mail] wrote:
> > > > Hi
> > > >
> > > > There is a bug in /lib/kdump/kdump-lib.sh when there are LVM crypto volumes
> > > > on the system :
> > > >
> > > > Provisioning during the installation. In this case lvm pool is created:
> > > > # lvdisplay
> > > >    --- Logical volume ---
> > > >    LV Name                pool00
> > > >    VG Name                ol
> > > >    LV UUID                LARWgk-Fgdq-naoV-R2eN-ooWQ-mcIF-N34LbR
> > > >    LV Write Access        read/write (activated read only)
> > > >    LV Creation host, time localhost, 2021-11-16 14:06:22 -0500
> > > >    LV Pool metadata       pool00_tmeta
> > > >    LV Pool data           pool00_tdata
> > > >    LV Status              available
> > > >    # open                 0
> > > >    LV Size                <20.15 GiB
> > > >    Allocated pool data    27.26%
> > > >    Allocated metadata     21.96%
> > > >    Current LE             5158
> > > >    Segments               1
> > > >    Allocation             inherit
> > > >    Read ahead sectors     auto
> > > > currently set to     8192
> > > >
> > > > Block device           252:5
> > > >
> > > > # kdumpctl rebuild
> > > > kdump: Rebuilding /boot/initramfs-86_64kdump.img
> > > >
> > > > /lib/kdump/kdump-lib.sh: eval: line 939: syntax error near unexpected token
> > > > `;'
> > > > /lib/kdump/kdump-lib.sh: eval: line 939: `; echo $TYPE'
> > > > /lib/kdump/kdump-lib.sh: eval: line 939: syntax error near unexpected token
> > > > `;'
> > > > /lib/kdump/kdump-lib.sh: eval: line 939: `; echo $TYPE'
> > > > /lib/kdump/kdump-lib.sh: eval: line 939: syntax error near unexpected token
> > > > `;'
> > > > /lib/kdump/kdump-lib.sh: eval: line 939: `; echo $TYPE'
> > > >
> > > > # blkid -u filesystem,crypto -o export -- /dev/block/253:0
> > > > DEVNAME=/dev/block/253:0
> > > > UUID=a5ff3f28-3a29-4353-9a12-2c39e2b6d399
> > > > TYPE=ext4
> > > >
> > > > kexec-tools]# eval "$(blkid -u filesystem,crypto -o export
> > > > -- /dev/block/253:0); echo $TYPE"
> > > > ext4
> > > >
> > > > [ kexec-tools]# blkid -u filesystem,crypto -o export --
> > > > /dev/block/11:0
> > > > [root@ca-ostest469 kexec-tools]# eval "$(blkid -u filesystem,crypto -o
> > > > export
> > > > -- /dev/block/11:0); echo $TYPE"
> > > >
> > > > bash: syntax error near unexpected token `;'
> > > >
> > > > so the error is seen if blkid is not able to extract information from block
> > > > device
> > > >
> > > > The fix :
> > > >
> > > > Applying this patch will avoid printing the error message.
> > > >
> > > > --- kdump-lib.sh.org    2022-02-03 17:23:48.654000000 -0600
> > > > +++ kdump-lib.sh        2022-02-03 17:25:53.962000000 -0600
> > > > @@ -936,6 +936,13 @@
> > > >   {
> > > >       [[ -b /dev/block/$1 ]] || return 1
> > > > # If the given device is LVM private, skip.
> > > > blkid -u filesystem,crypto -o export -- /dev/block/$1 > /dev/null
> > > > if [ $? -ne 0 ]
> > > > then
> > > >    return 1
> > > > fi
> > > > local _type=$(eval "$(blkid -u filesystem,crypto -o export --
> > > >
> > > > /dev/block/$1); echo $TYPE")
> > > >       [[ $_type == "crypto_LUKS" ]] && echo $1
> > > >
> > > > It is a non-fatal error. kdumpclt rebuild still works.
> > > >
> > > > Is there a upstream github for this ?  Or a contact you can share ?
> > >
> > > This is the mailing list where kexec-tools package is maintianed. You
> > > can subscribe, send your problem description and finding, our colleages
> > > may check it.
> > >
> > > [e-mail]
> > >
> > > By the way, John, are you working on kexec/kdump maintaining in Oracle
> > > linux distros?
> >
> > Hi,
> >
> > This appears to be a dead list . No one ever replies and I can't find it at
> > :
> >
> > https://accounts.fedoraproject.org/groups/
> >
> > ...
> >
> > Your mail to '[e-mail]' with the subject
> > Re: Bug in lib/kdump/kdump-lib.sh ... on LVM crypto volumes
> >
> > Is being held until the list moderator can review it for approval.
>
> You subscribed to the list, and got no response?
>
> Hi Dave,
>
> Do you know who is the moderator of the kexec fedora list?

Both Dave and me are the moderators. John haven't subscribed to the
mailing list which is why the message is hold. I've accepted his message
now. But I suggest John to join the mailing list via [1] since there are
too man spam emails and only allowing a member to post an email seems to
be the only way.

[1] https://lists.fedoraproject.org/admin/lists/kexec.lists.fedoraproject.org/
>

Bug in lib/kdump/kdump-lib.sh ... on LVM crypto volumes

[John Donnelly]

On 5/25/22 23:21, Coiby Xu wrote:
> Hi Baoquan,
>
> On Thu, May 26, 2022 at 12:00:32PM +0800, Baoquan He wrote:
> > On 05/25/22 at 09:47pm, John Donnelly wrote:
> > > On 3/23/22 03:17, Baoquan He wrote:
> > > > On 03/22/22 at 10:05pm, [e-mail] wrote:
> > > > > Hi
> > > > >
> > > > > There is a bug in /lib/kdump/kdump-lib.sh when there are LVM
> > >
> > > crypto volumes
> > > > > on the system :
> > > > >
> > > > > Provisioning during the installation. In this case lvm pool is
> > >
> > > created:
> > > > > # lvdisplay
> > > > >     --- Logical volume ---
> > > > >     LV Name                pool00
> > > > >     VG Name                ol
> > > > >     LV UUID                LARWgk-Fgdq-naoV-R2eN-ooWQ-mcIF-N34LbR
> > > > >     LV Write Access        read/write (activated read only)
> > > > >     LV Creation host, time localhost, 2021-11-16 14:06:22 -0500
> > > > >     LV Pool metadata       pool00_tmeta
> > > > >     LV Pool data           pool00_tdata
> > > > >     LV Status              available
> > > > >     # open                 0
> > > > >     LV Size                <20.15 GiB
> > > > >     Allocated pool data    27.26%
> > > > >     Allocated metadata     21.96%
> > > > >     Current LE             5158
> > > > >     Segments               1
> > > > >     Allocation             inherit
> > > > >     Read ahead sectors     auto
> > > > >     - currently set to     8192
> > > > >     Block device           252:5
> > > > >
> > > > > # kdumpctl rebuild
> > > > > kdump: Rebuilding /boot/initramfs-86_64kdump.img
> > > > >
> > > > > /lib/kdump/kdump-lib.sh: eval: line 939: syntax error near
> > >
> > > unexpected token
> > > > > `;'
> > > > > /lib/kdump/kdump-lib.sh: eval: line 939: `; echo $TYPE'
> > > > > /lib/kdump/kdump-lib.sh: eval: line 939: syntax error near
> > >
> > > unexpected token
> > > > > `;'
> > > > > /lib/kdump/kdump-lib.sh: eval: line 939: `; echo $TYPE'
> > > > > /lib/kdump/kdump-lib.sh: eval: line 939: syntax error near
> > >
> > > unexpected token
> > > > > `;'
> > > > > /lib/kdump/kdump-lib.sh: eval: line 939: `; echo $TYPE'
> > > > >
> > > > > # blkid -u filesystem,crypto -o export -- /dev/block/253:0
> > > > > DEVNAME=/dev/block/253:0
> > > > > UUID=a5ff3f28-3a29-4353-9a12-2c39e2b6d399
> > > > > TYPE=ext4
> > > > >
> > > > > kexec-tools]# eval "$(blkid -u filesystem,crypto -o export
> > > > > -- /dev/block/253:0); echo $TYPE"
> > > > > ext4
> > > > >
> > > > > [ kexec-tools]# blkid -u filesystem,crypto -o export --
> > > > > /dev/block/11:0
> > > > > [root@ca-ostest469 kexec-tools]# eval "$(blkid -u
> > >
> > > filesystem,crypto -o
> > > > > export
> > > > > -- /dev/block/11:0); echo $TYPE"
> > > > >
> > > > > bash: syntax error near unexpected token `;'
> > > > >
> > > > > so the error is seen if blkid is not able to extract information
> > >
> > > from block
> > > > > device
> > > > >
> > > > > The fix :
> > > > >
> > > > > Applying this patch will avoid printing the error message.
> > > > >
> > > > > --- kdump-lib.sh.org    2022-02-03 17:23:48.654000000 -0600
> > > > > +++ kdump-lib.sh        2022-02-03 17:25:53.962000000 -0600
> > > > > @@ -936,6 +936,13 @@
> > > > >    {
> > > > >        [[ -b /dev/block/$1 ]] || return 1
> > > > >
> > > > > +    # If the given device is LVM private, skip.
> > > > > +    blkid -u filesystem,crypto -o export -- /dev/block/$1 >
> > >
> > > /dev/null
> > > > > +    if [ $? -ne 0 ]
> > > > > +    then
> > > > > +        return 1
> > > > > +    fi
> > > > >
> > > > > local _type=$(eval "$(blkid -u filesystem,crypto -o export --
> > > > > /dev/block/$1); echo $TYPE")
> > > > >        [[ $_type == "crypto_LUKS" ]] && echo $1
> > > > >
> > > > > It is a non-fatal error. kdumpclt rebuild still works.
> > > > >
> > > > > Is there a upstream github for this ?  Or a contact you can share ?
> > > >
> > > > This is the mailing list where kexec-tools package is maintianed. You
> > > > can subscribe, send your problem description and finding, our
> > >
> > > colleages
> > > > may check it.
> > > >
> > > > [e-mail]
> > > >
> > > > By the way, John, are you working on kexec/kdump maintaining in Oracle
> > > > linux distros?
> > >
> > > Hi,
> > >
> > > This appears to be a dead list . No one ever replies and I can't find 
> > > it at
> > > :
> > >
> > > https://urldefense.com/v3/__https://accounts.fedoraproject.org/groups/__;!!A...
> > >
> > > ...
> > >
> > > Your mail to '[e-mail]' with the subject
> > >
> > > Re: Bug in lib/kdump/kdump-lib.sh ... on LVM crypto volumes
> > >
> > > Is being held until the list moderator can review it for approval.
> >
> > You subscribed to the list, and got no response?
> >
> > Hi Dave,
> >
> > Do you know who is the moderator of the kexec fedora list?
>
> Both Dave and me are the moderators. John haven't subscribed to the
> mailing list which is why the message is hold. I've accepted his message
> now. But I suggest John to join the mailing list via [1] since there are
> too man spam emails and only allowing a member to post an email seems to
> be the only way.
>
> [1] 
> https://urldefense.com/v3/__https://lists.fedoraproject.org/admin/lists/kexe...
> >

Hi,

I've tried to setup a account going to "FAS"" link and I keep getting :

Proxy Error

The proxy server received an invalid response from an upstream server.
The proxy server could not handle the request

Reason: DNS lookup failure for: worker01.ocp.iad2.fedoraproject.org

...

Bug in lib/kdump/kdump-lib.sh ... on LVM crypto volumes

[John Donnelly]

On 5/26/22 05:43, John Donnelly wrote:
> On 5/25/22 23:21, Coiby Xu wrote:
> > Hi Baoquan,
> >
> > On Thu, May 26, 2022 at 12:00:32PM +0800, Baoquan He wrote:
> > > On 05/25/22 at 09:47pm, John Donnelly wrote:
> > > > On 3/23/22 03:17, Baoquan He wrote:
> > > > > On 03/22/22 at 10:05pm, [e-mail] wrote:
> > > > > > Hi
> > > > > >
> > > > > > There is a bug in /lib/kdump/kdump-lib.sh when there are LVM
> > > >
> > > > crypto volumes
> > > > > > on the system :
> > > > > >
> > > > > > Provisioning during the installation. In this case lvm pool is
> > > >
> > > > created:
> > > > > > # lvdisplay
> > > > > >     --- Logical volume ---
> > > > > >     LV Name                pool00
> > > > > >     VG Name                ol
> > > > > >     LV UUID                LARWgk-Fgdq-naoV-R2eN-ooWQ-mcIF-N34LbR
> > > > > >     LV Write Access        read/write (activated read only)
> > > > > >     LV Creation host, time localhost, 2021-11-16 14:06:22 -0500
> > > > > >     LV Pool metadata       pool00_tmeta
> > > > > >     LV Pool data           pool00_tdata
> > > > > >     LV Status              available
> > > > > >     # open                 0
> > > > > >     LV Size                <20.15 GiB
> > > > > >     Allocated pool data    27.26%
> > > > > >     Allocated metadata     21.96%
> > > > > >     Current LE             5158
> > > > > >     Segments               1
> > > > > >     Allocation             inherit
> > > > > >     Read ahead sectors     auto
> > > > > >     - currently set to     8192
> > > > > >     Block device           252:5
> > > > > >
> > > > > > # kdumpctl rebuild
> > > > > > kdump: Rebuilding /boot/initramfs-86_64kdump.img
> > > > > >
> > > > > > /lib/kdump/kdump-lib.sh: eval: line 939: syntax error near
> > > >
> > > > unexpected token
> > > > > > `;'
> > > > > > /lib/kdump/kdump-lib.sh: eval: line 939: `; echo $TYPE'
> > > > > > /lib/kdump/kdump-lib.sh: eval: line 939: syntax error near
> > > >
> > > > unexpected token
> > > > > > `;'
> > > > > > /lib/kdump/kdump-lib.sh: eval: line 939: `; echo $TYPE'
> > > > > > /lib/kdump/kdump-lib.sh: eval: line 939: syntax error near
> > > >
> > > > unexpected token
> > > > > > `;'
> > > > > > /lib/kdump/kdump-lib.sh: eval: line 939: `; echo $TYPE'
> > > > > >
> > > > > > # blkid -u filesystem,crypto -o export -- /dev/block/253:0
> > > > > > DEVNAME=/dev/block/253:0
> > > > > > UUID=a5ff3f28-3a29-4353-9a12-2c39e2b6d399
> > > > > > TYPE=ext4
> > > > > >
> > > > > > kexec-tools]# eval "$(blkid -u filesystem,crypto -o export
> > > > > > -- /dev/block/253:0); echo $TYPE"
> > > > > > ext4
> > > > > >
> > > > > > [ kexec-tools]# blkid -u filesystem,crypto -o export --
> > > > > > /dev/block/11:0
> > > > > > [root@ca-ostest469 kexec-tools]# eval "$(blkid -u
> > > >
> > > > filesystem,crypto -o
> > > > > > export
> > > > > > -- /dev/block/11:0); echo $TYPE"
> > > > > >
> > > > > > bash: syntax error near unexpected token `;'
> > > > > >
> > > > > > so the error is seen if blkid is not able to extract information
> > > >
> > > > from block
> > > > > > device
> > > > > >
> > > > > > The fix :
> > > > > >
> > > > > > Applying this patch will avoid printing the error message.
> > > > > >
> > > > > > --- kdump-lib.sh.org    2022-02-03 17:23:48.654000000 -0600
> > > > > > +++ kdump-lib.sh        2022-02-03 17:25:53.962000000 -0600
> > > > > > @@ -936,6 +936,13 @@
> > > > > >    {
> > > > > >        [[ -b /dev/block/$1 ]] || return 1
> > > > > >
> > > > > > +    # If the given device is LVM private, skip.
> > > > > > +    blkid -u filesystem,crypto -o export -- /dev/block/$1 >
> > > >
> > > > /dev/null
> > > > > > +    if [ $? -ne 0 ]
> > > > > > +    then
> > > > > > +        return 1
> > > > > > +    fi
> > > > > >
> > > > > > local _type=$(eval "$(blkid -u filesystem,crypto -o export --
> > > > > > /dev/block/$1); echo $TYPE")
> > > > > >        [[ $_type == "crypto_LUKS" ]] && echo $1
> > > > > >
> > > > > > It is a non-fatal error. kdumpclt rebuild still works.
> > > > > >
> > > > > > Is there a upstream github for this ?  Or a contact you can share ?
> > > > >
> > > > > This is the mailing list where kexec-tools package is maintianed. You
> > > > > can subscribe, send your problem description and finding, our
> > > >
> > > > colleages
> > > > > may check it.
> > > > >
> > > > > [e-mail]
> > > > >
> > > > > By the way, John, are you working on kexec/kdump maintaining in
> > > >
> > > > Oracle
> > > > > linux distros?
> > > >
> > > > Hi,
> > > >
> > > > This appears to be a dead list . No one ever replies and I can't 
> > > > find it at
> > > > :
> > > >
> > > > https://urldefense.com/v3/__https://accounts.fedoraproject.org/groups/__;!!A...
> > > >
> > > > ...
> > > >
> > > > Your mail to '[e-mail]' with the subject
> > > >
> > > > Re: Bug in lib/kdump/kdump-lib.sh ... on LVM crypto volumes
> > > >
> > > > Is being held until the list moderator can review it for approval.
> > >
> > > You subscribed to the list, and got no response?
> > >
> > > Hi Dave,
> > >
> > > Do you know who is the moderator of the kexec fedora list?
> >
> > Both Dave and me are the moderators. John haven't subscribed to the
> > mailing list which is why the message is hold. I've accepted his message
> > now. But I suggest John to join the mailing list via [1] since there are
> > too man spam emails and only allowing a member to post an email seems to
> > be the only way.
> >
> > [1] 
> > https://urldefense.com/v3/__https://lists.fedoraproject.org/admin/lists/kexe...
> > >
>
> Hi,
>
> I've tried to setup a account going to "FAS"" link and I keep getting :
>
> Proxy Error
>
> The proxy server received an invalid response from an upstream server.
> The proxy server could not handle the request
>
> Reason: DNS lookup failure for: worker01.ocp.iad2.fedoraproject.org
>
> ...

Ok.

I was able to use my github account to sign in.

Bug in lib/kdump/kdump-lib.sh ... on LVM crypto volumes

On 5/26/22 5:53 AM, John Donnelly wrote:
> On 5/26/22 05:43, John Donnelly wrote:
> > On 5/25/22 23:21, Coiby Xu wrote:
> > > Hi Baoquan,
> > >
> > > On Thu, May 26, 2022 at 12:00:32PM +0800, Baoquan He wrote:
> > > > On 05/25/22 at 09:47pm, John Donnelly wrote:
> > > > > On 3/23/22 03:17, Baoquan He wrote:
> > > > > > On 03/22/22 at 10:05pm, [e-mail] wrote:
> > > > > > >
> > > > > > > Hi
> > > > > > >
> > > > > > > There is a bug in /lib/kdump/kdump-lib.sh when there are LVM
> > > > >
> > > > > crypto volumes
> > > > > > > on the system :
> > > > > > >
> > > > > > >
> > > > > > > Provisioning during the installation. In this case lvm pool is
> > > > >
> > > > > created:
> > > > > > > # lvdisplay
> > > > > > >    --- Logical volume ---
> > > > > > >    LV Name                pool00
> > > > > > >    VG Name                ol
> > > > > > >    LV UUID                LARWgk-Fgdq-naoV-R2eN-ooWQ-mcIF-N34LbR
> > > > > > >    LV Write Access        read/write (activated read only)
> > > > > > >    LV Creation host, time localhost, 2021-11-16 14:06:22 -0500
> > > > > > >    LV Pool metadata       pool00_tmeta
> > > > > > >    LV Pool data           pool00_tdata
> > > > > > >    LV Status              available
> > > > > > >    # open                 0
> > > > > > >    LV Size                <20.15 GiB
> > > > > > >    Allocated pool data    27.26%
> > > > > > >    Allocated metadata     21.96%
> > > > > > >    Current LE             5158
> > > > > > >    Segments               1
> > > > > > >    Allocation             inherit
> > > > > > >    Read ahead sectors     auto
> > > > > > >    - currently set to     8192
> > > > > > >    Block device           252:5
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > # kdumpctl rebuild
> > > > > > > kdump: Rebuilding /boot/initramfs-86_64kdump.img
> > > > > > >
> > > > > > >
> > > > > > > /lib/kdump/kdump-lib.sh: eval: line 939: syntax error near
> > > > >
> > > > > unexpected token
> > > > > > > `;'
> > > > > > > /lib/kdump/kdump-lib.sh: eval: line 939: `; echo $TYPE'
> > > > > > > /lib/kdump/kdump-lib.sh: eval: line 939: syntax error near
> > > > >
> > > > > unexpected token
> > > > > > > `;'
> > > > > > > /lib/kdump/kdump-lib.sh: eval: line 939: `; echo $TYPE'
> > > > > > > /lib/kdump/kdump-lib.sh: eval: line 939: syntax error near
> > > > >
> > > > > unexpected token
> > > > > > > `;'
> > > > > > > /lib/kdump/kdump-lib.sh: eval: line 939: `; echo $TYPE'
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > # blkid -u filesystem,crypto -o export -- /dev/block/253:0
> > > > > > > DEVNAME=/dev/block/253:0
> > > > > > > UUID=a5ff3f28-3a29-4353-9a12-2c39e2b6d399
> > > > > > > TYPE=ext4
> > > > > > >
> > > > > > > kexec-tools]# eval "$(blkid -u filesystem,crypto -o export
> > > > > > > -- /dev/block/253:0); echo $TYPE"
> > > > > > > ext4
> > > > > > >
> > > > > > > [ kexec-tools]# blkid -u filesystem,crypto -o export --
> > > > > > > /dev/block/11:0
> > > > > > > [root@ca-ostest469 kexec-tools]# eval "$(blkid -u
> > > > >
> > > > > filesystem,crypto -o
> > > > > > > export
> > > > > > > -- /dev/block/11:0); echo $TYPE"
> > > > > > >
> > > > > > > bash: syntax error near unexpected token `;'
> > > > > > >
> > > > > > > so the error is seen if blkid is not able to extract
> > > > >
> > > > > information from block
> > > > > > > device
> > > > > > >
> > > > > > >
> > > > > > > The fix :
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > Applying this patch will avoid printing the error message.
> > > > > > >
> > > > > > > --- kdump-lib.sh.org    2022-02-03 17:23:48.654000000 -0600
> > > > > > > +++ kdump-lib.sh        2022-02-03 17:25:53.962000000 -0600
> > > > > > > @@ -936,6 +936,13 @@
> > > > > > >   {
> > > > > > >       [[ -b /dev/block/$1 ]] || return 1
> > > > > > >
> > > > > > > +    # If the given device is LVM private, skip.
> > > > > > > +    blkid -u filesystem,crypto -o export -- /dev/block/$1 >
> > > > >
> > > > > /dev/null
> > > > > > > +    if [ $? -ne 0 ]
> > > > > > > +    then
> > > > > > > +        return 1
> > > > > > > +    fi
> > > > > > > +
> > > > > > >       local _type=$(eval "$(blkid -u filesystem,crypto -o
> > > > >
> > > > > export --
> > > > > > > /dev/block/$1); echo $TYPE")
> > > > > > >       [[ $_type == "crypto_LUKS" ]] && echo $1
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > It is a non-fatal error. kdumpclt rebuild still works.
> > > > > > >
> > > > > > > Is there a upstream github for this ?  Or a contact you can
> > > > >
> > > > > share ?
> > > > > > This is the mailing list where kexec-tools package is maintianed.
> > > > >
> > > > > You
> > > > > > can subscribe, send your problem description and finding, our
> > > > >
> > > > > colleages
> > > > > > may check it.
> > > > > >
> > > > > > [e-mail]
> > > > > >
> > > > > > By the way, John, are you working on kexec/kdump maintaining in
> > > > >
> > > > > Oracle
> > > > > > linux distros?
> > > > >
> > > > > Hi,
> > > > >
> > > > > This appears to be a dead list . No one ever replies and I can't 
> > > > > find it at
> > > > > :
> > > > >
> > > > > https://urldefense.com/v3/__https://accounts.fedoraproject.org/groups/__;!!A...
> > > > >
> > > > > ...
> > > > >
> > > > > Your mail to '[e-mail]' with the subject
> > > > >
> > > > > Re: Bug in lib/kdump/kdump-lib.sh ... on LVM crypto volumes
> > > > >
> > > > > Is being held until the list moderator can review it for approval.
> > > >
> > > > You subscribed to the list, and got no response?
> > > >
> > > > Hi Dave,
> > > >
> > > > Do you know who is the moderator of the kexec fedora list?
> > >
> > > Both Dave and me are the moderators. John haven't subscribed to the
> > > mailing list which is why the message is hold. I've accepted his message
> > > now. But I suggest John to join the mailing list via [1] since there are
> > > too man spam emails and only allowing a member to post an email seems to
> > > be the only way.
> > >
> > > [1] 
> > > https://urldefense.com/v3/__https://lists.fedoraproject.org/admin/lists/kexe...
> > > >
> >
> > Hi,
> >
> > I've tried to setup a account going to "FAS"" link and I keep getting :
> >
> > Proxy Error
> >
> > The proxy server received an invalid response from an upstream server.
> > The proxy server could not handle the request
> >
> > Reason: DNS lookup failure for: worker01.ocp.iad2.fedoraproject.org
> >
> > ...
>
> Ok.
>
> I was able to use my github account to sign in.

Hi

Well

I kept getting into a circle jerk trying to sign-in to

https://lists.fedoraproject.org/accounts/github/login/callback/?code=4806e80...

Error 500

Fedora Mailing-Lists

Social Network Login Failure
An error occurred while attempting to login via your social network account.

I give up.

Please add the fix to the next spin  .

Thank you,.

JD

Bug in lib/kdump/kdump-lib.sh ... on LVM crypto volumes

[Coiby Xu]

On Thu, May 26, 2022 at 10:12:14AM -0500, [e-mail] wrote:
> > > ...
> >
> > Ok.
> >
> > I was able to use my github account to sign in.
>
> Hi
>
> Well
>
> I kept getting into a circle jerk trying to sign-in to
>
> https://lists.fedoraproject.org/accounts/github/login/callback/?code=4806e80...
>
> Error 500
>
> Fedora Mailing-Lists
>
> Social Network Login Failure
> An error occurred while attempting to login via your social network account.
>
> I give up.
>
> Please add the fix to the next spin  .

Sorry for the trouble! Actually you can subscribe without creating an
account by filling your address in the bottom form of 
https://lists.fedoraproject.org/admin/lists/kexec.lists.fedoraproject.org/
> Thank you,.
>
> JD

Bug in lib/kdump/kdump-lib.sh ... on LVM crypto volumes

[Dave Young]

On Fri, 27 May 2022 at 10:00, Coiby Xu  wrote:
> On Thu, May 26, 2022 at 10:12:14AM -0500, [e-mail] wrote:
> > > > ...
> > >
> > > Ok.
> > >
> > > I was able to use my github account to sign in.
> >
> > Hi
> >
> > Well
> >
> > I kept getting into a circle jerk trying to sign-in to
> >
> > https://lists.fedoraproject.org/accounts/github/login/callback/?code=4806e80...
> >
> > Error 500
> >
> > Fedora Mailing-Lists
> >
> > Social Network Login Failure
> > An error occurred while attempting to login via your social network account.
> >
> > I give up.
> >
> > Please add the fix to the next spin  .
>
> Sorry for the trouble! Actually you can subscribe without creating an
> account by filling your address in the bottom form of
> https://lists.fedoraproject.org/admin/lists/kexec.lists.fedoraproject.org/

We have changed to allow non-subscriber to post without approval,
let's try if it just works without too much spam.
> > Thank you,.
> >
> > JD
>
> --
> Best regards,
> Coiby

Bug in lib/kdump/kdump-lib.sh ... on LVM crypto volumes

On 5/31/22 1:09 AM, Dave Young wrote:
> On Fri, 27 May 2022 at 10:00, Coiby Xu  wrote:
> > On Thu, May 26, 2022 at 10:12:14AM -0500, [e-mail] wrote:
> > > > > ...
> > > >
> > > > Ok.
> > > >
> > > > I was able to use my github account to sign in.
> > >
> > > Hi
> > >
> > > Well
> > >
> > > I kept getting into a circle jerk trying to sign-in to
> > >
> > > https://urldefense.com/v3/__https://lists.fedoraproject.org/accounts/github/...
> > >
> > > Error 500
> > >
> > > Fedora Mailing-Lists
> > >
> > > Social Network Login Failure
> > > An error occurred while attempting to login via your social network account.
> > >
> > > I give up.
> > >
> > > Please add the fix to the next spin  .
> >
> > Sorry for the trouble! Actually you can subscribe without creating an
> > account by filling your address in the bottom form of
> > https://urldefense.com/v3/__https://lists.fedoraproject.org/admin/lists/kexe...
>
> We have changed to allow non-subscriber to post without approval,
> let's try if it just works without too much spam.
> > > Thank you,.
> > >
> > > JD
> >
> > --
> > Best regards,
> > Coiby

Hi
   I was finally able to login .

Can you review the mentioned patch and get it staged  for the next 
release ?

Bug in lib/kdump/kdump-lib.sh ... on LVM crypto volumes

[Tao Liu]

On Sat, Jun 11, 2022 at 1:20 AM  wrote:
> On 5/31/22 1:09 AM, Dave Young wrote:
> > On Fri, 27 May 2022 at 10:00, Coiby Xu  wrote:
> > > On Thu, May 26, 2022 at 10:12:14AM -0500, [e-mail] wrote:
> > > > > > ...
> > > > >
> > > > > Ok.
> > > > >
> > > > > I was able to use my github account to sign in.
> > > >
> > > > Hi
> > > >
> > > > Well
> > > >
> > > > I kept getting into a circle jerk trying to sign-in to
> > > >
> > > > https://urldefense.com/v3/__https://lists.fedoraproject.org/accounts/github/...
> > > >
> > > > Error 500
> > > >
> > > > Fedora Mailing-Lists
> > > >
> > > > Social Network Login Failure
> > > > An error occurred while attempting to login via your social network account.
> > > >
> > > > I give up.
> > > >
> > > > Please add the fix to the next spin  .
> > >
> > > Sorry for the trouble! Actually you can subscribe without creating an
> > > account by filling your address in the bottom form of
> > > https://urldefense.com/v3/__https://lists.fedoraproject.org/admin/lists/kexe...
> >
> > We have changed to allow non-subscriber to post without approval,
> > let's try if it just works without too much spam.
> > > > Thank you,.
> > > >
> > > > JD
> > >
> > > --
> > > Best regards,
> > > Coiby

Hi John,
> Hi
>    I was finally able to login .
>
> Can you review the mentioned patch and get it staged  for the next
> release ?

Thanks for reporting the issue and the fixing patch. This issue has
been fixed in fedora kexec-tools by commit "2bbc7512a2f2cf"
(kdump-lib.sh: Check the output of blkid with sed instead of eval).
However the patch has not been migrated to rhel8 and rhel9, because
the issue is discovered by testing against a lvm thinpool block
device. Currently lvm thinpool is not fully supported by kdump, which
is being worked on right now, see upstream discussion in [1]. So my
original thought was to integrate the patch when [1] is accepted.
Since it was encountered again, I think I will do the migration asap.

Sorry I didn't check my in box fully and missed the message, and my
late response.

Thanks,
Tao Liu

[1]: https://lists.fedoraproject.org/archives/list/[e-mail]/...
> kexec mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedoraproject.org/archives/list/[e-mail]
> Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure

Bug in lib/kdump/kdump-lib.sh ... on LVM crypto volumes

[John Donnelly]

On 6/12/22 8:43 PM, Tao Liu wrote:
> On Sat, Jun 11, 2022 at 1:20 AM  wrote:
> > On 5/31/22 1:09 AM, Dave Young wrote:
> > > On Fri, 27 May 2022 at 10:00, Coiby Xu  wrote:
> > > > On Thu, May 26, 2022 at 10:12:14AM -0500, [e-mail] wrote:
> > > > > > > ...
> > > > > > >
> > > > > >
> > > > > > Ok.
> > > > > >
> > > > > > I was able to use my github account to sign in.
> > > > >
> > > > > Hi
> > > > >
> > > > > Well
> > > > >
> > > > > I kept getting into a circle jerk trying to sign-in to
> > > > >
> > > > > https://urldefense.com/v3/__https://lists.fedoraproject.org/accounts/github/...
> > > > >
> > > > > Error 500
> > > > >
> > > > > Fedora Mailing-Lists
> > > > >
> > > > > Social Network Login Failure
> > > > > An error occurred while attempting to login via your social network account.
> > > > >
> > > > > I give up.
> > > > >
> > > > > Please add the fix to the next spin  .
> > > >
> > > > Sorry for the trouble! Actually you can subscribe without creating an
> > > > account by filling your address in the bottom form of
> > > > https://urldefense.com/v3/__https://lists.fedoraproject.org/admin/lists/kexe...
> > >
> > > We have changed to allow non-subscriber to post without approval,
> > > let's try if it just works without too much spam.
> > > > > Thank you,.
> > > > >
> > > > > JD
> > > >
> > > > --
> > > > Best regards,
> > > > Coiby
>
> Hi John,
> > Hi
> >     I was finally able to login .
> > Can you review the mentioned patch and get it staged  for the next
> >
> > release ?
>
> Thanks for reporting the issue and the fixing patch. This issue has
> been fixed in fedora kexec-tools by commit "2bbc7512a2f2cf"
> (kdump-lib.sh: Check the output of blkid with sed instead of eval).
> However the patch has not been migrated to rhel8 and rhel9, because
> the issue is discovered by testing against a lvm thinpool block
> device. Currently lvm thinpool is not fully supported by kdump, which
> is being worked on right now, see upstream discussion in [1]. So my
> original thought was to integrate the patch when [1] is accepted.
> Since it was encountered again, I think I will do the migration asap.
>
> Sorry I didn't check my in box fully and missed the message, and my
> late response.
>
> Thanks,
> Tao Liu
> > kexec mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
> > Fedora Code of Conduct: https://urldefense.com/v3/__https://docs.fedoraproject.org/en-US/project/cod...
> > List Guidelines: https://urldefense.com/v3/__https://fedoraproject.org/wiki/Mailing_list_guid...
> > List Archives: https://urldefense.com/v3/__https://lists.fedoraproject.org/archives/list/ke...
> > Do not reply to spam on the list, report it: https://urldefense.com/v3/__https://pagure.io/fedora-infrastructure__;!!ACWV...

Thank you !

---

Bug in lib/kdump/kdump-lib.sh ... on LVM crypto volumes

[Jp D]

I was finally able to login with a account.

Can I get this patched added to kxeec tools ?

------------------   snip --------------

There is a bug in /lib/kdump/kdump-lib.sh when there are LVM crypto volumes on the system :

Provisioning during the installation. In this case lvm pool is created:
# lvdisplay
  --- Logical volume ---
  LV Name                pool00
  VG Name                ol
  LV UUID                LARWgk-Fgdq-naoV-R2eN-ooWQ-mcIF-N34LbR
  LV Write Access        read/write (activated read only)
  LV Creation host, time localhost, 2021-11-16 14:06:22 -0500
  LV Pool metadata       pool00_tmeta
  LV Pool data           pool00_tdata
  LV Status              available
  # open                 0
  LV Size                <20.15 GiB
  Allocated pool data    27.26%
  Allocated metadata     21.96%
  Current LE             5158
  Segments               1
  Allocation             inherit
  Read ahead sectors     auto
  - currently set to     8192
  Block device           252:5

# kdumpctl rebuild
kdump: Rebuilding /boot/initramfs-86_64kdump.img

/lib/kdump/kdump-lib.sh: eval: line 939: syntax error near unexpected token
`;'
/lib/kdump/kdump-lib.sh: eval: line 939: `; echo $TYPE'
/lib/kdump/kdump-lib.sh: eval: line 939: syntax error near unexpected token
`;'
/lib/kdump/kdump-lib.sh: eval: line 939: `; echo $TYPE'
/lib/kdump/kdump-lib.sh: eval: line 939: syntax error near unexpected token
`;'
/lib/kdump/kdump-lib.sh: eval: line 939: `; echo $TYPE'

# blkid -u filesystem,crypto -o export -- /dev/block/253:0
DEVNAME=/dev/block/253:0
UUID=a5ff3f28-3a29-4353-9a12-2c39e2b6d399
TYPE=ext4

kexec-tools]# eval "$(blkid -u filesystem,crypto -o export
-- /dev/block/253:0); echo $TYPE"
ext4

[ kexec-tools]# blkid -u filesystem,crypto -o export --
/dev/block/11:0
[root@ca-ostest469 kexec-tools]# eval "$(blkid -u filesystem,crypto -o export
-- /dev/block/11:0); echo $TYPE"

bash: syntax error near unexpected token `;'

so the error is seen if blkid is not able to extract information from block device

The fix :

Applying this patch will avoid printing the error message.

--- kdump-lib.sh.org    2022-02-03 17:23:48.654000000 -0600
+++ kdump-lib.sh        2022-02-03 17:25:53.962000000 -0600
@@ -936,6 +936,13 @@
 {
     [[ -b /dev/block/$1 ]] || return 1

+    # If the given device is LVM private, skip.
+    blkid -u filesystem,crypto -o export -- /dev/block/$1 > /dev/null
+    if [ $? -ne 0 ]
+    then
+        return 1
+    fi
+
     local _type=$(eval "$(blkid -u filesystem,crypto -o export --
/dev/block/$1); echo $TYPE")
     [[ $_type == "crypto_LUKS" ]] && echo $1