On Thursday 13 October 2016 03:47 PM, Baoquan He wrote:
On 10/13/16 at 04:16pm, Tong Li wrote:
> Live images are booted with a kernel parameter which looks like
> "root=live:CDLABEL=Fedora-WS-Live-25_A-2". This argument can't be
> recognized by dracut during kdump process and will cause failure
> of kdump if users didn't set KUDMP_COMMANDLINE in /etc/sysconfig/kdump.
> So we should filter 'root' out when we find such a parameter in
> /proc/cmdline to make kdump work correctly in live images.
>
> Signed-off-by: Tong Li <tonli(a)redhat.com>
> ---
> kdumpctl | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/kdumpctl b/kdumpctl
> index d0bbb55..13d85c6 100755
> --- a/kdumpctl
> +++ b/kdumpctl
> @@ -106,6 +106,10 @@ prepare_cmdline()
> local cmdline;
> if [ -z "$KDUMP_COMMANDLINE" ]; then
> cmdline=`cat /proc/cmdline`
> + # 'root' parameter will result kdump failure in live images
~~~ cuase kdump failure
> + if [[ ${cmdline} == *"root=live"* ]]; then
I think, Dave had suggested to use "root=live:".
> + KDUMP_COMMANDLINE_REMOVE="${KDUMP_COMMANDLINE_REMOVE}
root"
> + fi
> else
> cmdline=${KDUMP_COMMANDLINE}
> fi
> --
~Pratyush