[PATCH v2] Relax restriction of dumping on encrypted target

[Arthur Zou]

Resolve: bz1053045

Description:
Currently kdumpctl will fail to create kdump initramfs and start
kdump service while dump target is encrypted. This restriction is
too strict.

Resolution:
Just warn user that encrypted device is in dump path and second
kernel will wait on console for password to be entered.

Signed-off-by: arthur 
---
 mkdumprd | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/mkdumprd b/mkdumprd
index bc002bc..6797791 100644
--- a/mkdumprd
+++ b/mkdumprd
@@ -467,7 +467,7 @@ is_crypt()
     eval "$line"
     [[ "$ID_FS_TYPE" = "crypto_LUKS" ]] && {
         dev=$(udevadm info --query=all --path=/sys/dev/block/$majmin | awk -F= '/DEVNAME/{print $2}')
-        perror "Device $dev is encrypted, can not be used in kdump."
+        echo "Device $dev is encrypted."
         return 0
     }
     return 1
@@ -482,18 +482,11 @@ check_crypt()

[ $_ret -eq 0 ] && return

-    if [ $_ret -eq 1 ]; then
-        _target=$(get_block_dump_target)
-        perror "Can not save vmcore to target device $_target."
-    elif [ $_ret -eq 2 ]; then
-        perror "Default action is dump_to_rootfs but can not save vmcore to root device."
-    fi
-
     return 1
 }

if ! check_crypt; then
-    exit 1
+    echo "Warning: Encrypted device is in dump path. User will prompted for password during second kernel boot." 
 fi

# firstly get right SSH_KEY_LOCATION

[Vivek Goyal]

On Wed, Feb 19, 2014 at 10:02:19AM +0800, arthur wrote:
> Resolve: bz1053045
>
> Description:
> Currently kdumpctl will fail to create kdump initramfs and start
> kdump service while dump target is encrypted. This restriction is
> too strict.
>
> Resolution:
> Just warn user that encrypted device is in dump path and second
> kernel will wait on console for password to be entered.
> Signed-off-by: arthur

Looks good to me.

Acked-by: Vivek Goyal

Arthur, have you verified that this is working well with dumping to
encrypted root?

Thanks
Vivek
> mkdumprd | 11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/mkdumprd b/mkdumprd
> index bc002bc..6797791 100644
> --- a/mkdumprd
> +++ b/mkdumprd
> @@ -467,7 +467,7 @@ is_crypt()
>      eval "$line"
>      [[ "$ID_FS_TYPE" = "crypto_LUKS" ]] && {
>          dev=$(udevadm info --query=all --path=/sys/dev/block/$majmin | awk -F= '/DEVNAME/{print $2}')
>    perror "Device $dev is encrypted, can not be used in kdump."
>    echo "Device $dev is encrypted."
>    return 0
> }
>    return 1
>
> @@ -482,18 +482,11 @@ check_crypt()
>  [ $_ret -eq 0 ] && return
>
> if [ $_ret -eq 1 ]; then
>    _target=$(get_block_dump_target)
>    perror "Can not save vmcore to target device $_target."
> elif [ $_ret -eq 2 ]; then
>    perror "Default action is dump_to_rootfs but can not save vmcore to root device."
> fi
> return 1
>
> }
>
> if ! check_crypt; then
> exit 1
> echo "Warning: Encrypted device is in dump path. User will prompted for password during second kernel boot."
>
> fi
> # firstly get right SSH_KEY_LOCATION
>
> 1.8.4.2
>
> kexec mailing list
> [e-mail]
> https://lists.fedoraproject.org/mailman/listinfo/kexec

[Arthur Zou]

----- Original Message -----
> On Wed, Feb 19, 2014 at 10:02:19AM +0800, arthur wrote:
> > Resolve: bz1053045
> >
> > Description:
> > Currently kdumpctl will fail to create kdump initramfs and start
> > kdump service while dump target is encrypted. This restriction is
> > too strict.
> >
> > Resolution:
> > Just warn user that encrypted device is in dump path and second
> > kernel will wait on console for password to be entered.
> > Signed-off-by: arthur
>
> Looks good to me.
>
> Acked-by: Vivek Goyal
>
> Arthur, have you verified that this is working well with dumping to
> encrypted root?

Hi Vivek
  It works fine. After entering the password in capture kernel, kdump save
the vmcore successfully.

Thanks
Arthur
> Thanks
> Vivek
> > mkdumprd | 11 ++---------
> >  1 file changed, 2 insertions(+), 9 deletions(-)
> >
> > diff --git a/mkdumprd b/mkdumprd
> > index bc002bc..6797791 100644
> > --- a/mkdumprd
> > +++ b/mkdumprd
> > @@ -467,7 +467,7 @@ is_crypt()
> >      eval "$line"
> >      [[ "$ID_FS_TYPE" = "crypto_LUKS" ]] && {
> >          dev=$(udevadm info --query=all --path=/sys/dev/block/$majmin | awk
> >          -F= '/DEVNAME/{print $2}')
> >    perror "Device $dev is encrypted, can not be used in kdump."
> >    echo "Device $dev is encrypted."
> >    return 0
> > }
> >    return 1
> >
> > @@ -482,18 +482,11 @@ check_crypt()
> >  [ $_ret -eq 0 ] && return
> >
> > if [ $_ret -eq 1 ]; then
> >    _target=$(get_block_dump_target)
> >    perror "Can not save vmcore to target device $_target."
> > elif [ $_ret -eq 2 ]; then
> >    perror "Default action is dump_to_rootfs but can not save vmcore
> >
> > to root device."
> > fi
> > return 1
> >
> > }
> >
> > if ! check_crypt; then
> > exit 1
> > echo "Warning: Encrypted device is in dump path. User will prompted
> >
> > for password during second kernel boot."
> >  fi
> > # firstly get right SSH_KEY_LOCATION
> >
> > 1.8.4.2
> >
> > kexec mailing list
> > [e-mail]
> > https://lists.fedoraproject.org/mailman/listinfo/kexec