commit e2dcc4d126b8dee82df9a6f21e66b75905f224c4
Author: Ondrej Lichtner <olichtne(a)redhat.com>
Date: Fri Apr 12 12:20:00 2013 +0200
NetTestCommand: fix deadlock bug
This commit fixes a deadlock situation that appears in case we interrupt
a command which results in the command ending a large amount of data at
once through the communication pipe. The pipe is buffered so the write
operation starts blocking until somebody starts reading from the pipe.
However the main process that would be reading this message is waiting
in a join() call creating a deadlock.
Signed-off-by: Ondrej Lichtner <olichtne(a)redhat.com>
lnst/Common/NetTestCommand.py | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
---
diff --git a/lnst/Common/NetTestCommand.py b/lnst/Common/NetTestCommand.py
index 2ce9b67..b5569a5 100644
--- a/lnst/Common/NetTestCommand.py
+++ b/lnst/Common/NetTestCommand.py
@@ -144,7 +144,6 @@ class NetTestCommand:
if os.path.exists("/proc/%d" % self._pid):
logging.debug("Interrupting background command with id \"%s\",
pid \"%d\"" % (self._id, self._pid))
os.killpg(os.getpgid(self._pid), signal.SIGINT)
- self._process.join()
def kill(self):
if os.path.exists("/proc/%d" % self._pid):
Show replies by date