[PATCH-next] lnst.Recipes.ENRT: fix syntax errors and offloads

From: Christos Sfakianakis <csfakian(a)redhat.com&gt;

Correct last offload combination in VirtualBridgeVlansOverBondRecipe,
set 'tx' to 'off'. Fix missing colon error in TeamRecipe and
TeamVsBondRecipe.

Signed-off-by: Christos Sfakianakis <csfakian(a)redhat.com&gt;
---
 lnst/Recipes/ENRT/TeamRecipe.py                       | 2 +-
 lnst/Recipes/ENRT/TeamVsBondRecipe.py                 | 2 +-
 lnst/Recipes/ENRT/VirtualBridgeVlansOverBondRecipe.py | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lnst/Recipes/ENRT/TeamRecipe.py b/lnst/Recipes/ENRT/TeamRecipe.py
index 10546e6..6b95ccd 100644
--- a/lnst/Recipes/ENRT/TeamRecipe.py
+++ b/lnst/Recipes/ENRT/TeamRecipe.py
@@ -70,6 +70,6 @@ class TeamRecipe(BaseEnrtRecipe):
         m1, m2 = self.matched.m1, self.matched.m2
 
         #TODO better service handling through HostAPI
-        if self.params.dev_intr_cpu
+        if self.params.dev_intr_cpu:
             for m in [m1, m2]:
                 m.run("service irqbalance start")
diff --git a/lnst/Recipes/ENRT/TeamVsBondRecipe.py
b/lnst/Recipes/ENRT/TeamVsBondRecipe.py
index 6db2ace..dfec20e 100644
--- a/lnst/Recipes/ENRT/TeamVsBondRecipe.py
+++ b/lnst/Recipes/ENRT/TeamVsBondRecipe.py
@@ -83,6 +83,6 @@ class TeamVsBondRecipe(BaseEnrtRecipe):
         m1, m2 = self.matched.m1, self.matched.m2
 
         #TODO better service handling through HostAPI
-        if self.params.dev_intr_cpu
+        if self.params.dev_intr_cpu:
             for m in [m1, m2]:
                 m.run("service irqbalance start")
diff --git a/lnst/Recipes/ENRT/VirtualBridgeVlansOverBondRecipe.py
b/lnst/Recipes/ENRT/VirtualBridgeVlansOverBondRecipe.py
index 8918229..feb4f08 100644
--- a/lnst/Recipes/ENRT/VirtualBridgeVlansOverBondRecipe.py
+++ b/lnst/Recipes/ENRT/VirtualBridgeVlansOverBondRecipe.py
@@ -40,7 +40,7 @@ class VirtualBridgeVlansOverBondRecipe(BaseEnrtRecipe):
         dict(gro="on", gso="on", tso="on",
tx="on"),
         dict(gro="off", gso="on", tso="on",
tx="on"),
         dict(gro="on", gso="off", tso="off",
tx="on"),
-        dict(gro="on", gso="on", tso="off",
tx="on")))
+        dict(gro="on", gso="on", tso="off",
tx="off")))
 
     bonding_mode = StrParam(mandatory=True)
     miimon_value = IntParam(mandatory=True)
-- 
2.17.1

[Ondrej Lichtner]

On Fri, Feb 22, 2019 at 03:32:38PM +0100, csfakian(a)redhat.com wrote:
>  From: Christos Sfakianakis <csfakian(a)redhat.com&gt;
>  
>  Correct last offload combination in VirtualBridgeVlansOverBondRecipe,
>  set 'tx' to 'off'. Fix missing colon error in TeamRecipe and
>  TeamVsBondRecipe.
>  
>  Signed-off-by: Christos Sfakianakis <csfakian(a)redhat.com&gt;
>  ---
>   lnst/Recipes/ENRT/TeamRecipe.py                       | 2 +-
>   lnst/Recipes/ENRT/TeamVsBondRecipe.py                 | 2 +-
>   lnst/Recipes/ENRT/VirtualBridgeVlansOverBondRecipe.py | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
>  
>  diff --git a/lnst/Recipes/ENRT/TeamRecipe.py b/lnst/Recipes/ENRT/TeamRecipe.py
>  index 10546e6..6b95ccd 100644
>  --- a/lnst/Recipes/ENRT/TeamRecipe.py
>  +++ b/lnst/Recipes/ENRT/TeamRecipe.py
>  @@ -70,6 +70,6 @@ class TeamRecipe(BaseEnrtRecipe):
>           m1, m2 = self.matched.m1, self.matched.m2
>   
>           #TODO better service handling through HostAPI
>  -        if self.params.dev_intr_cpu
>  +        if self.params.dev_intr_cpu:
>               for m in [m1, m2]:
>                   m.run("service irqbalance start")
>  diff --git a/lnst/Recipes/ENRT/TeamVsBondRecipe.py
> b/lnst/Recipes/ENRT/TeamVsBondRecipe.py
>  index 6db2ace..dfec20e 100644
>  --- a/lnst/Recipes/ENRT/TeamVsBondRecipe.py
>  +++ b/lnst/Recipes/ENRT/TeamVsBondRecipe.py
>  @@ -83,6 +83,6 @@ class TeamVsBondRecipe(BaseEnrtRecipe):
>           m1, m2 = self.matched.m1, self.matched.m2
>   
>           #TODO better service handling through HostAPI
>  -        if self.params.dev_intr_cpu
>  +        if self.params.dev_intr_cpu:
>               for m in [m1, m2]:
>                   m.run("service irqbalance start")
>  diff --git a/lnst/Recipes/ENRT/VirtualBridgeVlansOverBondRecipe.py
> b/lnst/Recipes/ENRT/VirtualBridgeVlansOverBondRecipe.py
>  index 8918229..feb4f08 100644
>  --- a/lnst/Recipes/ENRT/VirtualBridgeVlansOverBondRecipe.py
>  +++ b/lnst/Recipes/ENRT/VirtualBridgeVlansOverBondRecipe.py
>  @@ -40,7 +40,7 @@ class VirtualBridgeVlansOverBondRecipe(BaseEnrtRecipe):
>           dict(gro="on", gso="on", tso="on",
> tx="on"),
>           dict(gro="off", gso="on", tso="on",
> tx="on"),
>           dict(gro="on", gso="off", tso="off",
> tx="on"),
>  -        dict(gro="on", gso="on", tso="off",
> tx="on")))
>  +        dict(gro="on", gso="on", tso="off",
> tx="off")))
>   
>       bonding_mode = StrParam(mandatory=True)
>       miimon_value = IntParam(mandatory=True)
>  -- 
>  2.17.1
>  _______________________________________________
>  LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
>  To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
>  Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
> https://lists.fedorahosted.org/archives/list/[e-mail]...
I'm guessing this patch depends on the previous one since it doesn't
apply without it.

Looks good, please resend it with the fixed previous patch.

-Ondrej

[Christos Sfakianakis]

----- Original Message -----
>  From: "Ondrej Lichtner" <olichtne(a)redhat.com&gt;
>  To: csfakian(a)redhat.com
>  Cc: lnst-developers(a)lists.fedorahosted.org
>  Sent: Wednesday, February 27, 2019 10:07:41 AM
>  Subject: Re: [PATCH-next] lnst.Recipes.ENRT: fix syntax errors and offloads
>  
>  On Fri, Feb 22, 2019 at 03:32:38PM +0100, csfakian(a)redhat.com wrote:
>  > From: Christos Sfakianakis <csfakian(a)redhat.com&gt;
>  > 
>  > Correct last offload combination in VirtualBridgeVlansOverBondRecipe,
>  > set 'tx' to 'off'. Fix missing colon error in TeamRecipe and
>  > TeamVsBondRecipe.
>  > 
>  > Signed-off-by: Christos Sfakianakis <csfakian(a)redhat.com&gt;
>  > ---
>  >  lnst/Recipes/ENRT/TeamRecipe.py                       | 2 +-
>  >  lnst/Recipes/ENRT/TeamVsBondRecipe.py                 | 2 +-
>  >  lnst/Recipes/ENRT/VirtualBridgeVlansOverBondRecipe.py | 2 +-
>  >  3 files changed, 3 insertions(+), 3 deletions(-)
>  > 
>  > diff --git a/lnst/Recipes/ENRT/TeamRecipe.py
>  > b/lnst/Recipes/ENRT/TeamRecipe.py
>  > index 10546e6..6b95ccd 100644
>  > --- a/lnst/Recipes/ENRT/TeamRecipe.py
>  > +++ b/lnst/Recipes/ENRT/TeamRecipe.py
>  > @@ -70,6 +70,6 @@ class TeamRecipe(BaseEnrtRecipe):
>  >          m1, m2 = self.matched.m1, self.matched.m2
>  >  
>  >          #TODO better service handling through HostAPI
>  > -        if self.params.dev_intr_cpu
>  > +        if self.params.dev_intr_cpu:
>  >              for m in [m1, m2]:
>  >                  m.run("service irqbalance start")
>  > diff --git a/lnst/Recipes/ENRT/TeamVsBondRecipe.py
>  > b/lnst/Recipes/ENRT/TeamVsBondRecipe.py
>  > index 6db2ace..dfec20e 100644
>  > --- a/lnst/Recipes/ENRT/TeamVsBondRecipe.py
>  > +++ b/lnst/Recipes/ENRT/TeamVsBondRecipe.py
>  > @@ -83,6 +83,6 @@ class TeamVsBondRecipe(BaseEnrtRecipe):
>  >          m1, m2 = self.matched.m1, self.matched.m2
>  >  
>  >          #TODO better service handling through HostAPI
>  > -        if self.params.dev_intr_cpu
>  > +        if self.params.dev_intr_cpu:
>  >              for m in [m1, m2]:
>  >                  m.run("service irqbalance start")
>  > diff --git a/lnst/Recipes/ENRT/VirtualBridgeVlansOverBondRecipe.py
>  > b/lnst/Recipes/ENRT/VirtualBridgeVlansOverBondRecipe.py
>  > index 8918229..feb4f08 100644
>  > --- a/lnst/Recipes/ENRT/VirtualBridgeVlansOverBondRecipe.py
>  > +++ b/lnst/Recipes/ENRT/VirtualBridgeVlansOverBondRecipe.py
>  > @@ -40,7 +40,7 @@ class VirtualBridgeVlansOverBondRecipe(BaseEnrtRecipe):
>  >          dict(gro="on", gso="on", tso="on",
> tx="on"),
>  >          dict(gro="off", gso="on", tso="on",
> tx="on"),
>  >          dict(gro="on", gso="off", tso="off",
> tx="on"),
>  > -        dict(gro="on", gso="on", tso="off",
> tx="on")))
>  > +        dict(gro="on", gso="on", tso="off",
> tx="off")))
>  >  
>  >      bonding_mode = StrParam(mandatory=True)
>  >      miimon_value = IntParam(mandatory=True)
>  > --
>  > 2.17.1
>  > _______________________________________________
>  > LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
>  > To unsubscribe send an email to
>  > lnst-developers-leave(a)lists.fedorahosted.org
>  > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
>  > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  > List Archives:
>  > https://lists.fedorahosted.org/archives/list/[e-mail]...
>  
>  I'm guessing this patch depends on the previous one since it doesn't
>  apply without it.
>   
That is correct, I will resend it.
> Looks good, please resend it with the fixed previous patch.
> 
> -Ondrej
> _______________________________________________
> LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
> To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedorahosted.org/archives/list/[e-mail]...
>