[PATCH] Recipes.ENRT.DoubleTeamRecipe: remove reversed perf test endpoints

[Jan Tluka]

This scenario is a mirrored setup. There's no real value in running
performance test in both directions. If the test requires testing of
reversed scenario it should inherit from PerfReversibleFlowMixin
class instead.

Signed-off-by: Jan Tluka <jtluka(a)redhat.com&gt;
---
 lnst/Recipes/ENRT/DoubleTeamRecipe.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lnst/Recipes/ENRT/DoubleTeamRecipe.py
b/lnst/Recipes/ENRT/DoubleTeamRecipe.py
index 39e069e5..305ffdeb 100644
--- a/lnst/Recipes/ENRT/DoubleTeamRecipe.py
+++ b/lnst/Recipes/ENRT/DoubleTeamRecipe.py
@@ -92,8 +92,7 @@ class DoubleTeamRecipe(CommonHWSubConfigMixin, OffloadSubConfigMixin,
         ]
 
     def generate_perf_endpoints(self, config):
-        return [(self.matched.host1.team0, self.matched.host2.team0),
-            (self.matched.host2.team0, self.matched.host1.team0)]
+        return [(self.matched.host1.team0, self.matched.host2.team0)]
 
     @property
     def offload_nics(self):
-- 
2.21.3

[Jan Tluka]

Scratch this one as I've already sent a patch for this few weeks ago.

-Jan

Thu, Aug 27, 2020 at 09:54:43AM CEST, jtluka(a)redhat.com wrote:
> This scenario is a mirrored setup. There's no real value in
> running
> performance test in both directions. If the test requires testing of
> reversed scenario it should inherit from PerfReversibleFlowMixin
> class instead.
>
> Signed-off-by: Jan Tluka <jtluka(a)redhat.com&gt;
> ---
>  lnst/Recipes/ENRT/DoubleTeamRecipe.py | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lnst/Recipes/ENRT/DoubleTeamRecipe.py
> b/lnst/Recipes/ENRT/DoubleTeamRecipe.py
> index 39e069e5..305ffdeb 100644
> --- a/lnst/Recipes/ENRT/DoubleTeamRecipe.py
> +++ b/lnst/Recipes/ENRT/DoubleTeamRecipe.py
> @@ -92,8 +92,7 @@ class DoubleTeamRecipe(CommonHWSubConfigMixin, OffloadSubConfigMixin,
>          ]
>  
>      def generate_perf_endpoints(self, config):
> -        return [(self.matched.host1.team0, self.matched.host2.team0),
> -            (self.matched.host2.team0, self.matched.host1.team0)]
> +        return [(self.matched.host1.team0, self.matched.host2.team0)]
>  
>      @property
>      def offload_nics(self):
> -- 
> 2.21.3
> _______________________________________________
> LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
> To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedorahosted.org/archives/list/[e-mail]...

[Jan Tluka]

Thu, Aug 27, 2020 at 10:22:33AM CEST, jtluka(a)redhat.com wrote:
> Scratch this one as I've already sent a patch for this few weeks
> ago.
>
> -Jan
>  
Sorry for noise. This patch is actually needed. The patch I sent few
weeks ago removed the perf_reverse parameter.

This patch removes duplicate perf endpoints in
generate_perf_endpoints().

-Jan

> Thu, Aug 27, 2020 at 09:54:43AM CEST, jtluka(a)redhat.com wrote:
> >This scenario is a mirrored setup. There's no real value in running
> >performance test in both directions. If the test requires testing of
> >reversed scenario it should inherit from PerfReversibleFlowMixin
> >class instead.
> >
> >Signed-off-by: Jan Tluka <jtluka(a)redhat.com&gt;
> >---
> > lnst/Recipes/ENRT/DoubleTeamRecipe.py | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> >diff --git a/lnst/Recipes/ENRT/DoubleTeamRecipe.py
> b/lnst/Recipes/ENRT/DoubleTeamRecipe.py
> >index 39e069e5..305ffdeb 100644
> >--- a/lnst/Recipes/ENRT/DoubleTeamRecipe.py
> >+++ b/lnst/Recipes/ENRT/DoubleTeamRecipe.py
> >@@ -92,8 +92,7 @@ class DoubleTeamRecipe(CommonHWSubConfigMixin,
> OffloadSubConfigMixin,
> >         ]
> > 
> >     def generate_perf_endpoints(self, config):
> >-        return [(self.matched.host1.team0, self.matched.host2.team0),
> >-            (self.matched.host2.team0, self.matched.host1.team0)]
> >+        return [(self.matched.host1.team0, self.matched.host2.team0)]
> > 
> >     @property
> >     def offload_nics(self):
> >-- 
> >2.21.3
> >_______________________________________________
> >LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
> >To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
> >Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> >List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> >List Archives:
> https://lists.fedorahosted.org/archives/list/[e-mail]...

[Jan Tluka]

Thu, Aug 27, 2020 at 09:54:43AM CEST, jtluka(a)redhat.com wrote:
> This scenario is a mirrored setup. There's no real value in
> running
> performance test in both directions. If the test requires testing of
> reversed scenario it should inherit from PerfReversibleFlowMixin
> class instead.
>
> Signed-off-by: Jan Tluka <jtluka(a)redhat.com&gt;
> ---
>  lnst/Recipes/ENRT/DoubleTeamRecipe.py | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lnst/Recipes/ENRT/DoubleTeamRecipe.py
> b/lnst/Recipes/ENRT/DoubleTeamRecipe.py
> index 39e069e5..305ffdeb 100644
> --- a/lnst/Recipes/ENRT/DoubleTeamRecipe.py
> +++ b/lnst/Recipes/ENRT/DoubleTeamRecipe.py
> @@ -92,8 +92,7 @@ class DoubleTeamRecipe(CommonHWSubConfigMixin, OffloadSubConfigMixin,
>          ]
>  
>      def generate_perf_endpoints(self, config):
> -        return [(self.matched.host1.team0, self.matched.host2.team0),
> -            (self.matched.host2.team0, self.matched.host1.team0)]
> +        return [(self.matched.host1.team0, self.matched.host2.team0)]
>  
>      @property
>      def offload_nics(self):
> -- 
> 2.21.3
> _______________________________________________
> LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
> To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedorahosted.org/archives/list/[e-mail]...
Applied.

-Jan