[PATCH] Revert "RecipeCommon.Perf.Evaluators.BaselineFlowAverageEvaluator: override group_results"

[Jan Tluka]

This reverts commit 0271ddd201033346938ab8dc98d6cf1610e7a2d5.

It turned out that this patch is not required. If a user needs to
evaluate the aggregated flows a new evaluator class should be created
and added to the evaluators list. The aggregation of the data then
should be called from within this new evaluator class.

Signed-off-by: Jan Tluka 
---
 .../Perf/Evaluators/BaselineFlowAverageEvaluator.py    | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/lnst/RecipeCommon/Perf/Evaluators/BaselineFlowAverageEvaluator.py b/lnst/RecipeCommon/Perf/Evaluators/BaselineFlowAverageEvaluator.py
index 26b6f740..5d2c014d 100644
--- a/lnst/RecipeCommon/Perf/Evaluators/BaselineFlowAverageEvaluator.py
+++ b/lnst/RecipeCommon/Perf/Evaluators/BaselineFlowAverageEvaluator.py
@@ -30,16 +30,6 @@ class BaselineFlowAverageEvaluator(BaselineEvaluator):
                 "receiver_cpu_stats",
             ]

-    def group_results(
-        self,
-        recipe: BaseRecipe,
-        recipe_conf: PerfRecipeConf,
-        results: List[PerfMeasurementResults],
-    ) -> List[List[PerfMeasurementResults]]:
-        new_results = results[0].measurement.aggregate_multi_flow_results(results)
-
-        return [new_results]
-
     def describe_group_results(
         self,
         recipe: BaseRecipe,

[Ondrej Lichtner]

looks good, pushed.

-Ondrej

On Fri, Mar 05, 2021 at 09:44:20AM +0100, Jan Tluka wrote:
> This reverts commit 0271ddd201033346938ab8dc98d6cf1610e7a2d5.
>
> It turned out that this patch is not required. If a user needs to
> evaluate the aggregated flows a new evaluator class should be created
> and added to the evaluators list. The aggregation of the data then
> should be called from within this new evaluator class.
> Signed-off-by: Jan Tluka
>
> .../Perf/Evaluators/BaselineFlowAverageEvaluator.py    | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/lnst/RecipeCommon/Perf/Evaluators/BaselineFlowAverageEvaluator.py b/lnst/RecipeCommon/Perf/Evaluators/BaselineFlowAverageEvaluator.py
> index 26b6f740..5d2c014d 100644
> --- a/lnst/RecipeCommon/Perf/Evaluators/BaselineFlowAverageEvaluator.py
> +++ b/lnst/RecipeCommon/Perf/Evaluators/BaselineFlowAverageEvaluator.py
> @@ -30,16 +30,6 @@ class BaselineFlowAverageEvaluator(BaselineEvaluator):
>                  "receiver_cpu_stats",
>              ]
> def group_results(
>    self,
>    recipe: BaseRecipe,
>    recipe_conf: PerfRecipeConf,
>    results: List[PerfMeasurementResults],
> ) -> List[List[PerfMeasurementResults]]:
>    new_results = results[0].measurement.aggregate_multi_flow_results(results)
>    return [new_results]
> def describe_group_results(
>        self,
>        recipe: BaseRecipe,
>
> -- 
> 2.26.2
> _______________________________________________
> LNST-developers mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedorahosted.org/archives/list/[e-mail]...
> Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure