-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 05/20/2013 10:32 PM, T.C. Hollingsworth wrote:
On Mon, May 20, 2013 at 5:49 AM, Stephen Gallagher sgallagh@redhat.com wrote:
On 05/20/2013 08:41 AM, Tom Hughes wrote:
On 20/05/13 13:30, Stephen Gallagher wrote:
Is there any way to add ExclusiveArch to the %{?nodejs_find_provides_and_requires} macro in the main node package so that we won't try to build the modules on unsupported architectures? It would be a lot less effort to fix that macro than it would be to fix every node module.
No - a version of was tried for the binary modules. The plan was to do:
ExclusiveArch: %{nodejs_arches}
so that %{nodejs_arches} could be updated easily if v8 adds support for more architectures.
It didn't work though because nodejs-devel is not installed on the builders at the point when they are working out what arches to build on, so you just get:
BuildError: No matching arches were found
The only way to make it work (actually you pointed this out at the time I think) would be to get the macros into the minimal build root, perhaps by moving them from nodejs-devel to redhat-rpm-config.
Ahh, right. I forgot we already had this discussion. Ok, do we have a bug files with redhat-rpm-config? I'm reasonably sure that this would be accepted by them (since it's in the spirit of conformance with the accepted packaging guidelines).
Yeah, I filed a bug after the last thread regarding this: https://bugzilla.redhat.com/show_bug.cgi?id=921291
If not, can someone who knows RPM macros better than I do prepare a patch and submit it (CCing the folks on this list so we can keep track), please?
I'm not sure where my head was when I originally filed the bug, because the answer to my question in the first comment is plainly obvious when you actually look at the package (or even the package's name!) ;-) I've added a patch to the bug now.
FYI, Panu has added the patch to redhat-rpm-config and pushed a Bodhi update to testing: https://admin.fedoraproject.org/updates/redhat-rpm-config-9.1.0-45.fc19
Please add the %nodejs_arches to the ExclusiveArch line in your nodejs-* packages and rebuild against them locally with this package and give karma. I can also tag it into a buildroot override if we want to start rebuilding all of the official nodejs packages.