Fwd: [HELPWANTED] Building jquery for F24 branch

[Christopher]

Hello. I'm trying to get js-jquery1 to build on F24, and was wondering if
anybody in the Node.js SIG could help me. See forwarded message below with
all the details from [e-mail].

Thanks.

---------- Forwarded message ---------
From: Christopher 
Date: Tue, Nov 29, 2016 at 8:30 PM
Subject: Re: [HELPWANTED] Building jquery for F24 branch
To: Development discussions related to Fedora <[e-mail]
>

On Tue, Nov 29, 2016 at 8:13 PM Tom Hughes  wrote:

On 30/11/16 01:02, Christopher wrote:
> Can anybody help me build js-jquery1 for F24? I keep getting some NodeJS
> and/or Grunt error with uglify, but only for the F24 branch. I want to
> update the package, and I can get all the other branches to build just
> fine (including EPEL7, F25, and rawhide), but F24 is broken even before
> I apply any updates/changes, and I'm not sure why.

Well the Node.js SIG are probably the people to ask, but I can't see any
builds on koji, so if you want help you're going to have to point us at
the build or give us some more information about the error you are seeing.

I figured I'd ask for help first, before spamming this list with details :)
But, the failure is reproducible with mockbuild. Here's a scratch build
which failed: http://koji.fedoraproject.org/koji/taskinfo?taskID=16675312
I can check with the Node.js SIG (I didn't realize such a thing existed).

If you're planning to update from 1.11 to 1.12 then I would have to ask
if that is even appropriate in a released version anyway...

That's a good question. I'm not sure. It really depends on what API changes
upstream is making, and who depends on the js-jquery1 compat package. At
first, I would have said yes, to get the security fix for
https://bugzilla.redhat.com/show_bug.cgi?id=1399547 . However, I now
realize that the patch they had applied to 1.12 for that was never
released, and was instead reverted in all branches before 3.0, which isn't
even packaged (yet) in Fedora. So now, the options are to backport the fix
to the versions in Fedora... or to ignore the issue until we update to 3.0.
Even if we ignore, it doesn't resolve the question about what to do with
the compat packages for jquery1 (and maybe a future compat package for
jquery2).

Whether or not we upgrade or backport a security fix, I can't proceed at
all on the F24 branch right now.

Tom

--
Tom Hughes ([e-mail])
http://compton.nu/

[HELPWANTED] Building jquery for F24 branch

[Christopher]

Just want to re-ping this list to see if there's any help anybody can offer
for this FTBFS on F24 for js-jquery and js-jquery1.
In short, it seems there is a failure with npm uglify task. It seems to
only affect the f24 branch. f23 and f25, using the same code, seems to
build perfectly fine.

This is blocking any progress on fixing/patching/updating both js-jquery1
and js-jquery in F24.

Does anybody know what's different in F24 that would affect npm uglyify?

On Wed, Nov 30, 2016 at 6:05 PM Christopher 
wrote:
> Hello. I'm trying to get js-jquery1 to build on F24, and was wondering if
> anybody in the Node.js SIG could help me. See forwarded message below with
> all the details from [e-mail].
>
> Thanks.
>
> ---------- Forwarded message ---------
> From: Christopher 
> Date: Tue, Nov 29, 2016 at 8:30 PM
> Subject: Re: [HELPWANTED] Building jquery for F24 branch
> To: Development discussions related to Fedora <
> [e-mail]>
>
> On Tue, Nov 29, 2016 at 8:13 PM Tom Hughes  wrote:
>
> On 30/11/16 01:02, Christopher wrote:
> > Can anybody help me build js-jquery1 for F24? I keep getting some NodeJS
> > and/or Grunt error with uglify, but only for the F24 branch. I want to
> > update the package, and I can get all the other branches to build just
> > fine (including EPEL7, F25, and rawhide), but F24 is broken even before
> > I apply any updates/changes, and I'm not sure why.
>
> Well the Node.js SIG are probably the people to ask, but I can't see any
> builds on koji, so if you want help you're going to have to point us at
> the build or give us some more information about the error you are seeing.
>
> I figured I'd ask for help first, before spamming this list with details :)
> But, the failure is reproducible with mockbuild. Here's a scratch build
> which failed: http://koji.fedoraproject.org/koji/taskinfo?taskID=16675312
> I can check with the Node.js SIG (I didn't realize such a thing existed).
>
> If you're planning to update from 1.11 to 1.12 then I would have to ask
> if that is even appropriate in a released version anyway...
>
> That's a good question. I'm not sure. It really depends on what API
> changes upstream is making, and who depends on the js-jquery1 compat
> package. At first, I would have said yes, to get the security fix for
> https://bugzilla.redhat.com/show_bug.cgi?id=1399547 . However, I now
> realize that the patch they had applied to 1.12 for that was never
> released, and was instead reverted in all branches before 3.0, which isn't
> even packaged (yet) in Fedora. So now, the options are to backport the fix
> to the versions in Fedora... or to ignore the issue until we update to 3.0.
> Even if we ignore, it doesn't resolve the question about what to do with
> the compat packages for jquery1 (and maybe a future compat package for
> jquery2).
>
> Whether or not we upgrade or backport a security fix, I can't proceed at
> all on the F24 branch right now.
>
> Tom
>
> --
> Tom Hughes ([e-mail])
> http://compton.nu/

[HELPWANTED] Building jquery for F24 branch

[Dan Callaghan]

Excerpts from Christopher's message of 2016-12-07 00:08 +00:00:
> Just want to re-ping this list to see if there's any help anybody can offer
> for this FTBFS on F24 for js-jquery and js-jquery1.
> In short, it seems there is a failure with npm uglify task. It seems to
> only affect the f24 branch. f23 and f25, using the same code, seems to
> build perfectly fine.
>
> This is blocking any progress on fixing/patching/updating both js-jquery1
> and js-jquery in F24.
>
> Does anybody know what's different in F24 that would affect npm uglyify?

Your error:

Verifying property uglify.all exists in config...Warning: An error 
    occurred while processing a template (tmpl.indexOf is not 
    a function). Use --force to continue.

looks suspiciously like this bug:

https://bugzilla.redhat.com/show_bug.cgi?id=1295295

which caused a FTBFS in F24 one of my Nodejs packages as well. There was 
no resolution in F24 for... whatever reason.

[HELPWANTED] Building jquery for F24 branch

[Christopher]

On Tue, Dec 6, 2016 at 7:21 PM Dan Callaghan  wrote:
> Excerpts from Christopher's message of 2016-12-07 00:08 +00:00:
> > Just want to re-ping this list to see if there's any help anybody can
>
> offer
> > for this FTBFS on F24 for js-jquery and js-jquery1.
> > In short, it seems there is a failure with npm uglify task. It seems to
> > only affect the f24 branch. f23 and f25, using the same code, seems to
> > build perfectly fine.
> >
> > This is blocking any progress on fixing/patching/updating both js-jquery1
> > and js-jquery in F24.
> >
> > Does anybody know what's different in F24 that would affect npm uglyify?
>
> Your error:
> Verifying property uglify.all exists in config...Warning: An error
> occurred while processing a template (tmpl.indexOf is not
> a function). Use --force to continue.
>
> looks suspiciously like this bug:
> https://bugzilla.redhat.com/show_bug.cgi?id=1295295

Yeah, after some investigation. I concur. This is
https://bugzilla.redhat.com/show_bug.cgi?id=1295295, which was fixed in
F25, but not in F24.
I've reopened. Hopefully it can be fixed in F24?
> which caused a FTBFS in F24 one of my Nodejs packages as well. There was
> no resolution in F24 for... whatever reason.
>
> --
> Dan Callaghan 
> Senior Software Engineer, Products & Technologies Operations
> Red Hat

[HELPWANTED] Building jquery for F24 branch

[Piotr Popieluch]

I had to update a lot of (circular)  dependencies and was worried to break
something in the released branches.

Op wo 7 dec. 2016 01:30 schreef Christopher :
> On Tue, Dec 6, 2016 at 7:21 PM Dan Callaghan  wrote:
>
> Excerpts from Christopher's message of 2016-12-07 00:08 +00:00:
> > Just want to re-ping this list to see if there's any help anybody can
>
> offer
> > for this FTBFS on F24 for js-jquery and js-jquery1.
> > In short, it seems there is a failure with npm uglify task. It seems to
> > only affect the f24 branch. f23 and f25, using the same code, seems to
> > build perfectly fine.
> >
> > This is blocking any progress on fixing/patching/updating both js-jquery1
> > and js-jquery in F24.
> >
> > Does anybody know what's different in F24 that would affect npm uglyify?
>
> Your error:
> Verifying property uglify.all exists in config...Warning: An error
> occurred while processing a template (tmpl.indexOf is not
> a function). Use --force to continue.
>
> looks suspiciously like this bug:
> https://bugzilla.redhat.com/show_bug.cgi?id=1295295
>
>
> Yeah, after some investigation. I concur. This is
> https://bugzilla.redhat.com/show_bug.cgi?id=1295295, which was fixed in
> F25, but not in F24.
> I've reopened. Hopefully it can be fixed in F24?
>
> which caused a FTBFS in F24 one of my Nodejs packages as well. There was
> no resolution in F24 for... whatever reason.
>
> --
> Dan Callaghan 
> Senior Software Engineer, Products & Technologies Operations
> Red Hat
>
> nodejs mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[HELPWANTED] Building jquery for F24 branch

[Christopher]

Is there an alternative or workaround for packages which require this fix?
There's a potential XSS vulnerability in jquery I'd like to patch... but
can't if I can't get a successful build. If the fix cannot be backported to
F24, can grunt be downgraded to the last working version in F24?

On Wed, Dec 7, 2016 at 2:36 AM Piotr Popieluch  wrote:
> I had to update a lot of (circular)  dependencies and was worried to break
> something in the released branches.
>
> Op wo 7 dec. 2016 01:30 schreef Christopher :
>
> On Tue, Dec 6, 2016 at 7:21 PM Dan Callaghan  wrote:
>
> Excerpts from Christopher's message of 2016-12-07 00:08 +00:00:
> > Just want to re-ping this list to see if there's any help anybody can
>
> offer
> > for this FTBFS on F24 for js-jquery and js-jquery1.
> > In short, it seems there is a failure with npm uglify task. It seems to
> > only affect the f24 branch. f23 and f25, using the same code, seems to
> > build perfectly fine.
> >
> > This is blocking any progress on fixing/patching/updating both js-jquery1
> > and js-jquery in F24.
> >
> > Does anybody know what's different in F24 that would affect npm uglyify?
>
> Your error:
> Verifying property uglify.all exists in config...Warning: An error
> occurred while processing a template (tmpl.indexOf is not
> a function). Use --force to continue.
>
> looks suspiciously like this bug:
> https://bugzilla.redhat.com/show_bug.cgi?id=1295295
>
>
> Yeah, after some investigation. I concur. This is
> https://bugzilla.redhat.com/show_bug.cgi?id=1295295, which was fixed in
> F25, but not in F24.
> I've reopened. Hopefully it can be fixed in F24?
>
> which caused a FTBFS in F24 one of my Nodejs packages as well. There was
> no resolution in F24 for... whatever reason.
>
> --
> Dan Callaghan 
> Senior Software Engineer, Products & Technologies Operations
> Red Hat
>
> nodejs mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
>
> nodejs mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[HELPWANTED] Building jquery for F24 branch

[Piotr Popieluch]

Op wo 7 dec. 2016 10:02 schreef Christopher :

Is there an alternative or workaround for packages which require this fix?
There's a potential XSS vulnerability in jquery I'd like to patch... but
can't if I can't get a successful build. If the fix cannot be backported to
F24, can grunt be downgraded to the last working version in F24?

I think the issue was that grunt was not compatible with the updated
lodash. Updating grunt makes more sense than downgrading lodash.

Following packages need to be updated:
nodejs-figures
nodejs-maxmin
nodejs-grunt
nodejs-grunt-cli
nodejs-grunt-legacy-log
nodejs-grunt-legacy-log-utils
nodejs-grunt-legacy-util

[HELPWANTED] Building jquery for F24 branch

[Piotr Popieluch]

Op wo 7 dec. 2016 om 21:46 schreef Piotr Popieluch :
> Op wo 7 dec. 2016 10:02 schreef Christopher :
>
> Is there an alternative or workaround for packages which require this fix?
> There's a potential XSS vulnerability in jquery I'd like to patch... but
> can't if I can't get a successful build. If the fix cannot be backported to
> F24, can grunt be downgraded to the last working version in F24?
>
> I think the issue was that grunt was not compatible with the updated
> lodash. Updating grunt makes more sense than downgrading lodash.
>
> Following packages need to be updated:
> nodejs-figures
> nodejs-maxmin
> nodejs-grunt
> nodejs-grunt-cli
> nodejs-grunt-legacy-log
> nodejs-grunt-legacy-log-utils
> nodejs-grunt-legacy-util

Some more packages needed updates. I think I got everything built and
created all needed buildroot overrides.

js-jquery1 scratch build succeeds now, please check if you can build the
update now:
koji.fedoraproject.org/koji/taskinfo?taskID=16847838

[HELPWANTED] Building jquery for F24 branch

[Christopher]

On Sun, Dec 11, 2016, 16:29 Piotr Popieluch  wrote:
> Op wo 7 dec. 2016 om 21:46 schreef Piotr Popieluch :
>
> Op wo 7 dec. 2016 10:02 schreef Christopher :
>
> Is there an alternative or workaround for packages which require this fix?
> There's a potential XSS vulnerability in jquery I'd like to patch... but
> can't if I can't get a successful build. If the fix cannot be backported to
> F24, can grunt be downgraded to the last working version in F24?
>
> I think the issue was that grunt was not compatible with the updated
> lodash. Updating grunt makes more sense than downgrading lodash.
>
> Following packages need to be updated:
> nodejs-figures
> nodejs-maxmin
> nodejs-grunt
> nodejs-grunt-cli
> nodejs-grunt-legacy-log
> nodejs-grunt-legacy-log-utils
> nodejs-grunt-legacy-util
>
> Some more packages needed updates. I think I got everything built and
> created all needed buildroot overrides.
>
> js-jquery1 scratch build succeeds now, please check if you can build the
> update now:
> koji.fedoraproject.org/koji/taskinfo?taskID=16847838

Sorry for late reply. Yes, it works, but something is wrong in bodhi and I
can't see karma and comments section to grant karma.

+1 big thanks.
>