August 2014 - openlmi-reviews - Fedora Mailing-Lists

Review Request 1986: [1/1] implement SELinux provider

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1986/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- implement SELinux provider Diffs ----- CMakeLists.txt 463da8c63a314dd34595710a127a0429f89edc49 mof/60_LMI_SELinux.mof PRE-CREATION mof/60_LMI_SELinux.reg PRE-CREATION mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69 src/.dir-locals.el PRE-CREATION src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800 src/libs/jobmanager/lmi_job.c 004e6a72c9f5c36acfa3f4062a5a036ab0843d39 src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90 src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26 src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323 src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION src/selinux/CMakeLists.txt PRE-CREATION src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION src/selinux/selinux.h PRE-CREATION src/selinux/selinux.c PRE-CREATION src/selinux/test/README PRE-CREATION src/selinux/test/__init__.py PRE-CREATION src/selinux/test/test_selinux.py PRE-CREATION Diff: http://reviewboard-openlmi.rhcloud.com/r/1986/diff/ Testing ------- Thanks, Jan Synacek

9 years, 7 months

1
21
0 / 0

Review Request 1981: openlmi-storage: Fixed creation of btrfs volumes.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1981/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Fixed creation of btrfs volumes. When returning the created format on e.g. /dev/sdb1, we must look for the format on BTRFSVolumeDevice (child of /dev/sdb1), not on /dev/sdb1 itself. Diffs ----- src/lmi/storage/LMI_FileSystemConfigurationService.py f6e21cdacaea091519cda5a744973076ea36a158 Diff: http://reviewboard-openlmi.rhcloud.com/r/1981/diff/ Testing ------- Thanks, Jan Safranek

9 years, 8 months

1
2
0 / 0

Review Request 1938: Implemented LMI_ScsiScan method.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1938/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Implemented LMI_ScsiScan method. LMI_ScsiScan is just a copy of DMTF's ScsiScan, only with proper return value '4096' when a job is returned - DMTF's method does not have such return value. Also, I removed its parameters we do not support for now, it may be added in future versions. Diffs ----- mof/LMI_Storage-BlockStorage.mof 22e2e2018d0294d11b76017cd00fbd34ac32619d mof/LMI_Storage-MethodParameters.mof ac0271ed3e96c40a29502da00dc8433be465a286 openlmi-storage.spec a9226e01cfe6530cf40f9efe0629703c01a4144f src/lmi/storage/LMI_StorageConfigurationService.py 431ee211b9fb5c99858c897049e6ddfd8b962298 Diff: http://reviewboard-openlmi.rhcloud.com/r/1938/diff/ Testing ------- Thanks, Jan Safranek

9 years, 8 months

1
2
0 / 0

Review Request 1937: Fixed values of LocalFileSystem properties.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1937/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Fixed values of LocalFileSystem properties. The model values must be reset if there is no value for some of them, otherwise the values from previously returned instance are used. Diffs ----- src/lmi/storage/LocalFileSystemProvider.py 93cb949f2ff46276615e101e7f86a322aef675e8 Diff: http://reviewboard-openlmi.rhcloud.com/r/1937/diff/ Testing ------- Thanks, Jan Safranek

9 years, 8 months

1
5
0 / 0

Review Request 1976: sw-tests: updated test_resource_for_software_identity for package-kit

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1976/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- Skip tests dealing with associators, as those methods are not supported in new software-dbus. Associator names are still being tested. Diffs ----- src/software/test/test_resource_for_software_identity.py 5608d6966b4fca59902095dd0eeedc7d50e99a27 Diff: http://reviewboard-openlmi.rhcloud.com/r/1976/diff/ Testing ------- Thanks, Peter Schiffer

9 years, 8 months

1
2
0 / 0

Review Request 1980: lmishell, fix compat indication listener

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1980/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-tools Description ------- Fix indication delivery when using compat listener. The problem was caused by wrong prefix prefix present in the indication name. Diffs ----- cli/lmi/shell/LMIMethod.py 885f251e4dd64de5261f32e7c538f02a0c55fd17 cli/lmi/shell/compat/CIMIndicationListener.py 6b8a2d18a5594925942ce79e282879f0e35f35ab Diff: http://reviewboard-openlmi.rhcloud.com/r/1980/diff/ Testing ------- Tested using LMI_FileSystemConfigurationService.SyncLMI_CreateFileSystem(...) Thanks, Peter Hatina

9 years, 8 months

1
8
0 / 0

Review Request 1571: [1/1] Explicitly add LVM devices to list of blivet devices.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1571/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Explicitly add LVM devices to list of blivet devices. Blivet doesn't contain VGs or LVs anymore. Work around that issue. Diffs ----- src/lmi/storage/util/storage.py ff6da1be1eaf2c0098bb465ac711d1e8454dc77a Diff: http://reviewboard-openlmi.rhcloud.com/r/1571/diff/ Testing ------- Thanks, Jan Synacek

9 years, 8 months

1
4
0 / 0

Review Request 1960: software(tests): added a test suite for LMI_SoftwareInstallationJob

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1960/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- software(tests): added a test suite for LMI_SoftwareInstallationJob This covers a lot of job manager's functionality. Diffs ----- src/software/test/test_software_installation_job.py PRE-CREATION Diff: http://reviewboard-openlmi.rhcloud.com/r/1960/diff/ Testing ------- Thanks, Michal Minar

9 years, 8 months

1
4
0 / 0

Review Request 1975: sw-python(fixes) [7/7] software: associate old package to update job

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1975/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- software: associate old package to update job Associate both old and newer package with update job as an affected job element. Previously installed package was associated until the job had been completed. Since then only the newly installed package was associated. Diffs ----- src/software/lmi/software/core/AffectedSoftwareJobElement.py 0bbc7c7f0c3b2320701bc3cde0e606ec6dc3de3e src/software/lmi/software/yumdb/process.py 21d6e7ed6195ae766fd5119a08195b3541933c6a Diff: http://reviewboard-openlmi.rhcloud.com/r/1975/diff/ Testing ------- Thanks, Michal Minar

9 years, 8 months

1
2
0 / 0

Review Request 1974: sw-python(fixes) [6/7] software: fixes in package installation and searching

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1974/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- software: fixes in package installation and searching Support package downgrades. Raise ERR_ALREADY_EXISTS instead of ERR_NOT_FOUND when installation of already installed package is requested without a force flag. Fixed searching for not newest, available packages. Diffs ----- src/software/lmi/software/yumdb/process.py 21d6e7ed6195ae766fd5119a08195b3541933c6a Diff: http://reviewboard-openlmi.rhcloud.com/r/1974/diff/ Testing ------- Thanks, Michal Minar

9 years, 8 months

1
2
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

openlmi-reviews August 2014