Review Request 1986: [1/1] implement SELinux provider

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

implement SELinux provider


Diffs
-----

  CMakeLists.txt 463da8c63a314dd34595710a127a0429f89edc49 
  mof/60_LMI_SELinux.mof PRE-CREATION 
  mof/60_LMI_SELinux.reg PRE-CREATION 
  mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION 
  mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69 
  src/.dir-locals.el PRE-CREATION 
  src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800 
  src/libs/jobmanager/lmi_job.c 004e6a72c9f5c36acfa3f4062a5a036ab0843d39 
  src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90 
  src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a 
  src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26 
  src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323 
  src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION 
  src/selinux/CMakeLists.txt PRE-CREATION 
  src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION 
  src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION 
  src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION 
  src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION 
  src/selinux/selinux.h PRE-CREATION 
  src/selinux/selinux.c PRE-CREATION 
  src/selinux/test/README PRE-CREATION 
  src/selinux/test/__init__.py PRE-CREATION 
  src/selinux/test/test_selinux.py PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1986/diff/


Testing
-------


Thanks,

Jan Synacek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/
-----------------------------------------------------------

(Updated Aug. 29, 2014, 12:56 p.m.)


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description (updated)
-------

implement SELinux provider

In case diffs don't work, I'll track changes in my WIP branch until the patch is
merged:

https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel


Diffs
-----

  CMakeLists.txt 463da8c63a314dd34595710a127a0429f89edc49 
  mof/60_LMI_SELinux.mof PRE-CREATION 
  mof/60_LMI_SELinux.reg PRE-CREATION 
  mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION 
  mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69 
  src/.dir-locals.el PRE-CREATION 
  src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800 
  src/libs/jobmanager/lmi_job.c 004e6a72c9f5c36acfa3f4062a5a036ab0843d39 
  src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90 
  src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a 
  src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26 
  src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323 
  src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION 
  src/selinux/CMakeLists.txt PRE-CREATION 
  src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION 
  src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION 
  src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION 
  src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION 
  src/selinux/selinux.h PRE-CREATION 
  src/selinux/selinux.c PRE-CREATION 
  src/selinux/test/README PRE-CREATION 
  src/selinux/test/__init__.py PRE-CREATION 
  src/selinux/test/test_selinux.py PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1986/diff/


Testing
-------


Thanks,

Jan Synacek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/#review3268
-----------------------------------------------------------


Autoscan started for review(s) 1986[1]

- scanbot


On Aug. 29, 2014, 10:56 a.m., Jan Synacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1986/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 29, 2014, 10:56 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  implement SELinux provider
>  
>  In case diffs don't work, I'll track changes in my WIP branch until the patch is
> merged:
>  
>  https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt 463da8c63a314dd34595710a127a0429f89edc49 
>    mof/60_LMI_SELinux.mof PRE-CREATION 
>    mof/60_LMI_SELinux.reg PRE-CREATION 
>    mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION 
>    mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69 
>    src/.dir-locals.el PRE-CREATION 
>    src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800 
>    src/libs/jobmanager/lmi_job.c 004e6a72c9f5c36acfa3f4062a5a036ab0843d39 
>    src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90 
>    src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a 
>    src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26 
>    src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323 
>    src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION 
>    src/selinux/CMakeLists.txt PRE-CREATION 
>    src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION 
>    src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION 
>    src/selinux/selinux.h PRE-CREATION 
>    src/selinux/selinux.c PRE-CREATION 
>    src/selinux/test/README PRE-CREATION 
>    src/selinux/test/__init__.py PRE-CREATION 
>    src/selinux/test/test_selinux.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1986/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Synacek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/#review3269
-----------------------------------------------------------


Autoscan failed: FAILED
This can indicate any failure like broken buildroot to patch failed to apply. Manual
investigation of scan log is needed.
Scanned reviews: 1986

- scanbot


On Aug. 29, 2014, 10:56 a.m., Jan Synacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1986/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 29, 2014, 10:56 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  implement SELinux provider
>  
>  In case diffs don't work, I'll track changes in my WIP branch until the patch is
> merged:
>  
>  https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt 463da8c63a314dd34595710a127a0429f89edc49 
>    mof/60_LMI_SELinux.mof PRE-CREATION 
>    mof/60_LMI_SELinux.reg PRE-CREATION 
>    mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION 
>    mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69 
>    src/.dir-locals.el PRE-CREATION 
>    src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800 
>    src/libs/jobmanager/lmi_job.c 004e6a72c9f5c36acfa3f4062a5a036ab0843d39 
>    src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90 
>    src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a 
>    src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26 
>    src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323 
>    src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION 
>    src/selinux/CMakeLists.txt PRE-CREATION 
>    src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION 
>    src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION 
>    src/selinux/selinux.h PRE-CREATION 
>    src/selinux/selinux.c PRE-CREATION 
>    src/selinux/test/README PRE-CREATION 
>    src/selinux/test/__init__.py PRE-CREATION 
>    src/selinux/test/test_selinux.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1986/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Synacek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/#review3271
-----------------------------------------------------------


First part of my review - I'll continue later.


mof/60_LMI_SELinux.mof
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1800>

    Bump the version to the next OpenLMI bundle release.
    
    Applies to all the classes.



mof/60_LMI_SELinux.mof
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1803>

    Please, add Implemented(True) qualifiers to implemented properties.



mof/60_LMI_SELinux.mof
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1801>

    s/\<an>/a/



mof/60_LMI_SELinux.mof
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1802>

    s/\<an>/a/



mof/60_LMI_SELinux.mof
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1804>

    s/\<An>/A/



mof/60_LMI_SELinux.mof
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1805>

    's/\<an>/a/'
    
    Ending commenting of this flaw.



mof/60_LMI_SELinux.mof
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1806>

    I don't see a way how a single reference to a unix file could refer to multiple
files. If it's really possible, it should be mentioned in doc string.



mof/60_LMI_SELinux.mof
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1807>

    's/Association class the connects/Associates/'



mof/60_LMI_SELinux.mof
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1808>

    I would override at least `Dependent` and make it refer to `LMI_SELinuxService`.



mof/60_LMI_SELinux.mof
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1809>

    `LMI_SELinuxInstCreation` and `LMI_SELinuxInstDeletion` are missing. They'll need
an analogue of `LMI_SELinuxInstModiciationProvider.c`.



mof/60_LMI_SELinux.reg
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1799>

    I believe this file should be generated during build.



src/libs/jobmanager/lmi_job.c
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1810>

    Please, make this function static. Thanks :)



src/libs/jobmanager/lmi_job.c
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1811>

    Good catch!



src/libs/libopenlmi/openlmi.c
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1812>

    `strip` suggests removing of something from the beginning or the end. Perhaps
`lmi_ditch_char` could be more appropriate.



src/selinux/LMI_AffectedSELinuxJobElementProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1813>

    IMHO `Target` of `RestoreLabels()`, `SetPortLabel()`, `SetFileLabel()`, `SetBoolean`
are affected elements of SELinuxJob.



src/selinux/LMI_SELinuxInstModificationProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1814>

    's/FALSE/TRUE/'



src/selinux/LMI_SELinuxJobProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1815>

    You've said it yourself :).
    
    I'll fix it in software provider. Thanks for noticing.



src/selinux/LMI_SELinuxJobProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1816>

    And once again.


- Michal Minar


On Srp. 29, 2014, 10:56 dop., Jan Synacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1986/
>  -----------------------------------------------------------
>  
>  (Updated Srp. 29, 2014, 10:56 dop.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  implement SELinux provider
>  
>  In case diffs don't work, I'll track changes in my WIP branch until the patch is
> merged:
>  
>  https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt 463da8c63a314dd34595710a127a0429f89edc49 
>    mof/60_LMI_SELinux.mof PRE-CREATION 
>    mof/60_LMI_SELinux.reg PRE-CREATION 
>    mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION 
>    mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69 
>    src/.dir-locals.el PRE-CREATION 
>    src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800 
>    src/libs/jobmanager/lmi_job.c 004e6a72c9f5c36acfa3f4062a5a036ab0843d39 
>    src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90 
>    src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a 
>    src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26 
>    src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323 
>    src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION 
>    src/selinux/CMakeLists.txt PRE-CREATION 
>    src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION 
>    src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION 
>    src/selinux/selinux.h PRE-CREATION 
>    src/selinux/selinux.c PRE-CREATION 
>    src/selinux/test/README PRE-CREATION 
>    src/selinux/test/__init__.py PRE-CREATION 
>    src/selinux/test/test_selinux.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1986/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Synacek
>  
>

[Stephen Gallagher]

>  On Sept. 1, 2014, 10:43 a.m., Michal Minar wrote:
>  > mof/60_LMI_SELinux.mof, line 30
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11583#file1158...
>  >
>  >     s/\<an>/a/ 
I believe it should really be "an", because SELinux is typically pronounced as
es-eeee-linux, not sell-inux.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/#review3271
-----------------------------------------------------------


On Aug. 29, 2014, 12:56 p.m., Jan Synacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1986/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 29, 2014, 12:56 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  implement SELinux provider
>  
>  In case diffs don't work, I'll track changes in my WIP branch until the patch is
> merged:
>  
>  https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt 463da8c63a314dd34595710a127a0429f89edc49 
>    mof/60_LMI_SELinux.mof PRE-CREATION 
>    mof/60_LMI_SELinux.reg PRE-CREATION 
>    mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION 
>    mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69 
>    src/.dir-locals.el PRE-CREATION 
>    src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800 
>    src/libs/jobmanager/lmi_job.c 004e6a72c9f5c36acfa3f4062a5a036ab0843d39 
>    src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90 
>    src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a 
>    src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26 
>    src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323 
>    src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION 
>    src/selinux/CMakeLists.txt PRE-CREATION 
>    src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION 
>    src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION 
>    src/selinux/selinux.h PRE-CREATION 
>    src/selinux/selinux.c PRE-CREATION 
>    src/selinux/test/README PRE-CREATION 
>    src/selinux/test/__init__.py PRE-CREATION 
>    src/selinux/test/test_selinux.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1986/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Synacek
>  
>

[Stephen Gallagher]

>  On Sept. 1, 2014, 10:43 a.m., Michal Minar wrote:
>  > src/selinux/LMI_SELinuxJobProvider.c, line 74
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11601#file1160...
>  >
>  >     You've said it yourself :).
>  >     
>  >     I'll fix it in software provider. Thanks for noticing. 
Aha! Remnants of the testing phase...


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/#review3271
-----------------------------------------------------------


On Aug. 29, 2014, 12:56 p.m., Jan Synacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1986/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 29, 2014, 12:56 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  implement SELinux provider
>  
>  In case diffs don't work, I'll track changes in my WIP branch until the patch is
> merged:
>  
>  https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt 463da8c63a314dd34595710a127a0429f89edc49 
>    mof/60_LMI_SELinux.mof PRE-CREATION 
>    mof/60_LMI_SELinux.reg PRE-CREATION 
>    mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION 
>    mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69 
>    src/.dir-locals.el PRE-CREATION 
>    src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800 
>    src/libs/jobmanager/lmi_job.c 004e6a72c9f5c36acfa3f4062a5a036ab0843d39 
>    src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90 
>    src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a 
>    src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26 
>    src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323 
>    src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION 
>    src/selinux/CMakeLists.txt PRE-CREATION 
>    src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION 
>    src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION 
>    src/selinux/selinux.h PRE-CREATION 
>    src/selinux/selinux.c PRE-CREATION 
>    src/selinux/test/README PRE-CREATION 
>    src/selinux/test/__init__.py PRE-CREATION 
>    src/selinux/test/test_selinux.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1986/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Synacek
>  
>

[Stephen Gallagher]

>  On Zář. 1, 2014, 8:43 dop., Michal Minar wrote:
>  > mof/60_LMI_SELinux.mof, line 30
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11583#file1158...
>  >
>  >     s/\<an>/a/
>  
>  Jan Synacek wrote:
>      I believe it should really be "an", because SELinux is typically pronounced
> as es-eeee-linux, not sell-inux. 
Aah, I see. My bad. Can't get rid of czech pronunciation :) ...


- Michal


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/#review3271
-----------------------------------------------------------


On Srp. 29, 2014, 10:56 dop., Jan Synacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1986/
>  -----------------------------------------------------------
>  
>  (Updated Srp. 29, 2014, 10:56 dop.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  implement SELinux provider
>  
>  In case diffs don't work, I'll track changes in my WIP branch until the patch is
> merged:
>  
>  https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt 463da8c63a314dd34595710a127a0429f89edc49 
>    mof/60_LMI_SELinux.mof PRE-CREATION 
>    mof/60_LMI_SELinux.reg PRE-CREATION 
>    mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION 
>    mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69 
>    src/.dir-locals.el PRE-CREATION 
>    src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800 
>    src/libs/jobmanager/lmi_job.c 004e6a72c9f5c36acfa3f4062a5a036ab0843d39 
>    src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90 
>    src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a 
>    src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26 
>    src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323 
>    src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION 
>    src/selinux/CMakeLists.txt PRE-CREATION 
>    src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION 
>    src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION 
>    src/selinux/selinux.h PRE-CREATION 
>    src/selinux/selinux.c PRE-CREATION 
>    src/selinux/test/README PRE-CREATION 
>    src/selinux/test/__init__.py PRE-CREATION 
>    src/selinux/test/test_selinux.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1986/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Synacek
>  
>

[Stephen Gallagher]

>  On Sept. 1, 2014, 10:43 a.m., Michal Minar wrote:
>  > mof/60_LMI_SELinux.mof, line 172
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11583#file1158...
>  >
>  >     I don't see a way how a single reference to a unix file could refer to
> multiple files. If it's really possible, it should be mentioned in doc string. 
This is an old and forgotten description. Will be fixed.


>  On Sept. 1, 2014, 10:43 a.m., Michal Minar wrote:
>  > mof/60_LMI_SELinux.mof, line 191
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11583#file1158...
>  >
>  >     's/Association class the connects/Associates/' 
I don't really understand this change. It seems like a matter of opinion to me.


>  On Sept. 1, 2014, 10:43 a.m., Michal Minar wrote:
>  > mof/60_LMI_SELinux.mof, line 204
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11583#file1158...
>  >
>  >     I would override at least `Dependent` and make it refer to `LMI_SELinuxService`.
Good idea.


>  On Sept. 1, 2014, 10:43 a.m., Michal Minar wrote:
>  > src/libs/jobmanager/lmi_job.c, line 1679
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11589#file1158...
>  >
>  >     Please, make this function static. Thanks :) 
Done.


>  On Sept. 1, 2014, 10:43 a.m., Michal Minar wrote:
>  > src/libs/libopenlmi/openlmi.c, line 787
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11591#file1159...
>  >
>  >     `strip` suggests removing of something from the beginning or the end. Perhaps
> `lmi_ditch_char` could be more appropriate. 
This function should actually do the strip. I rewrote it.


>  On Sept. 1, 2014, 10:43 a.m., Michal Minar wrote:
>  > src/libs/jobmanager/lmi_job.c, lines 1868-1874
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11589#file1158...
>  >
>  >     Good catch! 
I'll probably move this into a separate patch.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/#review3271
-----------------------------------------------------------


On Aug. 29, 2014, 12:56 p.m., Jan Synacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1986/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 29, 2014, 12:56 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  implement SELinux provider
>  
>  In case diffs don't work, I'll track changes in my WIP branch until the patch is
> merged:
>  
>  https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt 463da8c63a314dd34595710a127a0429f89edc49 
>    mof/60_LMI_SELinux.mof PRE-CREATION 
>    mof/60_LMI_SELinux.reg PRE-CREATION 
>    mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION 
>    mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69 
>    src/.dir-locals.el PRE-CREATION 
>    src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800 
>    src/libs/jobmanager/lmi_job.c 004e6a72c9f5c36acfa3f4062a5a036ab0843d39 
>    src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90 
>    src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a 
>    src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26 
>    src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323 
>    src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION 
>    src/selinux/CMakeLists.txt PRE-CREATION 
>    src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION 
>    src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION 
>    src/selinux/selinux.h PRE-CREATION 
>    src/selinux/selinux.c PRE-CREATION 
>    src/selinux/test/README PRE-CREATION 
>    src/selinux/test/__init__.py PRE-CREATION 
>    src/selinux/test/test_selinux.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1986/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Synacek
>  
>

[Stephen Gallagher]

>  On Zář. 1, 2014, 8:43 dop., Michal Minar wrote:
>  > mof/60_LMI_SELinux.mof, line 191
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11583#file1158...
>  >
>  >     's/Association class the connects/Associates/'
>  
>  Jan Synacek wrote:
>      I don't really understand this change. It seems like a matter of opinion to me.
The thing is that **the** should prepend a noun not a verb. Perhaps you meant *Association
class* **that** *connects ...*


- Michal


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/#review3271
-----------------------------------------------------------


On Zář. 5, 2014, 1:01 odp., Jan Synacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1986/
>  -----------------------------------------------------------
>  
>  (Updated Zář. 5, 2014, 1:01 odp.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  implement SELinux provider
>  
>  In case diffs don't work, I'll track changes in my WIP branch until the patch is
> merged:
>  
>  https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt 463da8c63a314dd34595710a127a0429f89edc49 
>    mof/60_LMI_SELinux.mof PRE-CREATION 
>    mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION 
>    mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69 
>    src/.dir-locals.el PRE-CREATION 
>    src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800 
>    src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90 
>    src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a 
>    src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26 
>    src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323 
>    src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION 
>    src/selinux/CMakeLists.txt PRE-CREATION 
>    src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION 
>    src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION 
>    src/selinux/selinux.h PRE-CREATION 
>    src/selinux/selinux.c PRE-CREATION 
>    src/selinux/test/README PRE-CREATION 
>    src/selinux/test/__init__.py PRE-CREATION 
>    src/selinux/test/test_selinux.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1986/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Synacek
>  
>

[Stephen Gallagher]

>  On Sept. 1, 2014, 10:43 a.m., Michal Minar wrote:
>  > mof/60_LMI_SELinux.mof, line 191
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11583#file1158...
>  >
>  >     's/Association class the connects/Associates/'
>  
>  Jan Synacek wrote:
>      I don't really understand this change. It seems like a matter of opinion to me.
>  
>  Michal Minar wrote:
>      The thing is that **the** should prepend a noun not a verb. Perhaps you meant
> *Association class* **that** *connects ...* 
Ok, I should read better next time. Thanks!


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/#review3271
-----------------------------------------------------------


On Sept. 5, 2014, 3:01 p.m., Jan Synacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1986/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 5, 2014, 3:01 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  implement SELinux provider
>  
>  In case diffs don't work, I'll track changes in my WIP branch until the patch is
> merged:
>  
>  https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt 463da8c63a314dd34595710a127a0429f89edc49 
>    mof/60_LMI_SELinux.mof PRE-CREATION 
>    mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION 
>    mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69 
>    src/.dir-locals.el PRE-CREATION 
>    src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800 
>    src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90 
>    src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a 
>    src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26 
>    src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323 
>    src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION 
>    src/selinux/CMakeLists.txt PRE-CREATION 
>    src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION 
>    src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION 
>    src/selinux/selinux.h PRE-CREATION 
>    src/selinux/selinux.c PRE-CREATION 
>    src/selinux/test/README PRE-CREATION 
>    src/selinux/test/__init__.py PRE-CREATION 
>    src/selinux/test/test_selinux.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1986/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Synacek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/#review3277
-----------------------------------------------------------


Second part of my review.

### Additional notes:

in LMI_SELinuxPortProvider.c / LMI_SELinuxPortEnumInstances()
 * `s/broken/broker/`
 * `s/to free to/to free/`
 * `ranges` (`GSList`) are not freed (just ports they refer to)

in LMI_SELinuxServiceProvider.c / parse_selinux_sysconf()
 * I'd avoid allocating `25*BUFLEN` bytes on a stack. Please use heap. Although
   it isn't totally safe, I'd also recommend to get the file size and use it as a
   buffer size (+1).

in LMI_SELinuxServiceProvider.c / LMI_SELinuxServiceEnumInstances()
 * s/security_genenforce/security_getenforce

in LMI_SELinuxServiceProvider.c / parse_port_instance_id()
 * don't forget to free `parts`

in LMI_SELinuxServiceProvider.c / parse_port_range()
 * mixing tabs with spaces

in LMI_SELinuxServiceProvider.c / SetPortLabel()
 * place the `lmi_job_set_method_name` before `jobmgr_run_job`


src/selinux/selinux.c
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1822>

    use `lmi_get_system_name_safe()`



src/selinux/selinux.c
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1823>

    use heap



src/selinux/selinux.c
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1825>

    What if `SELINUX=*` line is commented out?



src/selinux/selinux.c
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1824>

    's/set_setlinux_default_state/set_selinux_default_state/'



src/selinux/selinux.c
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1826>

    If believe
    
        if (!include_output)
            return st;
            
    is what you really want. But input arguments could be filled as well - they are
already defined in `__MethodParameters_*` classes.



src/selinux/test/test_selinux.py
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1827>

    's/\<o>/of/



src/selinux/test/test_selinux.py
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1828>

    isn't `/tmp` supposed to be a `TESTDIR`?



src/selinux/test/test_selinux.py
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1829>

    `s/are is/are/`



src/selinux/test/test_selinux.py
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1830>

    `s/security_genenforce/security_getenforce/`



src/selinux/test/test_selinux.py
<http://reviewboard-openlmi.rhcloud.com/r/1986/#comment1831>

    I'd also check that desired states were set.


- Michal Minar


On Srp. 29, 2014, 10:56 dop., Jan Synacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1986/
>  -----------------------------------------------------------
>  
>  (Updated Srp. 29, 2014, 10:56 dop.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  implement SELinux provider
>  
>  In case diffs don't work, I'll track changes in my WIP branch until the patch is
> merged:
>  
>  https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt 463da8c63a314dd34595710a127a0429f89edc49 
>    mof/60_LMI_SELinux.mof PRE-CREATION 
>    mof/60_LMI_SELinux.reg PRE-CREATION 
>    mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION 
>    mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69 
>    src/.dir-locals.el PRE-CREATION 
>    src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800 
>    src/libs/jobmanager/lmi_job.c 004e6a72c9f5c36acfa3f4062a5a036ab0843d39 
>    src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90 
>    src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a 
>    src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26 
>    src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323 
>    src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION 
>    src/selinux/CMakeLists.txt PRE-CREATION 
>    src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION 
>    src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION 
>    src/selinux/selinux.h PRE-CREATION 
>    src/selinux/selinux.c PRE-CREATION 
>    src/selinux/test/README PRE-CREATION 
>    src/selinux/test/__init__.py PRE-CREATION 
>    src/selinux/test/test_selinux.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1986/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Synacek
>  
>

[Stephen Gallagher]

>  On Sept. 1, 2014, 2:29 p.m., Michal Minar wrote:
>  > src/selinux/selinux.c, lines 83-92
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11608#file1160...
>  >
>  >     What if `SELINUX=*` line is commented out? 
Your answer lies on the line 84.


>  On Sept. 1, 2014, 2:29 p.m., Michal Minar wrote:
>  > src/selinux/selinux.c, line 109
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11608#file1160...
>  >
>  >     's/set_setlinux_default_state/set_selinux_default_state/' 
Good catch, thanks.


>  On Sept. 1, 2014, 2:29 p.m., Michal Minar wrote:
>  > src/selinux/selinux.c, lines 478-480
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11608#file1160...
>  >
>  >     If believe
>  >     
>  >         if (!include_output)
>  >             return st;
>  >             
>  >     is what you really want. But input arguments could be filled as well - they are
> already defined in `__MethodParameters_*` classes. 
My understanding was that either include_input, or include_output are set. Therefore, I
was only interested in the output parameters and didn't want the function to go any
further if the input parameters were set. It seems to work. Or am I misunderstanding
something?


>  On Sept. 1, 2014, 2:29 p.m., Michal Minar wrote:
>  > src/selinux/test/test_selinux.py, lines 189-192
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11611#file1161...
>  >
>  >     isn't `/tmp` supposed to be a `TESTDIR`? 
Yes, it is.


>  On Sept. 1, 2014, 2:29 p.m., Michal Minar wrote:
>  > src/selinux/test/test_selinux.py, lines 353-355
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11611#file1161...
>  >
>  >     I'd also check that desired states were set. 
Well, that's what line 355 does.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/#review3277
-----------------------------------------------------------


On Aug. 29, 2014, 12:56 p.m., Jan Synacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1986/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 29, 2014, 12:56 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  implement SELinux provider
>  
>  In case diffs don't work, I'll track changes in my WIP branch until the patch is
> merged:
>  
>  https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt 463da8c63a314dd34595710a127a0429f89edc49 
>    mof/60_LMI_SELinux.mof PRE-CREATION 
>    mof/60_LMI_SELinux.reg PRE-CREATION 
>    mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION 
>    mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69 
>    src/.dir-locals.el PRE-CREATION 
>    src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800 
>    src/libs/jobmanager/lmi_job.c 004e6a72c9f5c36acfa3f4062a5a036ab0843d39 
>    src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90 
>    src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a 
>    src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26 
>    src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323 
>    src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION 
>    src/selinux/CMakeLists.txt PRE-CREATION 
>    src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION 
>    src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION 
>    src/selinux/selinux.h PRE-CREATION 
>    src/selinux/selinux.c PRE-CREATION 
>    src/selinux/test/README PRE-CREATION 
>    src/selinux/test/__init__.py PRE-CREATION 
>    src/selinux/test/test_selinux.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1986/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Synacek
>  
>

[Stephen Gallagher]

>  On Zář. 1, 2014, 12:29 odp., Michal Minar wrote:
>  > src/selinux/selinux.c, lines 83-92
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11608#file1160...
>  >
>  >     What if `SELINUX=*` line is commented out?
>  
>  Jan Synacek wrote:
>      Your answer lies on the line 84. 
Ok, but in this case the new state won't be set or am I missing something?


>  On Zář. 1, 2014, 12:29 odp., Michal Minar wrote:
>  > src/selinux/selinux.c, lines 478-480
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11608#file1160...
>  >
>  >     If believe
>  >     
>  >         if (!include_output)
>  >             return st;
>  >             
>  >     is what you really want. But input arguments could be filled as well - they are
> already defined in `__MethodParameters_*` classes.
>  
>  Jan Synacek wrote:
>      My understanding was that either include_input, or include_output are set. Therefore,
> I was only interested in the output parameters and didn't want the function to go any
> further if the input parameters were set. It seems to work. Or am I misunderstanding
> something? 
I remeber telling you this. But things have changed since then. Now when job is
successfully finished, job's associated method result will contain
__MethodParameters_<methodname>_Result with both input and output parameters
filled.

Sorry for confusion.


>  On Zář. 1, 2014, 12:29 odp., Michal Minar wrote:
>  > src/selinux/test/test_selinux.py, lines 353-355
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11611#file1161...
>  >
>  >     I'd also check that desired states were set.
>  
>  Jan Synacek wrote:
>      Well, that's what line 355 does. 
I don't think so. IMHO `_verify_selinux_states()` just checks whether the provider is
in sync with library - their states matches. That's right to test for sure. What I
have on mind though is something like ``self.assertEqual(desired_new_state,
inst.SELinuxState)``.


- Michal


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/#review3277
-----------------------------------------------------------


On Zář. 5, 2014, 1:01 odp., Jan Synacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1986/
>  -----------------------------------------------------------
>  
>  (Updated Zář. 5, 2014, 1:01 odp.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  implement SELinux provider
>  
>  In case diffs don't work, I'll track changes in my WIP branch until the patch is
> merged:
>  
>  https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt 463da8c63a314dd34595710a127a0429f89edc49 
>    mof/60_LMI_SELinux.mof PRE-CREATION 
>    mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION 
>    mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69 
>    src/.dir-locals.el PRE-CREATION 
>    src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800 
>    src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90 
>    src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a 
>    src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26 
>    src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323 
>    src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION 
>    src/selinux/CMakeLists.txt PRE-CREATION 
>    src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION 
>    src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION 
>    src/selinux/selinux.h PRE-CREATION 
>    src/selinux/selinux.c PRE-CREATION 
>    src/selinux/test/README PRE-CREATION 
>    src/selinux/test/__init__.py PRE-CREATION 
>    src/selinux/test/test_selinux.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1986/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Synacek
>  
>

[Stephen Gallagher]

>  On Sept. 1, 2014, 2:29 p.m., Michal Minar wrote:
>  > src/selinux/selinux.c, lines 83-92
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11608#file1160...
>  >
>  >     What if `SELINUX=*` line is commented out?
>  
>  Jan Synacek wrote:
>      Your answer lies on the line 84.
>  
>  Michal Minar wrote:
>      Ok, but in this case the new state won't be set or am I missing something?
Yes, it should be set only if it's active (not commented).


>  On Sept. 1, 2014, 2:29 p.m., Michal Minar wrote:
>  > src/selinux/selinux.c, lines 478-480
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11608#file1160...
>  >
>  >     If believe
>  >     
>  >         if (!include_output)
>  >             return st;
>  >             
>  >     is what you really want. But input arguments could be filled as well - they are
> already defined in `__MethodParameters_*` classes.
>  
>  Jan Synacek wrote:
>      My understanding was that either include_input, or include_output are set. Therefore,
> I was only interested in the output parameters and didn't want the function to go any
> further if the input parameters were set. It seems to work. Or am I misunderstanding
> something?
>  
>  Michal Minar wrote:
>      I remeber telling you this. But things have changed since then. Now when job is
> successfully finished, job's associated method result will contain
> __MethodParameters_<methodname>_Result with both input and output parameters
> filled.
>      
>      Sorry for confusion. 
I'll look into this some more.


>  On Sept. 1, 2014, 2:29 p.m., Michal Minar wrote:
>  > src/selinux/test/test_selinux.py, lines 353-355
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11611#file1161...
>  >
>  >     I'd also check that desired states were set.
>  
>  Jan Synacek wrote:
>      Well, that's what line 355 does.
>  
>  Michal Minar wrote:
>      I don't think so. IMHO `_verify_selinux_states()` just checks whether the
> provider is in sync with library - their states matches. That's right to test for
> sure. What I have on mind though is something like ``self.assertEqual(desired_new_state,
> inst.SELinuxState)``. 
Ok, I'll fix that.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/#review3277
-----------------------------------------------------------


On Sept. 5, 2014, 3:01 p.m., Jan Synacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1986/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 5, 2014, 3:01 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  implement SELinux provider
>  
>  In case diffs don't work, I'll track changes in my WIP branch until the patch is
> merged:
>  
>  https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt 463da8c63a314dd34595710a127a0429f89edc49 
>    mof/60_LMI_SELinux.mof PRE-CREATION 
>    mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION 
>    mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69 
>    src/.dir-locals.el PRE-CREATION 
>    src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800 
>    src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90 
>    src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a 
>    src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26 
>    src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323 
>    src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION 
>    src/selinux/CMakeLists.txt PRE-CREATION 
>    src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION 
>    src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION 
>    src/selinux/selinux.h PRE-CREATION 
>    src/selinux/selinux.c PRE-CREATION 
>    src/selinux/test/README PRE-CREATION 
>    src/selinux/test/__init__.py PRE-CREATION 
>    src/selinux/test/test_selinux.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1986/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Synacek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/
-----------------------------------------------------------

(Updated Sept. 5, 2014, 3:01 p.m.)


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

implement SELinux provider

In case diffs don't work, I'll track changes in my WIP branch until the patch is
merged:

https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel


Diffs (updated)
-----

  CMakeLists.txt 463da8c63a314dd34595710a127a0429f89edc49 
  mof/60_LMI_SELinux.mof PRE-CREATION 
  mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION 
  mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69 
  src/.dir-locals.el PRE-CREATION 
  src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800 
  src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90 
  src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a 
  src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26 
  src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323 
  src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION 
  src/selinux/CMakeLists.txt PRE-CREATION 
  src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION 
  src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION 
  src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION 
  src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION 
  src/selinux/selinux.h PRE-CREATION 
  src/selinux/selinux.c PRE-CREATION 
  src/selinux/test/README PRE-CREATION 
  src/selinux/test/__init__.py PRE-CREATION 
  src/selinux/test/test_selinux.py PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1986/diff/


Testing
-------


Thanks,

Jan Synacek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/#review3331
-----------------------------------------------------------


Please, ignore the src/libs/jobmanager/lmi_job.c bits, they shouldn't be there, as I
posted them as a separate review #2012.

- Jan Synacek


On Sept. 5, 2014, 3:01 p.m., Jan Synacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1986/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 5, 2014, 3:01 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  implement SELinux provider
>  
>  In case diffs don't work, I'll track changes in my WIP branch until the patch is
> merged:
>  
>  https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt 463da8c63a314dd34595710a127a0429f89edc49 
>    mof/60_LMI_SELinux.mof PRE-CREATION 
>    mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION 
>    mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69 
>    src/.dir-locals.el PRE-CREATION 
>    src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800 
>    src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90 
>    src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a 
>    src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26 
>    src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323 
>    src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION 
>    src/selinux/CMakeLists.txt PRE-CREATION 
>    src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION 
>    src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION 
>    src/selinux/selinux.h PRE-CREATION 
>    src/selinux/selinux.c PRE-CREATION 
>    src/selinux/test/README PRE-CREATION 
>    src/selinux/test/__init__.py PRE-CREATION 
>    src/selinux/test/test_selinux.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1986/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Synacek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/#review3334
-----------------------------------------------------------


Additional note:

in LMI_SELinuxServiceProvider.c / parse_port_instance_id()
 * `g_free(parts)`

- Michal Minar


On Zář. 5, 2014, 1:01 odp., Jan Synacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1986/
>  -----------------------------------------------------------
>  
>  (Updated Zář. 5, 2014, 1:01 odp.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  implement SELinux provider
>  
>  In case diffs don't work, I'll track changes in my WIP branch until the patch is
> merged:
>  
>  https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt 463da8c63a314dd34595710a127a0429f89edc49 
>    mof/60_LMI_SELinux.mof PRE-CREATION 
>    mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION 
>    mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69 
>    src/.dir-locals.el PRE-CREATION 
>    src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800 
>    src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90 
>    src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a 
>    src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26 
>    src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323 
>    src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION 
>    src/selinux/CMakeLists.txt PRE-CREATION 
>    src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION 
>    src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION 
>    src/selinux/selinux.h PRE-CREATION 
>    src/selinux/selinux.c PRE-CREATION 
>    src/selinux/test/README PRE-CREATION 
>    src/selinux/test/__init__.py PRE-CREATION 
>    src/selinux/test/test_selinux.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1986/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Synacek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/
-----------------------------------------------------------

(Updated Sept. 8, 2014, 12:47 p.m.)


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

implement SELinux provider

In case diffs don't work, I'll track changes in my WIP branch until the patch is
merged:

https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel


Diffs (updated)
-----

  CMakeLists.txt 463da8c63a314dd34595710a127a0429f89edc49 
  mof/60_LMI_SELinux.mof PRE-CREATION 
  mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION 
  mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69 
  src/.dir-locals.el PRE-CREATION 
  src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800 
  src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90 
  src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a 
  src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26 
  src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323 
  src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION 
  src/selinux/CMakeLists.txt PRE-CREATION 
  src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION 
  src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION 
  src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION 
  src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION 
  src/selinux/selinux.h PRE-CREATION 
  src/selinux/selinux.c PRE-CREATION 
  src/selinux/test/README PRE-CREATION 
  src/selinux/test/__init__.py PRE-CREATION 
  src/selinux/test/test_selinux.py PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1986/diff/


Testing
-------


Thanks,

Jan Synacek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/
-----------------------------------------------------------

(Updated Sept. 9, 2014, 8:33 a.m.)


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

implement SELinux provider

In case diffs don't work, I'll track changes in my WIP branch until the patch is
merged:

https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel


Diffs (updated)
-----

  CMakeLists.txt aba542fa6f2ac9b258a335d80945a70b92d7033e 
  mof/60_LMI_SELinux.mof PRE-CREATION 
  mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION 
  mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69 
  src/.dir-locals.el PRE-CREATION 
  src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800 
  src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90 
  src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a 
  src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26 
  src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323 
  src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION 
  src/selinux/CMakeLists.txt PRE-CREATION 
  src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION 
  src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION 
  src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION 
  src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION 
  src/selinux/selinux.h PRE-CREATION 
  src/selinux/selinux.c PRE-CREATION 
  src/selinux/test/README PRE-CREATION 
  src/selinux/test/__init__.py PRE-CREATION 
  src/selinux/test/test_selinux.py PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1986/diff/


Testing
-------


Thanks,

Jan Synacek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/#review3343
-----------------------------------------------------------

Ship it!


Ship It!

- Michal Minar


On Zář. 9, 2014, 6:33 dop., Jan Synacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1986/
>  -----------------------------------------------------------
>  
>  (Updated Zář. 9, 2014, 6:33 dop.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  implement SELinux provider
>  
>  In case diffs don't work, I'll track changes in my WIP branch until the patch is
> merged:
>  
>  https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt aba542fa6f2ac9b258a335d80945a70b92d7033e 
>    mof/60_LMI_SELinux.mof PRE-CREATION 
>    mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION 
>    mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69 
>    src/.dir-locals.el PRE-CREATION 
>    src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800 
>    src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90 
>    src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a 
>    src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26 
>    src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323 
>    src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION 
>    src/selinux/CMakeLists.txt PRE-CREATION 
>    src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION 
>    src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION 
>    src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION 
>    src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION 
>    src/selinux/selinux.h PRE-CREATION 
>    src/selinux/selinux.c PRE-CREATION 
>    src/selinux/test/README PRE-CREATION 
>    src/selinux/test/__init__.py PRE-CREATION 
>    src/selinux/test/test_selinux.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1986/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Synacek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/
-----------------------------------------------------------

(Updated Sept. 9, 2014, 10:26 a.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

implement SELinux provider

In case diffs don't work, I'll track changes in my WIP branch until the patch is
merged:

https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel


Diffs
-----

  CMakeLists.txt aba542fa6f2ac9b258a335d80945a70b92d7033e 
  mof/60_LMI_SELinux.mof PRE-CREATION 
  mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION 
  mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69 
  src/.dir-locals.el PRE-CREATION 
  src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800 
  src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90 
  src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a 
  src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26 
  src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323 
  src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION 
  src/selinux/CMakeLists.txt PRE-CREATION 
  src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION 
  src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION 
  src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION 
  src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION 
  src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION 
  src/selinux/selinux.h PRE-CREATION 
  src/selinux/selinux.c PRE-CREATION 
  src/selinux/test/README PRE-CREATION 
  src/selinux/test/__init__.py PRE-CREATION 
  src/selinux/test/test_selinux.py PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1986/diff/


Testing
-------


Thanks,

Jan Synacek