On Zář. 1, 2014, 12:29 odp., Michal Minar wrote:
> src/selinux/selinux.c, lines 83-92
>
<
http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11608#file1160...
>
> What if `SELINUX=*` line is commented out?
Jan Synacek wrote:
Your answer lies on the line 84.
Ok, but in this case the new state won't be set or am I missing something?
On Zář. 1, 2014, 12:29 odp., Michal Minar wrote:
> src/selinux/selinux.c, lines 478-480
>
<
http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11608#file1160...
>
> If believe
>
> if (!include_output)
> return st;
>
> is what you really want. But input arguments could be filled as well - they are
already defined in `__MethodParameters_*` classes.
Jan Synacek wrote:
My understanding was that either include_input, or include_output are set. Therefore,
I was only interested in the output parameters and didn't want the function to go any
further if the input parameters were set. It seems to work. Or am I misunderstanding
something?
I remeber telling you this. But things have changed since then. Now when job is
successfully finished, job's associated method result will contain
__MethodParameters_<methodname>_Result with both input and output parameters
filled.
Sorry for confusion.
On Zář. 1, 2014, 12:29 odp., Michal Minar wrote:
> src/selinux/test/test_selinux.py, lines 353-355
>
<
http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11611#file1161...
>
> I'd also check that desired states were set.
Jan Synacek wrote:
Well, that's what line 355 does.
I don't think so. IMHO `_verify_selinux_states()` just checks whether the provider is
in sync with library - their states matches. That's right to test for sure. What I
have on mind though is something like ``self.assertEqual(desired_new_state,
inst.SELinuxState)``.
- Michal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/#review3277
-----------------------------------------------------------
On Zář. 5, 2014, 1:01 odp., Jan Synacek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/
-----------------------------------------------------------
(Updated Zář. 5, 2014, 1:01 odp.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
implement SELinux provider
In case diffs don't work, I'll track changes in my WIP branch until the patch is
merged:
https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel
Diffs
-----
CMakeLists.txt 463da8c63a314dd34595710a127a0429f89edc49
mof/60_LMI_SELinux.mof PRE-CREATION
mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION
mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69
src/.dir-locals.el PRE-CREATION
src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800
src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90
src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a
src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26
src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323
src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION
src/selinux/CMakeLists.txt PRE-CREATION
src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION
src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION
src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION
src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION
src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION
src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION
src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION
src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION
src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION
src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION
src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION
src/selinux/selinux.h PRE-CREATION
src/selinux/selinux.c PRE-CREATION
src/selinux/test/README PRE-CREATION
src/selinux/test/__init__.py PRE-CREATION
src/selinux/test/test_selinux.py PRE-CREATION
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1986/diff/
Testing
-------
Thanks,
Jan Synacek