On Sept. 1, 2014, 10:43 a.m., Michal Minar wrote:
> mof/60_LMI_SELinux.mof, line 172
>
<
http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11583#file1158...
>
> I don't see a way how a single reference to a unix file could refer to
multiple files. If it's really possible, it should be mentioned in doc string.
This is an old and forgotten description. Will be fixed.
On Sept. 1, 2014, 10:43 a.m., Michal Minar wrote:
> mof/60_LMI_SELinux.mof, line 191
>
<
http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11583#file1158...
>
> 's/Association class the connects/Associates/'
I don't really understand this change. It seems like a matter of opinion to me.
On Sept. 1, 2014, 10:43 a.m., Michal Minar wrote:
> mof/60_LMI_SELinux.mof, line 204
>
<
http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11583#file1158...
>
> I would override at least `Dependent` and make it refer to `LMI_SELinuxService`.
Good idea.
On Sept. 1, 2014, 10:43 a.m., Michal Minar wrote:
> src/libs/jobmanager/lmi_job.c, line 1679
>
<
http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11589#file1158...
>
> Please, make this function static. Thanks :)
Done.
On Sept. 1, 2014, 10:43 a.m., Michal Minar wrote:
> src/libs/libopenlmi/openlmi.c, line 787
>
<
http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11591#file1159...
>
> `strip` suggests removing of something from the beginning or the end. Perhaps
`lmi_ditch_char` could be more appropriate.
This function should actually do the strip. I rewrote it.
On Sept. 1, 2014, 10:43 a.m., Michal Minar wrote:
> src/libs/jobmanager/lmi_job.c, lines 1868-1874
>
<
http://reviewboard-openlmi.rhcloud.com/r/1986/diff/1/?file=11589#file1158...
>
> Good catch!
I'll probably move this into a separate patch.
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/#review3271
-----------------------------------------------------------
On Aug. 29, 2014, 12:56 p.m., Jan Synacek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1986/
-----------------------------------------------------------
(Updated Aug. 29, 2014, 12:56 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
implement SELinux provider
In case diffs don't work, I'll track changes in my WIP branch until the patch is
merged:
https://git.fedorahosted.org/cgit/openlmi-providers.git/log/?h=selinux-devel
Diffs
-----
CMakeLists.txt 463da8c63a314dd34595710a127a0429f89edc49
mof/60_LMI_SELinux.mof PRE-CREATION
mof/60_LMI_SELinux.reg PRE-CREATION
mof/60_LMI_SELinux_MethodParameters.mof PRE-CREATION
mof/CMakeLists.txt 5e7aaa7f08d7f57277a0215970ba49064d6e0e69
src/.dir-locals.el PRE-CREATION
src/CMakeLists.txt 58d72f596a1675e16ff06f437333859b54c00800
src/libs/jobmanager/lmi_job.c 004e6a72c9f5c36acfa3f4062a5a036ab0843d39
src/libs/libopenlmi/openlmi.h 8f4770cde0d826fa95dabaa5a700934030f7bc90
src/libs/libopenlmi/openlmi.c da660a5bdb5c9fc37aa17031700bf3d93596d43a
src/logicalfile/CMakeLists.txt 0448f1e8c04dba47b767edd4b84f049fe5e0cf26
src/logicalfile/file.h 4caf84dd4db8dafc705fdd99738ff0e886db6323
src/selinux/90_LMI_SELinux_Profile.mof.skel PRE-CREATION
src/selinux/CMakeLists.txt PRE-CREATION
src/selinux/LMI_AffectedSELinuxJobElementProvider.c PRE-CREATION
src/selinux/LMI_AssociatedSELinuxJobMethodResultProvider.c PRE-CREATION
src/selinux/LMI_HostedSELinuxServiceProvider.c PRE-CREATION
src/selinux/LMI_SELinuxBooleanProvider.c PRE-CREATION
src/selinux/LMI_SELinuxInstModificationProvider.c PRE-CREATION
src/selinux/LMI_SELinuxJobProvider.c PRE-CREATION
src/selinux/LMI_SELinuxMethodResultProvider.c PRE-CREATION
src/selinux/LMI_SELinuxPortProvider.c PRE-CREATION
src/selinux/LMI_SELinuxServiceHasElementProvider.c PRE-CREATION
src/selinux/LMI_SELinuxServiceProvider.c PRE-CREATION
src/selinux/cmpiLMI_SELinux-cimprovagt PRE-CREATION
src/selinux/selinux.h PRE-CREATION
src/selinux/selinux.c PRE-CREATION
src/selinux/test/README PRE-CREATION
src/selinux/test/__init__.py PRE-CREATION
src/selinux/test/test_selinux.py PRE-CREATION
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1986/diff/
Testing
-------
Thanks,
Jan Synacek