-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1893/#review3058
-----------------------------------------------------------
doc/polkit/polkit-authorization.md
<
http://reviewboard-openlmi.rhcloud.com/r/1893/#comment1702>
s/any mean/any means/
s/its password/his\/her password/
s/an window/a window/
s/action is sent/action be sent/
doc/polkit/polkit-authorization.md
<
http://reviewboard-openlmi.rhcloud.com/r/1893/#comment1703>
Does this mean that every provider will be basically forking at least twice whenever
run?
doc/polkit/polkit-authorization.md
<
http://reviewboard-openlmi.rhcloud.com/r/1893/#comment1704>
I would quote $INPUT_FD and $OUTPUT_FD to prevent surprises.
doc/polkit/polkit-authorization.md
<
http://reviewboard-openlmi.rhcloud.com/r/1893/#comment1705>
s/is needed/are needed/
doc/polkit/polkit-authorization.md
<
http://reviewboard-openlmi.rhcloud.com/r/1893/#comment1706>
s/tools/tool/
doc/polkit/polkit-authorization.md
<
http://reviewboard-openlmi.rhcloud.com/r/1893/#comment1707>
Hmm, we're wrapping wrappers here. If I understand this right, there's not
much that can be done here because of the SELinux labels. Otherwise the agent could be
improved so that it handled everything that the original wrapper handles. Correct?
doc/polkit/polkit-authorization.md
<
http://reviewboard-openlmi.rhcloud.com/r/1893/#comment1708>
s/confirm polkit/give confirmation to polkit/
(Maybe even "confirm with polkit", but I'm not sure about that.)
- Jan Synacek
On July 11, 2014, 12:31 p.m., Jan Safranek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1893/
-----------------------------------------------------------
(Updated July 11, 2014, 12:31 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Add documentation of polkit usage.
Diffs
-----
doc/polkit/polkit-authorization.md PRE-CREATION
doc/polkit/polkit-init.uml PRE-CREATION
doc/polkit/polkit-run.uml PRE-CREATION
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1893/diff/
Testing
-------
Thanks,
Jan Safranek