Review Request 1893: openlmi-providers: polkit v2 [1/3] Add documentation of polkit usage.

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1893/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Add documentation of polkit usage.


Diffs
-----

  doc/polkit/polkit-authorization.md PRE-CREATION 
  doc/polkit/polkit-init.uml PRE-CREATION 
  doc/polkit/polkit-run.uml PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1893/diff/


Testing
-------


Thanks,

Jan Safranek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1893/#review3036
-----------------------------------------------------------


Autoscan failed:
~/system-management/scanbot/openlmi-providers ~/system-management/scanbot
Already up-to-date.
openlmi-providers-0.4.1_384_g1ea514b.tar.gz
--2014-07-11 12:40:36--  https://reviewboard-openlmi.rhcloud.com/r/1893/diff/raw/
Resolving reviewboard-openlmi.rhcloud.com (reviewboard-openlmi.rhcloud.com)...
23.22.105.178
Connecting to reviewboard-openlmi.rhcloud.com
(reviewboard-openlmi.rhcloud.com)|23.22.105.178|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 19096 (19K) [text/x-patch]
Saving to: '/tmp/tmp.cjJLifWyBy/1893.patch'

     0K .......... ........                                   100%  135K=0.1s

2014-07-11 12:40:37 (135 KB/s) - '/tmp/tmp.cjJLifWyBy/1893.patch' saved
[19096/19096]

--2014-07-11 12:40:37--  https://reviewboard-openlmi.rhcloud.com/r/1891/diff/raw/
Resolving reviewboard-openlmi.rhcloud.com (reviewboard-openlmi.rhcloud.com)...
23.22.105.178
Connecting to reviewboard-openlmi.rhcloud.com
(reviewboard-openlmi.rhcloud.com)|23.22.105.178|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 22709 (22K) [text/x-patch]
Saving to: '/tmp/tmp.cjJLifWyBy/1891.patch'

     0K .......... .......... ..                              100% 80.6K=0.3s

2014-07-11 12:40:38 (80.6 KB/s) - '/tmp/tmp.cjJLifWyBy/1891.patch' saved
[22709/22709]

--2014-07-11 12:40:38--  https://reviewboard-openlmi.rhcloud.com/r/1892/diff/raw/
Resolving reviewboard-openlmi.rhcloud.com (reviewboard-openlmi.rhcloud.com)...
23.22.105.178
Connecting to reviewboard-openlmi.rhcloud.com
(reviewboard-openlmi.rhcloud.com)|23.22.105.178|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 2027 (2.0K) [text/x-patch]
Saving to: '/tmp/tmp.cjJLifWyBy/1892.patch'

     0K .                                                     100% 31.0M=0s

2014-07-11 12:40:39 (31.0 MB/s) - '/tmp/tmp.cjJLifWyBy/1892.patch' saved
[2027/2027]

error: line 429: Unclosed %if
SRPM: 
Usage: covscan diff-build [options] <args>

covscan: error: please specify exactly one SRPM

- scanbot


On July 11, 2014, 10:31 a.m., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1893/
>  -----------------------------------------------------------
>  
>  (Updated July 11, 2014, 10:31 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Add documentation of polkit usage.
>  
>  
>  Diffs
>  -----
>  
>    doc/polkit/polkit-authorization.md PRE-CREATION 
>    doc/polkit/polkit-init.uml PRE-CREATION 
>    doc/polkit/polkit-run.uml PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1893/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1893/#review3044
-----------------------------------------------------------


Autoscan started for review(s) 1893[1], 1891[1], 1892[1]

- scanbot


On July 11, 2014, 10:31 a.m., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1893/
>  -----------------------------------------------------------
>  
>  (Updated July 11, 2014, 10:31 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Add documentation of polkit usage.
>  
>  
>  Diffs
>  -----
>  
>    doc/polkit/polkit-authorization.md PRE-CREATION 
>    doc/polkit/polkit-init.uml PRE-CREATION 
>    doc/polkit/polkit-run.uml PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1893/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1893/#review3046
-----------------------------------------------------------


Autoscan started for review(s) 1893[1], 1891[1], 1892[1]

- scanbot


On July 11, 2014, 10:31 a.m., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1893/
>  -----------------------------------------------------------
>  
>  (Updated July 11, 2014, 10:31 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Add documentation of polkit usage.
>  
>  
>  Diffs
>  -----
>  
>    doc/polkit/polkit-authorization.md PRE-CREATION 
>    doc/polkit/polkit-init.uml PRE-CREATION 
>    doc/polkit/polkit-run.uml PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1893/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1893/#review3054
-----------------------------------------------------------


Autoscan failed: FAILED
This can indicate any failure like broken buildroot to patch failed to apply. Manual
investigation of scan log is needed.
Scanned reviews: 1891,1892,1893

- scanbot


On July 11, 2014, 10:31 a.m., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1893/
>  -----------------------------------------------------------
>  
>  (Updated July 11, 2014, 10:31 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Add documentation of polkit usage.
>  
>  
>  Diffs
>  -----
>  
>    doc/polkit/polkit-authorization.md PRE-CREATION 
>    doc/polkit/polkit-init.uml PRE-CREATION 
>    doc/polkit/polkit-run.uml PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1893/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1893/#review3058
-----------------------------------------------------------



doc/polkit/polkit-authorization.md
<http://reviewboard-openlmi.rhcloud.com/r/1893/#comment1702>

    s/any mean/any means/
    
    s/its password/his\/her password/
    
    s/an window/a window/
    
    s/action is sent/action be sent/



doc/polkit/polkit-authorization.md
<http://reviewboard-openlmi.rhcloud.com/r/1893/#comment1703>

    Does this mean that every provider will be basically forking at least twice whenever
run?



doc/polkit/polkit-authorization.md
<http://reviewboard-openlmi.rhcloud.com/r/1893/#comment1704>

    I would quote $INPUT_FD and $OUTPUT_FD to prevent surprises.



doc/polkit/polkit-authorization.md
<http://reviewboard-openlmi.rhcloud.com/r/1893/#comment1705>

    s/is needed/are needed/



doc/polkit/polkit-authorization.md
<http://reviewboard-openlmi.rhcloud.com/r/1893/#comment1706>

    s/tools/tool/



doc/polkit/polkit-authorization.md
<http://reviewboard-openlmi.rhcloud.com/r/1893/#comment1707>

    Hmm, we're wrapping wrappers here. If I understand this right, there's not
much that can be done here because of the SELinux labels. Otherwise the agent could be
improved so that it handled everything that the original wrapper handles. Correct?



doc/polkit/polkit-authorization.md
<http://reviewboard-openlmi.rhcloud.com/r/1893/#comment1708>

    s/confirm polkit/give confirmation to polkit/
    
    (Maybe even "confirm with polkit", but I'm not sure about that.)


- Jan Synacek


On July 11, 2014, 12:31 p.m., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1893/
>  -----------------------------------------------------------
>  
>  (Updated July 11, 2014, 12:31 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Add documentation of polkit usage.
>  
>  
>  Diffs
>  -----
>  
>    doc/polkit/polkit-authorization.md PRE-CREATION 
>    doc/polkit/polkit-init.uml PRE-CREATION 
>    doc/polkit/polkit-run.uml PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1893/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

>  On Čec. 14, 2014, 9:43 dop., Jan Synacek wrote:
>  > doc/polkit/polkit-authorization.md, line 25
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1893/diff/1/?file=11091#file1109...
>  >
>  >     Does this mean that every provider will be basically forking at least twice
> whenever run? 
Yes, we fork a lot. Also note that every command in our <providername>-cimprovagt
script involves a fork() and exec(). However, once started, the provider process runs for
longer time and handles all requests from an user. It exits only after 5 (or 10?) minutes
of inactivity. It's *not* started for each new request.


>  On Čec. 14, 2014, 9:43 dop., Jan Synacek wrote:
>  > doc/polkit/polkit-authorization.md, lines 122-123
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1893/diff/1/?file=11091#file1109...
>  >
>  >     Hmm, we're wrapping wrappers here. If I understand this right, there's
> not much that can be done here because of the SELinux labels. Otherwise the agent could be
> improved so that it handled everything that the original wrapper handles. Correct? 
Interesting idea... We would need to ship copies of the agent with different names
(cmpiLMI_Networking-cimprovagt, cmpiLMI_Service-cimprovagt, ...), it's easier to copy
just a scripts here instead of a binary.
Still, the script logic could be hidden in the lmipolkitagent binary and the script could
be simple 'lmipolkitagent $@'.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1893/#review3058
-----------------------------------------------------------


On Čec. 11, 2014, 12:31 odp., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1893/
>  -----------------------------------------------------------
>  
>  (Updated Čec. 11, 2014, 12:31 odp.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Add documentation of polkit usage.
>  
>  
>  Diffs
>  -----
>  
>    doc/polkit/polkit-authorization.md PRE-CREATION 
>    doc/polkit/polkit-init.uml PRE-CREATION 
>    doc/polkit/polkit-run.uml PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1893/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1893/
-----------------------------------------------------------

(Updated Čec. 14, 2014, 1:47 odp.)


Review request for OpenLMI Developers.


Changes
-------

- added logic from a shell script cmpi<provider name>-cimprovagt to lmipolkitagent.
- formatting changes for pandoc
- incorporated review remarks

See https://fedorahosted.org/openlmi/wiki/PolkitAuthorization for regenerated docs.


Repository: openlmi-providers


Description
-------

Add documentation of polkit usage.


Diffs (updated)
-----

  doc/polkit/polkit-authorization.md PRE-CREATION 
  doc/polkit/polkit-init.uml PRE-CREATION 
  doc/polkit/polkit-run.uml PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1893/diff/


Testing
-------


Thanks,

Jan Safranek

Review Request 1893: openlmi-providers: polkit v2 [2/3] Add the polkit stuff to .spec file

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1893/
-----------------------------------------------------------

(Updated Čec. 14, 2014, 1:51 odp.)


Review request for OpenLMI Developers.


Changes
-------

-rebased to current HEAD


Summary (updated)
-----------------

openlmi-providers: polkit v2 [2/3] Add the polkit stuff to .spec file


Repository: openlmi-providers


Description (updated)
-------

Add the polkit stuff to .spec file


Diffs (updated)
-----

  openlmi-providers.spec 2872cc5d7a819e6efd3929b6169b769057ad45ea 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1893/diff/


Testing
-------


Thanks,

Jan Safranek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1893/
-----------------------------------------------------------

(Updated Čec. 14, 2014, 2:17 odp.)


Review request for OpenLMI Developers.


Changes
-------

- added logic from a shell script cmpi<provider name>-cimprovagt to lmipolkitagent.
- formatting changes for pandoc
- incorporated review remarks

See https://fedorahosted.org/openlmi/wiki/PolkitAuthorization for regenerated docs.


Summary (updated)
-----------------

openlmi-providers: polkit v2 [1/3] Add documentation of polkit usage.


Repository: openlmi-providers


Description (updated)
-------

Add documentation of polkit usage.


Diffs (updated)
-----

  doc/polkit/polkit-authorization.md PRE-CREATION 
  doc/polkit/polkit-init.uml PRE-CREATION 
  doc/polkit/polkit-run.uml PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1893/diff/


Testing
-------


Thanks,

Jan Safranek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1893/#review3087
-----------------------------------------------------------


Did you leave out *all* the changes in the spec file on purpose?

Also, any idea how to see what actually changed as diff, instead of just the whole
documents?

- Jan Synacek


On July 14, 2014, 2:17 p.m., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1893/
>  -----------------------------------------------------------
>  
>  (Updated July 14, 2014, 2:17 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Add documentation of polkit usage.
>  
>  
>  Diffs
>  -----
>  
>    doc/polkit/polkit-authorization.md PRE-CREATION 
>    doc/polkit/polkit-init.uml PRE-CREATION 
>    doc/polkit/polkit-run.uml PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1893/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

>  On Čec. 15, 2014, 9:06 dop., Jan Synacek wrote:
>  > Did you leave out *all* the changes in the spec file on purpose?
>  > 
>  > Also, any idea how to see what actually changed as diff, instead of just the whole
> documents? 
I screwed up the review - instead of updating 1/3, I replaced it with 2/3. To fix it, I
updated with 1/3 again... To see the what has actually changed, compare diffs
"2" and "4", ignore "3" in reviewboard.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1893/#review3087
-----------------------------------------------------------


On Čec. 14, 2014, 2:17 odp., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1893/
>  -----------------------------------------------------------
>  
>  (Updated Čec. 14, 2014, 2:17 odp.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Add documentation of polkit usage.
>  
>  
>  Diffs
>  -----
>  
>    doc/polkit/polkit-authorization.md PRE-CREATION 
>    doc/polkit/polkit-init.uml PRE-CREATION 
>    doc/polkit/polkit-run.uml PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1893/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1893/#review3781
-----------------------------------------------------------


Pushing into devel/polkit branch and closing the review.

- Jan Safranek


On Čec. 14, 2014, 2:17 odp., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1893/
>  -----------------------------------------------------------
>  
>  (Updated Čec. 14, 2014, 2:17 odp.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Add documentation of polkit usage.
>  
>  
>  Diffs
>  -----
>  
>    doc/polkit/polkit-authorization.md PRE-CREATION 
>    doc/polkit/polkit-init.uml PRE-CREATION 
>    doc/polkit/polkit-run.uml PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1893/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1893/
-----------------------------------------------------------

(Updated Úno. 16, 2015, 3:29 odp.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Add documentation of polkit usage.


Diffs
-----

  doc/polkit/polkit-authorization.md PRE-CREATION 
  doc/polkit/polkit-init.uml PRE-CREATION 
  doc/polkit/polkit-run.uml PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1893/diff/


Testing
-------


Thanks,

Jan Safranek