Re: Review Request 1893: openlmi-providers: polkit v2 [1/3] Add documentation of polkit usage.

[Stephen Gallagher]

>  On Čec. 14, 2014, 9:43 dop., Jan Synacek wrote:
>  > doc/polkit/polkit-authorization.md, line 25
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1893/diff/1/?file=11091#file1109...
>  >
>  >     Does this mean that every provider will be basically forking at least twice
> whenever run? 
Yes, we fork a lot. Also note that every command in our <providername>-cimprovagt
script involves a fork() and exec(). However, once started, the provider process runs for
longer time and handles all requests from an user. It exits only after 5 (or 10?) minutes
of inactivity. It's *not* started for each new request.


>  On Čec. 14, 2014, 9:43 dop., Jan Synacek wrote:
>  > doc/polkit/polkit-authorization.md, lines 122-123
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1893/diff/1/?file=11091#file1109...
>  >
>  >     Hmm, we're wrapping wrappers here. If I understand this right, there's
> not much that can be done here because of the SELinux labels. Otherwise the agent could be
> improved so that it handled everything that the original wrapper handles. Correct? 
Interesting idea... We would need to ship copies of the agent with different names
(cmpiLMI_Networking-cimprovagt, cmpiLMI_Service-cimprovagt, ...), it's easier to copy
just a scripts here instead of a binary.
Still, the script logic could be hidden in the lmipolkitagent binary and the script could
be simple 'lmipolkitagent $@'.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1893/#review3058
-----------------------------------------------------------


On Čec. 11, 2014, 12:31 odp., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1893/
>  -----------------------------------------------------------
>  
>  (Updated Čec. 11, 2014, 12:31 odp.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Add documentation of polkit usage.
>  
>  
>  Diffs
>  -----
>  
>    doc/polkit/polkit-authorization.md PRE-CREATION 
>    doc/polkit/polkit-init.uml PRE-CREATION 
>    doc/polkit/polkit-run.uml PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1893/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>