On July 23, 2013, 11:53 a.m., Jan Safranek wrote:
> src/lmi/storage/LMI_ExtentEncryptionConfigurationService.py, lines 133-137
>
<
http://reviewboard-openlmi.rhcloud.com/r/583/diff/1/?file=3406#file3406li...
>
> I usually let all blivet exceptions pass through, they are caught by job
processor, which then shows error string from the exception (-> usually stderr of
cmdline), which is sometimes more useful than generic "Can't format LUKS".
In that case, I don't have to care about the job's return value, state and the
return error. If that is true, Job.finish_method() doesn't have to have those as well.
Is that right or am I missing something?
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/583/#review717
-----------------------------------------------------------
On July 22, 2013, 9:57 a.m., Jan Synacek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/583/
-----------------------------------------------------------
(Updated July 22, 2013, 9:57 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Add LUKS version 1.
Only LMI_LUKSFormat and LMI_ExtentEncryptionConfigurationService are
implemented. Howerever, these two classes add most of the LUKS
functionality. Setting and Capability classes were omitted.
Diffs
-----
mof/LMI_Storage-Luks.mof 3b7ba8e4fd000acdb1cf4232b8ec18120c4a5029
mof/LMI_Storage.reg cf690b166800bd3e4d15da506d86e60777215080
src/lmi/storage/LMI_ExtentEncryptionConfigurationService.py PRE-CREATION
src/lmi/storage/LMI_LUKSFormat.py PRE-CREATION
src/lmi/storage/cimom_entry.py a7c765244cd4fee2308a42c9147c15f1ff07a98f
Diff:
http://reviewboard-openlmi.rhcloud.com/r/583/diff/
Testing
-------
Thanks,
Jan Synacek