1:27 p.m.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/839/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Hardware: Added PCI_Bridge provider
[SORRY - I've already pushed this commit to the git by mistake..]
Separated PCI_Bridges from PCI_Devices and provided multiple additional
information related to PCI_Bridges.
New providers:
* LMI_PCIBridgeProvider
* LMI_PCIBridgeSystemDeviceProvider
Diffs
-----
mof/60_LMI_Hardware.mof d712b9076969652184769ccad1b2f6689dbf131a
src/hardware/90_LMI_Hardware_Profile_DMTF.mof 777fa909d80c68279484e5b98b7102634ec3a09d
src/hardware/CMakeLists.txt 8089a08e46c79baa1d564dec3f660ab292db245c
src/hardware/LMI_Hardware.h e72536a7414161958b0206e373d1d810d2d930f1
src/hardware/LMI_PCIBridgeProvider.c PRE-CREATION
src/hardware/LMI_PCIBridgeSystemDeviceProvider.c PRE-CREATION
src/hardware/LMI_PCIDeviceProvider.c a88f9cd89df54760c813292194e7859dd9ba2e1c
src/hardware/LMI_PCIDeviceSystemDeviceProvider.c
e473ddfa6dd19e956edb85380fdc6d8ae3485280
src/hardware/PCIDev.h PRE-CREATION
src/hardware/PCIDev.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/839/diff/
Testing
-------
Thanks,
Peter Schiffer
6:34 a.m.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/839/#review1137
-----------------------------------------------------------
src/hardware/LMI_PCIBridgeProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/839/#comment672>
I am not sure how pciutils work, I just assume that it would be better to do
pci_init() only once in LMI_PCIBridgeInitialize and maybe share it with multiple
providers. And be careful with multiple threads, I don't know how reentrant pciutils
are.
I am just afraid pci_init might be pretty heavyweight, who knows what it does.
- Jan Safranek
On Sept. 9, 2013, 8:27 p.m., Peter Schiffer wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/839/
-----------------------------------------------------------
(Updated Sept. 9, 2013, 8:27 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Hardware: Added PCI_Bridge provider
[SORRY - I've already pushed this commit to the git by mistake..]
Separated PCI_Bridges from PCI_Devices and provided multiple additional
information related to PCI_Bridges.
New providers:
* LMI_PCIBridgeProvider
* LMI_PCIBridgeSystemDeviceProvider
Diffs
-----
mof/60_LMI_Hardware.mof d712b9076969652184769ccad1b2f6689dbf131a
src/hardware/90_LMI_Hardware_Profile_DMTF.mof 777fa909d80c68279484e5b98b7102634ec3a09d
src/hardware/CMakeLists.txt 8089a08e46c79baa1d564dec3f660ab292db245c
src/hardware/LMI_Hardware.h e72536a7414161958b0206e373d1d810d2d930f1
src/hardware/LMI_PCIBridgeProvider.c PRE-CREATION
src/hardware/LMI_PCIBridgeSystemDeviceProvider.c PRE-CREATION
src/hardware/LMI_PCIDeviceProvider.c a88f9cd89df54760c813292194e7859dd9ba2e1c
src/hardware/LMI_PCIDeviceSystemDeviceProvider.c
e473ddfa6dd19e956edb85380fdc6d8ae3485280
src/hardware/PCIDev.h PRE-CREATION
src/hardware/PCIDev.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/839/diff/
Testing
-------
Thanks,
Peter Schiffer
7:27 a.m.
On Sept. 10, 2013, 1:34 p.m., Jan Safranek wrote:
> src/hardware/LMI_PCIBridgeProvider.c, line 83
>
<http://reviewboard-openlmi.rhcloud.com/r/839/diff/1/?file=4534#file4534li...
>
> I am not sure how pciutils work, I just assume that it would be better to do
pci_init() only once in LMI_PCIBridgeInitialize and maybe share it with multiple
providers. And be careful with multiple threads, I don't know how reentrant pciutils
are.
>
> I am just afraid pci_init might be pretty heavyweight, who knows what it does.
Fixed in https://reviewboard-openlmi.rhcloud.com/r/849/
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/839/#review1137
-----------------------------------------------------------
On Sept. 9, 2013, 8:27 p.m., Peter Schiffer wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/839/
-----------------------------------------------------------
(Updated Sept. 9, 2013, 8:27 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Hardware: Added PCI_Bridge provider
[SORRY - I've already pushed this commit to the git by mistake..]
Separated PCI_Bridges from PCI_Devices and provided multiple additional
information related to PCI_Bridges.
New providers:
* LMI_PCIBridgeProvider
* LMI_PCIBridgeSystemDeviceProvider
Diffs
-----
mof/60_LMI_Hardware.mof d712b9076969652184769ccad1b2f6689dbf131a
src/hardware/90_LMI_Hardware_Profile_DMTF.mof 777fa909d80c68279484e5b98b7102634ec3a09d
src/hardware/CMakeLists.txt 8089a08e46c79baa1d564dec3f660ab292db245c
src/hardware/LMI_Hardware.h e72536a7414161958b0206e373d1d810d2d930f1
src/hardware/LMI_PCIBridgeProvider.c PRE-CREATION
src/hardware/LMI_PCIBridgeSystemDeviceProvider.c PRE-CREATION
src/hardware/LMI_PCIDeviceProvider.c a88f9cd89df54760c813292194e7859dd9ba2e1c
src/hardware/LMI_PCIDeviceSystemDeviceProvider.c
e473ddfa6dd19e956edb85380fdc6d8ae3485280
src/hardware/PCIDev.h PRE-CREATION
src/hardware/PCIDev.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/839/diff/
Testing
-------
Thanks,
Peter Schiffer
7:28 a.m.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/839/
-----------------------------------------------------------
(Updated Sept. 25, 2013, 2:28 p.m.)
Status
------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Hardware: Added PCI_Bridge provider
[SORRY - I've already pushed this commit to the git by mistake..]
Separated PCI_Bridges from PCI_Devices and provided multiple additional
information related to PCI_Bridges.
New providers:
* LMI_PCIBridgeProvider
* LMI_PCIBridgeSystemDeviceProvider
Diffs
-----
mof/60_LMI_Hardware.mof d712b9076969652184769ccad1b2f6689dbf131a
src/hardware/90_LMI_Hardware_Profile_DMTF.mof 777fa909d80c68279484e5b98b7102634ec3a09d
src/hardware/CMakeLists.txt 8089a08e46c79baa1d564dec3f660ab292db245c
src/hardware/LMI_Hardware.h e72536a7414161958b0206e373d1d810d2d930f1
src/hardware/LMI_PCIBridgeProvider.c PRE-CREATION
src/hardware/LMI_PCIBridgeSystemDeviceProvider.c PRE-CREATION
src/hardware/LMI_PCIDeviceProvider.c a88f9cd89df54760c813292194e7859dd9ba2e1c
src/hardware/LMI_PCIDeviceSystemDeviceProvider.c
e473ddfa6dd19e956edb85380fdc6d8ae3485280
src/hardware/PCIDev.h PRE-CREATION
src/hardware/PCIDev.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/839/diff/
Testing
-------
Thanks,
Peter Schiffer
3917
days inactive
3933
days old
openlmi-reviews@lists.fedorahosted.org
3 comments
1 participants
participants (1)
-
Stephen Gallagher