On Sept. 20, 2013, 9:46 a.m., Martin Krizek wrote:
> blockerbugs/controllers/main.py, line 334
>
<
http://reviewboard-tflink.rhcloud.com/r/52/diff/1/?file=1205#file1205line...
>
> This really should be merged in develop as well as it would result in a
traceback when one tries to associate his fas and bugzilla accounts. I don't see it
fixed anywhere.
Tim Flink wrote:
a lot of the auth stuff was reworked in new_admin due to an issue that ilgiz found.
you can push this if it works but it'll be overwritten by changes that are due to be
merged into develop soon
Ah ok, so that's where it is fixed. In general, I'd rather see issues like this
one fixed in a separate hotfix branch though. Closing this.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/52/#review98
-----------------------------------------------------------
On Sept. 13, 2013, 11:08 a.m., Martin Krizek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/52/
-----------------------------------------------------------
(Updated Sept. 13, 2013, 11:08 a.m.)
Review request for blockerbugs.
Repository: blockerbugs
Description
-------
While going through documentation and commits since last release I found some leftovers
missed in reviews.
Diffs
-----
blockerbugs/controllers/main.py a41627485a77daecc07c8d33f41dc5a17e2ebb97
blockerbugs/cli.py 7151337aa1e16e571d0cf165c87c3c6f50276b90
Diff:
http://reviewboard-tflink.rhcloud.com/r/52/diff/
Testing
-------
Thanks,
Martin Krizek