----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/122/ -----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
If _MAX_INSTANCES is defined in the role, then it will be used as the maximum count of instances for this role. If is is not defined, the global MAX_INSTANCES definition will be used.
To set a different maximum instance count, add _MAX_INSTANCES=X to the Role definition in role.py next to _DEFAULTS and _READONLY_SETTINGS.
Diffs -----
src/rolekit/server/dbusrole.py 5f978215a94e304ae76b410a59ec7f598219cedc
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/122/diff/
Testing -------
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/122/#review356 -----------------------------------------------------------
src/rolekit/server/dbusrole.py http://reviewboard-fedoraserver.rhcloud.com/r/122/#comment187
I think it makes more sense to set the _MAX_INSTANCES default value in RoleBase and then just allow the role implementations to override it if they want to. It seems less complex.
- Stephen Gallagher
On Nov. 7, 2014, 7:34 p.m., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/122/
(Updated Nov. 7, 2014, 7:34 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
If _MAX_INSTANCES is defined in the role, then it will be used as the maximum count of instances for this role. If is is not defined, the global MAX_INSTANCES definition will be used.
To set a different maximum instance count, add _MAX_INSTANCES=X to the Role definition in role.py next to _DEFAULTS and _READONLY_SETTINGS.
Diffs
src/rolekit/server/dbusrole.py 5f978215a94e304ae76b410a59ec7f598219cedc
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/122/diff/
Testing
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/122/ -----------------------------------------------------------
(Updated Nov. 13, 2014, 4:38 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
If _MAX_INSTANCES is defined in the role, then it will be used as the maximum count of instances for this role. If is is not defined, the global MAX_INSTANCES definition will be used.
To set a different maximum instance count, add _MAX_INSTANCES=X to the Role definition in role.py next to _DEFAULTS and _READONLY_SETTINGS.
Diffs (updated) -----
config/roles/databaseserver/role.py 0c26477ac2bc07d9cbee038d55a784ce6e66473d config/roles/domaincontroller/role.py 63996bcea0c7649bbf4b27d3e0c3e92785985481 config/roles/testrole/role.py e301bcd94ee46d79e459f9ae87160edfa7e00d29 doc/xml/rolekit.roles.xml 58733254f97a8b80cc04501a95543e9acb923836 src/rolekit/config/__init__.py.in 12ed32e8e9488330aad950282d59cf9e520903ec src/rolekit/server/dbusrole.py 5f978215a94e304ae76b410a59ec7f598219cedc src/rolekit/server/rolebase.py 8ebe4bb3d6dc0077ded14b980e3fed541719e37c
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/122/diff/
Testing -------
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/122/ -----------------------------------------------------------
(Updated Nov. 13, 2014, 4:52 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Summary (updated) -----------------
Limit instance count by plugin _MAX_INSTANCES
Repository: rolekit
Description (updated) -------
If _MAX_INSTANCES is defined in a role, then be used as the maximum count of instances for this role. It will overload the default in RoleBase.
The MAX_INSTANCES setting in rolekit.config has been removed.
Diffs -----
config/roles/databaseserver/role.py 0c26477ac2bc07d9cbee038d55a784ce6e66473d config/roles/domaincontroller/role.py 63996bcea0c7649bbf4b27d3e0c3e92785985481 config/roles/testrole/role.py e301bcd94ee46d79e459f9ae87160edfa7e00d29 doc/xml/rolekit.roles.xml 58733254f97a8b80cc04501a95543e9acb923836 src/rolekit/config/__init__.py.in 12ed32e8e9488330aad950282d59cf9e520903ec src/rolekit/server/dbusrole.py 5f978215a94e304ae76b410a59ec7f598219cedc src/rolekit/server/rolebase.py 8ebe4bb3d6dc0077ded14b980e3fed541719e37c
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/122/diff/
Testing -------
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/122/#review357 -----------------------------------------------------------
Ship it!
Ship It!
- Stephen Gallagher
On Nov. 13, 2014, 4:52 p.m., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/122/
(Updated Nov. 13, 2014, 4:52 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
If _MAX_INSTANCES is defined in a role, then be used as the maximum count of instances for this role. It will overload the default in RoleBase.
The MAX_INSTANCES setting in rolekit.config has been removed.
Diffs
config/roles/databaseserver/role.py 0c26477ac2bc07d9cbee038d55a784ce6e66473d config/roles/domaincontroller/role.py 63996bcea0c7649bbf4b27d3e0c3e92785985481 config/roles/testrole/role.py e301bcd94ee46d79e459f9ae87160edfa7e00d29 doc/xml/rolekit.roles.xml 58733254f97a8b80cc04501a95543e9acb923836 src/rolekit/config/__init__.py.in 12ed32e8e9488330aad950282d59cf9e520903ec src/rolekit/server/dbusrole.py 5f978215a94e304ae76b410a59ec7f598219cedc src/rolekit/server/rolebase.py 8ebe4bb3d6dc0077ded14b980e3fed541719e37c
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/122/diff/
Testing
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/122/ -----------------------------------------------------------
(Updated Nov. 17, 2014, 6:42 p.m.)
Status ------
This change has been marked as submitted.
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
If _MAX_INSTANCES is defined in a role, then be used as the maximum count of instances for this role. It will overload the default in RoleBase.
The MAX_INSTANCES setting in rolekit.config has been removed.
Diffs -----
config/roles/databaseserver/role.py 0c26477ac2bc07d9cbee038d55a784ce6e66473d config/roles/domaincontroller/role.py 63996bcea0c7649bbf4b27d3e0c3e92785985481 config/roles/testrole/role.py e301bcd94ee46d79e459f9ae87160edfa7e00d29 doc/xml/rolekit.roles.xml 58733254f97a8b80cc04501a95543e9acb923836 src/rolekit/config/__init__.py.in 12ed32e8e9488330aad950282d59cf9e520903ec src/rolekit/server/dbusrole.py 5f978215a94e304ae76b410a59ec7f598219cedc src/rolekit/server/rolebase.py 8ebe4bb3d6dc0077ded14b980e3fed541719e37c
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/122/diff/
Testing -------
Thanks,
Thomas Woerner
rolekit-commits@lists.fedorahosted.org