----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/83/ -----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
rolectl: Fix deploy without settings-file
Diffs -----
src/rolectl f05206487c813dd0de2c14fd234d399137c66048
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/83/diff/
Testing -------
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/83/#review282 -----------------------------------------------------------
src/rolectl http://reviewboard-fedoraserver.rhcloud.com/r/83/#comment165
Please update the help text for --settings-file to state that omitting this will result in an attempt to deploy with no custom settings and will fail if the role has any mandatory settings.
- Stephen Gallagher
On Oct. 10, 2014, 12:47 p.m., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/83/
(Updated Oct. 10, 2014, 12:47 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
rolectl: Fix deploy without settings-file
Diffs
src/rolectl f05206487c813dd0de2c14fd234d399137c66048
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/83/diff/
Testing
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/83/ -----------------------------------------------------------
(Updated Oct. 10, 2014, 1:01 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
rolectl: Fix deploy without settings-file
Diffs (updated) -----
src/rolectl f05206487c813dd0de2c14fd234d399137c66048
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/83/diff/
Testing -------
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/83/#review283 -----------------------------------------------------------
Ship it!
Ship It!
- Stephen Gallagher
On Oct. 10, 2014, 1:01 p.m., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/83/
(Updated Oct. 10, 2014, 1:01 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
rolectl: Fix deploy without settings-file
Diffs
src/rolectl f05206487c813dd0de2c14fd234d399137c66048
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/83/diff/
Testing
Thanks,
Thomas Woerner
On Oct. 10, 2014, 1:03 p.m., Stephen Gallagher wrote:
Ship It!
Pushed: https://git.fedorahosted.org/cgit/rolekit.git/commit/?id=25591b679b3ccf2bcc5...
- Thomas
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/83/#review283 -----------------------------------------------------------
On Oct. 10, 2014, 1:29 p.m., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/83/
(Updated Oct. 10, 2014, 1:29 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
rolectl: Fix deploy without settings-file
Diffs
src/rolectl f05206487c813dd0de2c14fd234d399137c66048
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/83/diff/
Testing
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/83/ -----------------------------------------------------------
(Updated Oct. 10, 2014, 1:29 p.m.)
Status ------
This change has been marked as submitted.
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
rolectl: Fix deploy without settings-file
Diffs -----
src/rolectl f05206487c813dd0de2c14fd234d399137c66048
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/83/diff/
Testing -------
Thanks,
Thomas Woerner
rolekit-commits@lists.fedorahosted.org
-
Stephen Gallagher