Re: Review Request 118: Domain Controller: Relax primary_ip restriction

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/118/#review346
-----------------------------------------------------------

Ship it!


LGTM

- Simo Sorce


On Nov. 3, 2014, 9:06 p.m., Stephen Gallagher wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/118/
>  -----------------------------------------------------------
>  
>  (Updated Nov. 3, 2014, 9:06 p.m.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
> Woerner.
>  
>  
>  Bugs: 33
>      https://fedorahosted.org/rolekit/ticket/33
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  FreeIPA 4.1 will fix the bug making this option mandatory. We will
>  be shipping rolekit together with that release, so we should relax
>  this check.
>  
>  This should not be pushed upstream until FreeIPA 4.1 is submitted for stable in Fedora.
>  
>  
>  Diffs
>  -----
>  
>    config/roles/domaincontroller/role.py b36cb15b2890555f077cdb14d2d2240d8a882d9b 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/118/diff/
>  
>  
>  Testing
>  -------
>  
>  Installed the FreeIPA 4.1 testing packages and ran a deploy without **primary_ip**
> specified in the settings.json file. 
>  
>  
>  Thanks,
>  
>  Stephen Gallagher
>  
>