Re: Review Request 219: obviate the need to restore config files from backups

[Stephen Gallagher]

>  On Sept. 22, 2015, 3 nachm., Stephen Gallagher wrote:
>  > config/roles/databaseserver/role.py, lines 66-71
>  >
> <http://reviewboard-fedoraserver.rhcloud.com/r/219/diff/2/?file=1121#file1...
>  >
>  >     How are we defining "global" regexes here? Per-file or per-line? That
> needs explanation. Right now, it looks like it's per-file.
>  
>  Nils Philippsen wrote:
>      The `global` option specifies that replacing/appending is done more than once,
> everytime the regex matches. Regex replacements are always done "globally" in a
> line. 
I'll probably rename this option to `apply_multi`.


- Nils


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/219/#review535
-----------------------------------------------------------


On Sept. 19, 2015, 3:04 vorm., Nils Philippsen wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/219/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 19, 2015, 3:04 vorm.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
> Gallagher, and Thomas Woerner.
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  Use an internal implementation instead of calling sed to tweak
>  configuration files. This has the neat side effect of overwriting the
>  target file as the last step, side-stepping the need to copy over the
>  backup file on errors.
>  
>  This change requires python3-slip >= 0.6.4 because in previous versions
>  slip.util.files.overwrite_safely() doesn't preserve file ownership, and
>  the postgresql configuration files need to be owned by the postgres user.
>  
>  https://github.com/libre-server/rolekit/issues/21
>  
>  
>  Diffs
>  -----
>  
>    config/roles/databaseserver/role.py 7443979ba7ff87ff6a018ac8a7a0a89e2b8ad6e7 
>    rolekit.spec f3cf9f4b799909bc293f4e56eea78c71e7112e9c 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/219/diff/
>  
>  
>  Testing
>  -------
>  
>  Deployed `databaseserver` role, compared contents of `postgresql.conf`, `pg_hba.conf`
> with what the original sed commands produced.
>  
>  
>  Thanks,
>  
>  Nils Philippsen
>  
>