On July 21, 2015, 2:46 p.m., Thomas Woerner wrote:
> src/rolekit/server/rolebase.py, line 1055
>
<
http://reviewboard-fedoraserver.rhcloud.com/r/162/diff/1/?file=716#file71...
>
> Added in the same way as in deploy.. not exactly in this position, but in this
method in the same way as in deploy_async.
Thomas Woerner wrote:
Thse are the missing parts:
# Install package groups and packages
yield async.call_future(self.installPackages())
# Install firewall
self.installFirewall()
and later on
# Set up systemd target files
self.create_target(target)
These need to be verified before doing again.
This is optional for now, but should be addressed for 0.4.0
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/162/#review426
-----------------------------------------------------------
On July 15, 2015, 4:10 p.m., Stephen Gallagher wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/162/
-----------------------------------------------------------
(Updated July 15, 2015, 4:10 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
Woerner.
Repository: rolekit
Description
-------
Make redeploy routine asynchronous
Diffs
-----
config/roles/databaseserver/role.py f0ec96d4bb0555baf961f3e973e01742fc3f8ac0
config/roles/domaincontroller/role.py 29f6be8f68d8f9f29d9531f27363ea46e7ef8e52
config/roles/testrole/role.py 8d8d145e4d81c730aeb47f38cf2a98ca8550840e
src/rolekit/server/rolebase.py fec2de57f2bce114de28c3bfcd4ed75e29e2dd58
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/162/diff/
Testing
-------
Tested with review #161
Thanks,
Stephen Gallagher