On Aug. 26, 2015, 2:09 p.m., Stephen Gallagher wrote:
> src/rolekit/server/io/rolesettings.py, lines 52-55
>
<
http://reviewboard-fedoraserver.rhcloud.com/r/196/diff/1/?file=874#file87...
>
> Wouldn't it be more "pythonic" to do:
>
> ```
> try:
> self._callbacks[signal] = (handler, args)
> except KeyError:
> raise ValueError("Unknown signal name '%s'" % name)
> ```
Thomas Woerner wrote:
This would allow to set a handler for unsupported and never called signals like
"foo" also.
Ah, you are right of course. I was a little mixed up there.
- Stephen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/196/#review481
-----------------------------------------------------------
On Aug. 26, 2015, 1:21 p.m., Thomas Woerner wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/196/
-----------------------------------------------------------
(Updated Aug. 26, 2015, 1:21 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
Only the changed signal is supported right now. As soon as a settings is
modified, the connected handler will be called for this setting.
Diffs
-----
src/rolekit/server/io/rolesettings.py 18f4871faf87ba23d21a3f9bc2c13b14463a8ccf
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/196/diff/
Testing
-------
Thanks,
Thomas Woerner