Re: Review Request 214: don't write extension unit files multiple times

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/214/
-----------------------------------------------------------

(Updated Sept. 16, 2015, 12:59 p.m.)


Status
------

This change has been marked as submitted.


Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
Gallagher, and Thomas Woerner.


Repository: rolekit


Description
-------

Before, units that are used for more than one dependency type get
written multiple times, and so create useless backup files (and
potentially overwrite legit ones).


Diffs
-----

  src/rolekit/server/rolebase.py d7063c0069ae03d86c75286290780d3d1cda772a 

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/214/diff/


Testing
-------

[root@vagrant ~]# echo '{"database": "example"}' | rolectl
deploy databaseserver --settings-stdin 
Deployment can take a long time. To monitor the progress, run 
journalctl -ef -u rolekit
success
[root@vagrant ~]# find /etc/systemd/ -name role-\*
/etc/systemd/system/role-fail-databaseserver-1.service
/etc/systemd/system/postgresql.service.d/role-databaseserver-1.target.conf
/etc/systemd/system/multi-user.target.wants/role-databaseserver-1.target
/etc/systemd/system/syslog.target.d/role-databaseserver-1.target.conf
/etc/systemd/system/role-databaseserver-1.target
/etc/systemd/system/network.target.d/role-databaseserver-1.target.conf
[root@vagrant ~]#

--> no `*.old` files


Thanks,

Nils Philippsen