On July 30, 2015, 11:55 a.m., Stephen Gallagher wrote:
> config/roles/domaincontroller/role.py, lines 278-282
>
<
http://reviewboard-fedoraserver.rhcloud.com/r/169/diff/1/?file=747#file74...
>
> I think we may want to raise a NotImplementedError() here, rather than yielding
None, actually. If we return success, users may think we really updated, when in fact we
have done nothing at all.
Nils Philippsen wrote:
That's a case of "monkey sees, monkey learns". When other routines
where made async, a simple `pass` became `yield None`. Perhaps we should check other
occurrances of `yield None` as well?
Yes, those would have been wrong, but they were short-term issues because the conversions
were usually a step towards replacing it with a real implementation. I agree we should
review the existing code for any such mistakes, though.
- Stephen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/169/#review441
-----------------------------------------------------------
On July 30, 2015, 7:52 a.m., Nils Philippsen wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/169/
-----------------------------------------------------------
(Updated July 30, 2015, 7:52 a.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
Woerner.
Repository: rolekit
Description
-------
https://github.com/libre-server/rolekit/issues/5
Diffs
-----
config/roles/databaseserver/role.py 35934f6781a7864ece48572cc98ccceafa010211
config/roles/domaincontroller/role.py fa766b14a605769b89abbca90422748b8f8a9568
config/roles/memcache/role.py abc94986862312bfb02d17567d100a8528f83a61
config/roles/testrole/role.py 3b03fd42f0a116c25221371b38617d6a8f08b80c
doc/examples/emptyrole/role.py d6207fbdc94f11aa0de243e51de259dd2e552a5a
src/rolekit/server/rolebase.py b8bc640bd70fe995e4183c71bd77b355a42a4228
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/169/diff/
Testing
-------
Thanks,
Nils Philippsen