----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/84/ -----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
Add missing requires for firewalld, systemd, NetworkManager and yum
Diffs -----
rolekit.spec ff1c1d92bfde96fe8dad1a6d93b82634365e2ddd
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/84/diff/
Testing -------
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/84/#review285 -----------------------------------------------------------
rolekit.spec http://reviewboard-fedoraserver.rhcloud.com/r/84/#comment166
My personal preference is one-dep-per-line.
Also, does RPM support comma-separated Requires? I thought they were space-separated.
- Stephen Gallagher
On Oct. 10, 2014, 1:29 p.m., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/84/
(Updated Oct. 10, 2014, 1:29 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
Add missing requires for firewalld, systemd, NetworkManager and yum
Diffs
rolekit.spec ff1c1d92bfde96fe8dad1a6d93b82634365e2ddd
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/84/diff/
Testing
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/84/ -----------------------------------------------------------
(Updated Oct. 10, 2014, 3:33 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
Add missing requires for firewalld, systemd, NetworkManager and yum
Diffs (updated) -----
rolekit.spec ff1c1d92bfde96fe8dad1a6d93b82634365e2ddd
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/84/diff/
Testing -------
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/84/#review286 -----------------------------------------------------------
Ship it!
Ship It!
- Stephen Gallagher
On Oct. 10, 2014, 3:33 p.m., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/84/
(Updated Oct. 10, 2014, 3:33 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
Add missing requires for firewalld, systemd, NetworkManager and yum
Diffs
rolekit.spec ff1c1d92bfde96fe8dad1a6d93b82634365e2ddd
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/84/diff/
Testing
Thanks,
Thomas Woerner
On Oct. 10, 2014, 3:37 p.m., Stephen Gallagher wrote:
Ship It!
Pushed https://git.fedorahosted.org/cgit/rolekit.git/commit/?id=91fd509fbf8516cba4a...
- Thomas
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/84/#review286 -----------------------------------------------------------
On Oct. 10, 2014, 3:33 p.m., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/84/
(Updated Oct. 10, 2014, 3:33 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
Add missing requires for firewalld, systemd, NetworkManager and yum
Diffs
rolekit.spec ff1c1d92bfde96fe8dad1a6d93b82634365e2ddd
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/84/diff/
Testing
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/84/ -----------------------------------------------------------
(Updated Oct. 10, 2014, 3:39 p.m.)
Status ------
This change has been marked as submitted.
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
Add missing requires for firewalld, systemd, NetworkManager and yum
Diffs -----
rolekit.spec ff1c1d92bfde96fe8dad1a6d93b82634365e2ddd
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/84/diff/
Testing -------
Thanks,
Thomas Woerner
rolekit-commits@lists.fedorahosted.org
-
Stephen Gallagher