1:53 p.m.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/163/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
Woerner.
Repository: rolekit
Description
-------
Just add
"contained": True
to the settings JSON to try it out.
Diffs
-----
config/roles/memcache/role.py PRE-CREATION
src/rolekit/server/io/systemd.py ad28004e874db123f51ecad8ff39d1e863b8b604
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/163/diff/
Testing
-------
Repeatedly created, decommissioned and redeployed the role
Thanks,
Stephen Gallagher
10:35 a.m.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/163/#review434
-----------------------------------------------------------
config/roles/memcache/role.py (line 24)
<http://reviewboard-fedoraserver.rhcloud.com/r/163/#comment251>
There is no requirement for docker in the rolekit spec file.
- Thomas Woerner
On July 16, 2015, 6:53 p.m., Stephen Gallagher wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/163/
-----------------------------------------------------------
(Updated July 16, 2015, 6:53 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
Woerner.
Repository: rolekit
Description
-------
Just add
"contained": True
to the settings JSON to try it out.
Diffs
-----
config/roles/memcache/role.py PRE-CREATION
src/rolekit/server/io/systemd.py ad28004e874db123f51ecad8ff39d1e863b8b604
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/163/diff/
Testing
-------
Repeatedly created, decommissioned and redeployed the role
Thanks,
Stephen Gallagher
10:37 a.m.
On July 21, 2015, 3:35 p.m., Thomas Woerner wrote:
> config/roles/memcache/role.py, line 24
>
<http://reviewboard-fedoraserver.rhcloud.com/r/163/diff/1/?file=723#file72...
>
> There is no requirement for docker in the rolekit spec file.
This should be python-docker-py or python3-docker-py depending on fedora version
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/163/#review434
-----------------------------------------------------------
On July 16, 2015, 6:53 p.m., Stephen Gallagher wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/163/
-----------------------------------------------------------
(Updated July 16, 2015, 6:53 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
Woerner.
Repository: rolekit
Description
-------
Just add
"contained": True
to the settings JSON to try it out.
Diffs
-----
config/roles/memcache/role.py PRE-CREATION
src/rolekit/server/io/systemd.py ad28004e874db123f51ecad8ff39d1e863b8b604
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/163/diff/
Testing
-------
Repeatedly created, decommissioned and redeployed the role
Thanks,
Stephen Gallagher
1:17 p.m.
On July 21, 2015, 3:35 p.m., Thomas Woerner wrote:
> config/roles/memcache/role.py, line 24
>
<http://reviewboard-fedoraserver.rhcloud.com/r/163/diff/1/?file=723#file72...
>
> There is no requirement for docker in the rolekit spec file.
Thomas Woerner wrote:
This should be python-docker-py or python3-docker-py depending on fedora version
No, it shouldn't. Rolekit is presently python3-only. It will still run on older
systems with the python 3 interpreter.
- Stephen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/163/#review434
-----------------------------------------------------------
On July 16, 2015, 6:53 p.m., Stephen Gallagher wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/163/
-----------------------------------------------------------
(Updated July 16, 2015, 6:53 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
Woerner.
Repository: rolekit
Description
-------
Just add
"contained": True
to the settings JSON to try it out.
Diffs
-----
config/roles/memcache/role.py PRE-CREATION
src/rolekit/server/io/systemd.py ad28004e874db123f51ecad8ff39d1e863b8b604
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/163/diff/
Testing
-------
Repeatedly created, decommissioned and redeployed the role
Thanks,
Stephen Gallagher
1:17 p.m.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/163/
-----------------------------------------------------------
(Updated July 21, 2015, 6:17 p.m.)
Status
------
This change has been discarded.
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
Woerner.
Repository: rolekit
Description
-------
Just add
"contained": True
to the settings JSON to try it out.
Diffs
-----
config/roles/memcache/role.py PRE-CREATION
src/rolekit/server/io/systemd.py ad28004e874db123f51ecad8ff39d1e863b8b604
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/163/diff/
Testing
-------
Repeatedly created, decommissioned and redeployed the role
Thanks,
Stephen Gallagher
3224
days inactive
3229
days old
rolekit-commits@lists.fedorahosted.org
4 comments
1 participants
participants (1)
-
Stephen Gallagher