----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/134/ -----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
- Creates backup copy of the files
Diffs -----
config/roles/databaseserver/role.py a1d215118205382dec93b8b033b5246c515a4134
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/134/diff/
Testing -------
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/134/#review385 -----------------------------------------------------------
config/roles/databaseserver/role.py http://reviewboard-fedoraserver.rhcloud.com/r/134/#comment215
Unnecessary copy
There's no reason to create this copy manually. The -i argument to sed can optionally take a suffix for creating a backup file.
config/roles/databaseserver/role.py http://reviewboard-fedoraserver.rhcloud.com/r/134/#comment216
Unnecessary copy
There's no reason to create this copy manually. The -i argument to sed can optionally take a suffix for creating a backup file.
- Stephen Gallagher
On Feb. 20, 2015, 5:06 p.m., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/134/
(Updated Feb. 20, 2015, 5:06 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
- Creates backup copy of the files
Diffs
config/roles/databaseserver/role.py a1d215118205382dec93b8b033b5246c515a4134
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/134/diff/
Testing
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/134/#review386 -----------------------------------------------------------
config/roles/databaseserver/role.py http://reviewboard-fedoraserver.rhcloud.com/r/134/#comment217
We also want this path to be global to the role, so we can retrieve it in the decommission() step.
Lastly, we should probably allow for this to path be overridden if there's a valid reason.
- Stephen Gallagher
On Feb. 20, 2015, 5:06 p.m., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/134/
(Updated Feb. 20, 2015, 5:06 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
- Creates backup copy of the files
Diffs
config/roles/databaseserver/role.py a1d215118205382dec93b8b033b5246c515a4134
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/134/diff/
Testing
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/134/ -----------------------------------------------------------
(Updated Feb. 20, 2015, 8:15 p.m.)
Status ------
This change has been discarded.
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
- Creates backup copy of the files
Diffs -----
config/roles/databaseserver/role.py a1d215118205382dec93b8b033b5246c515a4134
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/134/diff/
Testing -------
Thanks,
Thomas Woerner
rolekit-commits@lists.fedorahosted.org