----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/133/ -----------------------------------------------------------
Review request for RoleKit Mailing List, Dan Mossor, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
Work In Progress on the Database Server Role.
Diffs -----
config/Makefile.am c657c799066ec08d2306cd7b4de84df9dc582ccd config/roles/databaseserver/role.py f3d998e50c7bad11f492d2b5f327ab920d6e2f2b config/roles/databaseserver/tools/rk_db_setpwd.py PRE-CREATION rolekit.spec b0c69d3912eefa280c22279bbc3c035c9b7f2def
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/133/diff/
Testing -------
Thanks,
Stephen Gallagher
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/133/#review381 -----------------------------------------------------------
config/roles/databaseserver/role.py http://reviewboard-fedoraserver.rhcloud.com/r/133/#comment212
Please remove the SpooledTemoporaryFile import, it is not used anymore.
- Thomas Woerner
On Feb. 17, 2015, 9:10 p.m., Stephen Gallagher wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/133/
(Updated Feb. 17, 2015, 9:10 p.m.)
Review request for RoleKit Mailing List, Dan Mossor, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
Work In Progress on the Database Server Role.
Diffs
config/Makefile.am c657c799066ec08d2306cd7b4de84df9dc582ccd config/roles/databaseserver/role.py f3d998e50c7bad11f492d2b5f327ab920d6e2f2b config/roles/databaseserver/tools/rk_db_setpwd.py PRE-CREATION rolekit.spec b0c69d3912eefa280c22279bbc3c035c9b7f2def
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/133/diff/
Testing
Thanks,
Stephen Gallagher
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/133/ -----------------------------------------------------------
(Updated Feb. 18, 2015, 4:20 p.m.)
Review request for RoleKit Mailing List, Dan Mossor, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Changes -------
Removed unneeded import
Repository: rolekit
Description -------
Work In Progress on the Database Server Role.
Diffs (updated) -----
config/Makefile.am c657c799066ec08d2306cd7b4de84df9dc582ccd config/roles/databaseserver/role.py f3d998e50c7bad11f492d2b5f327ab920d6e2f2b config/roles/databaseserver/tools/rk_db_setpwd.py PRE-CREATION rolekit.spec b0c69d3912eefa280c22279bbc3c035c9b7f2def
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/133/diff/
Testing -------
Thanks,
Stephen Gallagher
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/133/#review382 -----------------------------------------------------------
config/roles/databaseserver/tools/rk_db_setpwd.py http://reviewboard-fedoraserver.rhcloud.com/r/133/#comment213
Please add python-eventlet to the package list for installation.
- Thomas Woerner
On Feb. 18, 2015, 4:20 p.m., Stephen Gallagher wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/133/
(Updated Feb. 18, 2015, 4:20 p.m.)
Review request for RoleKit Mailing List, Dan Mossor, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
Work In Progress on the Database Server Role.
Diffs
config/Makefile.am c657c799066ec08d2306cd7b4de84df9dc582ccd config/roles/databaseserver/role.py f3d998e50c7bad11f492d2b5f327ab920d6e2f2b config/roles/databaseserver/tools/rk_db_setpwd.py PRE-CREATION rolekit.spec b0c69d3912eefa280c22279bbc3c035c9b7f2def
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/133/diff/
Testing
Thanks,
Stephen Gallagher
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/133/#review383 -----------------------------------------------------------
config/roles/databaseserver/tools/rk_db_setpwd.py http://reviewboard-fedoraserver.rhcloud.com/r/133/#comment214
The package name is not correct, it should be python-psycopg2
- Thomas Woerner
On Feb. 18, 2015, 4:20 p.m., Stephen Gallagher wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/133/
(Updated Feb. 18, 2015, 4:20 p.m.)
Review request for RoleKit Mailing List, Dan Mossor, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
Work In Progress on the Database Server Role.
Diffs
config/Makefile.am c657c799066ec08d2306cd7b4de84df9dc582ccd config/roles/databaseserver/role.py f3d998e50c7bad11f492d2b5f327ab920d6e2f2b config/roles/databaseserver/tools/rk_db_setpwd.py PRE-CREATION rolekit.spec b0c69d3912eefa280c22279bbc3c035c9b7f2def
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/133/diff/
Testing
Thanks,
Stephen Gallagher
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/133/ -----------------------------------------------------------
(Updated Feb. 20, 2015, 3:25 p.m.)
Review request for RoleKit Mailing List, Dan Mossor, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Changes -------
Add package installation of python-psycopg2
Repository: rolekit
Description (updated) -------
Initial Database Server Role.
Diffs (updated) -----
config/Makefile.am c657c799066ec08d2306cd7b4de84df9dc582ccd config/roles/databaseserver/role.py f3d998e50c7bad11f492d2b5f327ab920d6e2f2b config/roles/databaseserver/tools/rk_db_setpwd.py PRE-CREATION rolekit.spec b0c69d3912eefa280c22279bbc3c035c9b7f2def
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/133/diff/
Testing -------
Thanks,
Stephen Gallagher
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/133/#review384 -----------------------------------------------------------
Ship it!
Ship It!
- Thomas Woerner
On Feb. 20, 2015, 3:25 p.m., Stephen Gallagher wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/133/
(Updated Feb. 20, 2015, 3:25 p.m.)
Review request for RoleKit Mailing List, Dan Mossor, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
Initial Database Server Role.
Diffs
config/Makefile.am c657c799066ec08d2306cd7b4de84df9dc582ccd config/roles/databaseserver/role.py f3d998e50c7bad11f492d2b5f327ab920d6e2f2b config/roles/databaseserver/tools/rk_db_setpwd.py PRE-CREATION rolekit.spec b0c69d3912eefa280c22279bbc3c035c9b7f2def
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/133/diff/
Testing
Thanks,
Stephen Gallagher
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/133/ -----------------------------------------------------------
(Updated Feb. 20, 2015, 3:43 p.m.)
Status ------
This change has been marked as submitted.
Review request for RoleKit Mailing List, Dan Mossor, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
Initial Database Server Role.
Diffs -----
config/Makefile.am c657c799066ec08d2306cd7b4de84df9dc582ccd config/roles/databaseserver/role.py f3d998e50c7bad11f492d2b5f327ab920d6e2f2b config/roles/databaseserver/tools/rk_db_setpwd.py PRE-CREATION rolekit.spec b0c69d3912eefa280c22279bbc3c035c9b7f2def
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/133/diff/
Testing -------
Thanks,
Stephen Gallagher
rolekit-commits@lists.fedorahosted.org