Review Request 194: rolekit shouldn't block basic.target

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/194/
-----------------------------------------------------------

Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
Gallagher, and Thomas Woerner.


Repository: rolekit


Description
-------

This should have been multi-user.target all along.


Diffs
-----

  config/rolekit.service.in cf78e1fef3a9a4315128d84d9bb5a2d7ba1e33a3 

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/194/diff/


Testing
-------


Thanks,

Stephen Gallagher

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/194/#review469
-----------------------------------------------------------


Why not network.target? Or don't we (as in Fedora) care about any other targets than
multi-user and graphical?

- Nils Philippsen


On Aug. 19, 2015, 7:59 nachm., Stephen Gallagher wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/194/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 19, 2015, 7:59 nachm.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
> Gallagher, and Thomas Woerner.
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  This should have been multi-user.target all along.
>  
>  
>  Diffs
>  -----
>  
>    config/rolekit.service.in cf78e1fef3a9a4315128d84d9bb5a2d7ba1e33a3 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/194/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Stephen Gallagher
>  
>

[Stephen Gallagher]

>  On Aug. 20, 2015, 10:03 a.m., Nils Philippsen wrote:
>  > Why not network.target? Or don't we (as in Fedora) care about any other targets
> than multi-user and graphical? 
Because we only want rolekit to run when the machine is in at least one of the
"usable" states. network.target is enabled in a variety of other places
(possibly including the system-update.target or similar).

multi-user.target is a subset of graphical.target and is always present if we are booting
to either one. network.target is better used for ordering rather than WantedBy (if we
absolutely needed NICs to be available before rolekit started, I'd still do
`WantedBy=multi-user.target` and add in `After=network.target`, but we don't; rolekit
only uses UNIX sockets (and eventually kdbus), which will be fully covered by basic.target
which does not need to be explicitly ordered after.


- Stephen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/194/#review469
-----------------------------------------------------------


On Aug. 19, 2015, 5:59 p.m., Stephen Gallagher wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/194/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 19, 2015, 5:59 p.m.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
> Gallagher, and Thomas Woerner.
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  This should have been multi-user.target all along.
>  
>  
>  Diffs
>  -----
>  
>    config/rolekit.service.in cf78e1fef3a9a4315128d84d9bb5a2d7ba1e33a3 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/194/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Stephen Gallagher
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/194/
-----------------------------------------------------------

(Updated Aug. 24, 2015, 12:04 p.m.)


Status
------

This change has been marked as submitted.


Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
Gallagher, and Thomas Woerner.


Repository: rolekit


Description
-------

This should have been multi-user.target all along.


Diffs
-----

  config/rolekit.service.in cf78e1fef3a9a4315128d84d9bb5a2d7ba1e33a3 

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/194/diff/


Testing
-------


Thanks,

Stephen Gallagher