On Fri, Jul 18, 2014 at 05:47:05PM +0200, Pavel Reichl wrote:
Hello,
please see attached patch which is result of discussion in thread:
LDAP: tokengroups do not work with id_provider=ldap
>[snip]
>>>>>>>>Anyhow, find_subdomain_by_sid is misnamed, we routinely
use the function
>>>>>>>>to find the primary domain.
>>>>>>>I think find_subdomain_by_sid() does what the name says and
of course it
>>>>>>>can return the primary domain as long as the SID of the
domain is know
>>>>> ^^^^^^
>>>>>fwiw, this was my concern, the function is named
"find_subdomain" yet it
>>>>>can find both main domain and subdomain. But I won't bikeshed any
further.
>>>>ah, sorry, now I see your point. I agree that the name misleading but I
>>>>think this can be fixed after the release.
>Would 's/find_subdomain_by_sid/find_domain_by_sid/' be a sufficient
>solution?
Thanks,
Pavel Reichl
Compiles and find_subdomain_by_id is nowhere to be found:
$ git grep find_subdomain_by_sid
$ echo $?
1
Patch looks OK, too.
ACK