Re: [SSSD] [PATCHES] sbus: support incoming signals and NameOwnerChanged
On Wed, Jun 03, 2015 at 01:28:01PM +0200, Pavel Březina wrote:
From 4adbab01651583c48e103a3d0d5915a6eb6d3809 Mon Sep 17 00:00:00
2001
From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrezina(a)redhat.com>
Date: Wed, 3 Jun 2015 12:35:42 +0200
Subject: [PATCH 1/2] sbus: add support for incoming signals
So far I only read the code, I didn't do any testing. The code reads
nicely to me, nice job!
Can you write a better commit message that describes from a 100-meter
view how the patch works and mentions the dbus filtering API you used?
Even a dbus API URL would be nice.
Also, can you write tests? I think the sbus subtree is very nicely
tested, it would be nice to keep that tradition.