hmm, those warnings didn't appear, flags probably got somehow mixed up.
fixed patch is attached
O.
On 08/22/2012 05:20 PM, Jakub Hrozek wrote:
On Wed, Aug 22, 2012 at 03:18:05PM +0200, Jakub Hrozek wrote:
> On Tue, Aug 21, 2012 at 04:48:08PM +0200, Ondrej Kos wrote:
>> Fixed
>>
>> Function was modified to just return the given string as uppercase.
>> The part where the whole principal is being processed was restored
>> to it's previous state.
>>
>> New patch is attached
>>
>> Ondrej
>>
>
> Fix the braces in this hunk:
>> +
>> + realm = talloc_strdup(memctx, name);
>> + if (!realm)
>> + {
>> + return NULL;
>> + }
>
> and I'll ack :-)
>
> See
http://www.freeipa.org/page/Coding_Style#Conditions_and_Statements
> for the full guidelines.
Also these two new warnings seems to be caused by the patch:
src/providers/ipa/ipa_common.c:50:9: warning: unused variable 'i'
[-Wunused-variable]
src/providers/ad/ad_common.c:36:12: warning: unused variable 'i'
[-Wunused-variable]
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
--
Ondrej Kos
Associate Software Engineer
Identity Management
Red Hat Czech
cell: +420-736-417-909
phone: +420-532-294-558
ext.: 82-62558
irc: okos @ #brno