On Wed, Nov 06, 2013 at 10:16:58AM +0100, Sumit Bose wrote:
> On Tue, Nov 05, 2013 at 12:29:25PM +0100, Pavel Březina wrote:
>> On 11/04/2013 04:39 PM, Pavel Brezina wrote:
>>>
>>>
>>> ----- Original Message -----
>>>> From: "Sumit Bose" <sbose(a)redhat.com>
>>>> To: sssd-devel(a)lists.fedorahosted.org
>>>> Sent: Monday, November 4, 2013 3:03:04 PM
>>>> Subject: Re: [SSSD] [PATCHES] idmap: add API to free allocated SIDs
>>>>
>>>> On Mon, Nov 04, 2013 at 12:13:52PM +0100, Pavel Březina wrote:
>>>>>
https://fedorahosted.org/sssd/ticket/2133
>>>>
>>>
>>> Hi,
>>> thanks for the review.
>>>
>>>> Patches are looking good, I wonder why you did not cover binary SIDs,
>>>> i.e. *_to_bin_sid() calls?
>>>
>>> Ha, I knew I forgot something. I'll send another version that will
include binary SIDs.
>>
>> New patches are attached.
>>
>
> ACK for 1-5. I think Jakub should decide how to handle the updates of
> the version-info.
Pushed 1-5 to master.
Pavel, can you resend patch #5 without the cifs_idmap_sss.c hunk so I
can push to 1.11 as well?
Sure. See attachments.