Re: [SSSD] [PATCHES] Fixes for user lookup during PAM actions

[Sumit Bose]

On Thu, Jan 20, 2011 at 09:41:40AM -0500, Stephen Gallagher wrote:
>  -----BEGIN PGP SIGNED MESSAGE-----
>  Hash: SHA1
>  
>  On 01/19/2011 04:36 PM, Simo Sorce wrote:
>  > On Wed, 19 Jan 2011 15:59:16 -0500
>  > Stephen Gallagher <sgallagh(a)redhat.com&gt; wrote:
>  > 
>  >> -    subreq = sdap_get_initgr_send(state, state->ev,
>  >> +    subreq = sdap_get_initgr_send(state,
>  >> +                                  state->ev,
>  >>                                    state->ctx->be->domain,
>  >>                                    state->ctx->be->sysdb,
>  >> -                                  state->ctx->opts,
>  >> sdap_id_op_handle(state->op),
>  >> -                                  state->name, state->attrs);
>  >> +                                  state->ctx->opts,
>  >> +                                  sdap_id_op_handle(state->op),
>  >> +                                  state->ctx,
>  >> +                                  state->name,
>  >> +                                  state->attrs);
>  > 
>  > not a strong nack, but this could be simplified by simply passing
>  > state->ctx and then dereferencing it within the function instead of
>  > passing the structure and all its members explicitly.
>  > 
>  > Simo.
>  > 
>  
>  Thanks for the review. New patches attached.
>   
ACK

bye,
Sumit

>  
>  - -- 
>  Stephen Gallagher
>  RHCE 804006346421761
>  
>  Delivering value year after year.
>  Red Hat ranks #1 in value among software vendors.
>  http://www.redhat.com/promo/vendor/
>  -----BEGIN PGP SIGNATURE-----
>  Version: GnuPG v1.4.11 (GNU/Linux)
>  Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>  
>  iEYEARECAAYFAk04SaQACgkQeiVVYja6o6OcKgCZAexK4QgkDXgUbF+yl+lIWZN/
>  D2wAn07saLL1qWZnnq8+sbN+ocXkklTN
>  =Okny
>  -----END PGP SIGNATURE-----