URL:
https://github.com/SSSD/sssd/pull/334
Title: #334: Print a warning when enumeration is requested but disabled
lslebodn commented:
"""
Following coding style issue fixed before push:
```
diff --git a/src/confdb/confdb.c b/src/confdb/confdb.c
index 4d55b38a1..b01306ab6 100644
--- a/src/confdb/confdb.c
+++ b/src/confdb/confdb.c
@@ -1011,9 +1011,9 @@ static int confdb_get_domain_internal(struct confdb_ctx *cdb,
if (!domain->enumerate) {
DEBUG(SSSDBG_TRACE_FUNC, "No enumeration for [%s]!\n",
domain->name);
DEBUG(SSSDBG_CONF_SETTINGS,
- "Please note that when enumeration is disabled `getent "
- "passwd` does not return all users by design. See "
- "sssd.conf man page for more detailed information\n");
+ "Please note that when enumeration is disabled `getent "
+ "passwd` does not return all users by design. See "
+ "sssd.conf man page for more detailed information\n");
}
ret = confdb_get_string(cdb, tmp_ctx, CONFDB_MONITOR_CONF_ENTRY,
diff --git a/src/responder/common/cache_req/cache_req.c
b/src/responder/common/cache_req/cache_req.c
index e976a62da..abcb9cba3 100644
--- a/src/responder/common/cache_req/cache_req.c
+++ b/src/responder/common/cache_req/cache_req.c
@@ -176,12 +176,12 @@ cache_req_validate_domain_enumeration(struct cache_req *cr,
if (domain->enumerate == false) {
CACHE_REQ_DEBUG(SSSDBG_TRACE_FUNC, cr, "Domain %s does not support "
"enumeration, skipping...\n", domain->name);
- if(cr->rctx->enumeration_warn_logged == false) {
+ if (cr->rctx->enumeration_warn_logged == false) {
sss_log(SSS_LOG_NOTICE, "Enumeration requested but not
enabled\n");
CACHE_REQ_DEBUG(SSSDBG_TRACE_FUNC, cr,
"Enumeration requested but not enabled\n");
cr->rctx->enumeration_warn_logged = true;
- }
+ }
return false;
}
```
"""
See the full comment at
https://github.com/SSSD/sssd/pull/334#issuecomment-331867735