Agenda for today's call

Hi all,

I would like to discuss the following on today's call:

1. Gerrit vs. mailing list
2. mandatory unittest per patch
3. pep8
4. ??

If you have anything else you'd like to discuss, please reply to this email.

Regards,
Ayal.

On Mon, Apr 23, 2012 at 04:17:18AM -0400, Ayal Baron wrote:
>  Hi all,
>  
>  I would like to discuss the following on today's call:
>  
>  1. Gerrit vs. mailing list
>  2. mandatory unittest per patch
>  3. pep8
>  4. ?? 
4. REST API Update / Recommendations

-- 
Adam Litke <agl(a)us.ibm.com&gt;
IBM Linux Technology Center

I wonder this call is a phone call or on an IRC channel ?
On 04/23/2012 08:34 PM, Adam Litke wrote:
>  On Mon, Apr 23, 2012 at 04:17:18AM -0400, Ayal Baron wrote:
> > Hi all,
> >
> > I would like to discuss the following on today's call:
> >
> > 1. Gerrit vs. mailing list
> > 2. mandatory unittest per patch
> > 3. pep8
> > 4. ??
>  4. REST API Update / Recommendations
>

[Dan Kenigsberg]

On Mon, Apr 23, 2012 at 10:41:30PM +0800, ShaoHe Feng wrote:
>  I wonder this call is a phone call or on an IRC channel ? 
Phone call. See details in
http://www.ovirt.org/wiki/Meetings#Meeting_Time_and_Place

minutes: today's call

[Dan Kenigsberg]

On Mon, Apr 23, 2012 at 07:34:14AM -0500, Adam Litke wrote:
>  On Mon, Apr 23, 2012 at 04:17:18AM -0400, Ayal Baron wrote:
>  > Hi all,
>  > 
>  > I would like to discuss the following on today's call:
>  > 
>  > 1. Gerrit vs. mailing list 
Gerrit is an inhibiter for some contributors.
One approach to solve this improve gerrit:
- Gerrit should send the patch when it notified of a change. This may
  attract more reviewers.
- comments should be posted with their context
- pick up a patch/comment from the mailing list

Anthony finds the classic mailing list approach more comfortable. Our
development model should allow people to:
- be able to track current code development
- comment without logging in

It was suggested to move patch content into vdsm-devel; -patches list is
not a common concept. At least as long as -patches is full of
machine-generated noise, I think that this should be avoided. Currently
-devel is intended to general discussions (though we won't reject a
general discussion based on a patch).

Another approach is to relax contrinution requirement. This should not
be done causually, since if this door is opened it would be harder to
shut, and we may be stuck with two competing and mutualy confusing
development models.

We need to set a checkpoint in time to see if the first approach flied
regarding fixin


>  > 2. mandatory unittest per patch 
Adam: it's a good idea. adds complexity but leads to a better code.
People should be informed on how to add unit tests for their code.
Ok then, it's an official policy.

We need to add more complex tests, that require a running vdsm instance.

>  > 3. pep8 
Currently we have a whitelist. New code modules should be added to it.
Over time all existing modules should be added as well.

No objections for this were raised. Cool.

>  > 4. ??
>  
>  4. REST API Update / Recommendations 
Patches are ready for review. There is no objection to separate the code
into a different rpm; generating xml/json/collection templates
automatically to avoid data duplication may be a little complex at this
point (though I would prefer killing the duplication in its infancy).

Regards,
Dan.

minutes: today's call

[Dan Kenigsberg]

On Mon, Apr 23, 2012 at 05:52:13PM +0300, Dan Kenigsberg wrote:
>  On Mon, Apr 23, 2012 at 07:34:14AM -0500, Adam Litke wrote:
>  > On Mon, Apr 23, 2012 at 04:17:18AM -0400, Ayal Baron wrote:
>  > > Hi all,
>  > > 
>  > > I would like to discuss the following on today's call:
>  > > 
>  > > 1. Gerrit vs. mailing list
>  
>  Gerrit is an inhibiter for some contributors.
>  One approach to solve this improve gerrit:
>  - Gerrit should send the patch when it notified of a change. This may
>    attract more reviewers. 
I'm happy to inform that Gal has sent a patch for this to upstream
gerrit:
https://gerrit-review.googlesource.com/#/c/34861/
Add unified diff to newchange mail template.

>  - comments should be posted with their context 
and for this one, too:
https://gerrit-review.googlesource.com/#/c/34862/

>  - pick up a patch/comment from the mailing list 
I hope we can fix another annoying behaviour of gerrit: a comment to a
change set says how many inline comments are there, but it does not tell
which comments are they (hopefully with a link to the comment).


What else would we want to talk about today?
- state of Adam's REST patches review
- Hunt Xu's ifconfig patch (very wanted, blocked on a missing unit test)
- Saggi's betterPopen
- ?

minutes: today's call

[Ryan Harper]

* Dan Kenigsberg <danken(a)redhat.com&gt; [2012-05-07 05:42]:
>  On Mon, Apr 23, 2012 at 05:52:13PM +0300, Dan Kenigsberg wrote:
>  > On Mon, Apr 23, 2012 at 07:34:14AM -0500, Adam Litke wrote:
>  > > On Mon, Apr 23, 2012 at 04:17:18AM -0400, Ayal Baron wrote:
>  > > > Hi all,
>  > > > 
>  > > > I would like to discuss the following on today's call:
>  > > > 
>  > > > 1. Gerrit vs. mailing list
>  > 
>  > Gerrit is an inhibiter for some contributors.
>  > One approach to solve this improve gerrit:
>  > - Gerrit should send the patch when it notified of a change. This may
>  >   attract more reviewers.
>  
>  I'm happy to inform that Gal has sent a patch for this to upstream
>  gerrit:
>  https://gerrit-review.googlesource.com/#/c/34861/
>  Add unified diff to newchange mail template.
>   
Any eta on getting the gerrit notifications of changes to include the
full patch in the email? 

I'm definitely happy to see notification on new posts and changes; helps
me see what new activity is happening, but I'd really enjoy seeing the
the patch series attached (via threading) as well.

Thanks

>  > - comments should be posted with their context
>  
>  and for this one, too:
>  https://gerrit-review.googlesource.com/#/c/34862/
>  
>  > - pick up a patch/comment from the mailing list
>  
>  I hope we can fix another annoying behaviour of gerrit: a comment to a
>  change set says how many inline comments are there, but it does not tell
>  which comments are they (hopefully with a link to the comment).
>  
>  
>  What else would we want to talk about today?
>  - state of Adam's REST patches review
>  - Hunt Xu's ifconfig patch (very wanted, blocked on a missing unit test)
>  - Saggi's betterPopen
>  - ?
>  _______________________________________________
>  vdsm-devel mailing list
>  vdsm-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/vdsm-devel 
-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh(a)us.ibm.com

minutes: today's call

[Dan Kenigsberg]

On Wed, May 16, 2012 at 09:43:57AM -0500, Ryan Harper wrote:
>  * Dan Kenigsberg <danken(a)redhat.com&gt; [2012-05-07 05:42]:
>  > On Mon, Apr 23, 2012 at 05:52:13PM +0300, Dan Kenigsberg wrote:
>  > > On Mon, Apr 23, 2012 at 07:34:14AM -0500, Adam Litke wrote:
>  > > > On Mon, Apr 23, 2012 at 04:17:18AM -0400, Ayal Baron wrote:
>  > > > > Hi all,
>  > > > > 
>  > > > > I would like to discuss the following on today's call:
>  > > > > 
>  > > > > 1. Gerrit vs. mailing list
>  > > 
>  > > Gerrit is an inhibiter for some contributors.
>  > > One approach to solve this improve gerrit:
>  > > - Gerrit should send the patch when it notified of a change. This may
>  > >   attract more reviewers.
>  > 
>  > I'm happy to inform that Gal has sent a patch for this to upstream
>  > gerrit:
>  > https://gerrit-review.googlesource.com/#/c/34861/
>  > Add unified diff to newchange mail template.
>  > 
>  
>  Any eta on getting the gerrit notifications of changes to include the
>  full patch in the email?  
You can +1 them in googlesource, maybe it helps ;-)

>  
>  I'm definitely happy to see notification on new posts and changes; helps
>  me see what new activity is happening, but I'd really enjoy seeing the
>  the patch series attached (via threading) as well. 
Itamar, I know Red Hat hates to do it, but can we take these patches to
ovirt's gerrit before they are accepted upstream?

Regards,
Dan.

minutes: today's call

On 05/16/2012 06:11 PM, Dan Kenigsberg wrote:
>  On Wed, May 16, 2012 at 09:43:57AM -0500, Ryan Harper wrote:
> > * Dan Kenigsberg<danken(a)redhat.com>  [2012-05-07 05:42]:
> >> On Mon, Apr 23, 2012 at 05:52:13PM +0300, Dan Kenigsberg wrote:
> >>> On Mon, Apr 23, 2012 at 07:34:14AM -0500, Adam Litke wrote:
> >>>> On Mon, Apr 23, 2012 at 04:17:18AM -0400, Ayal Baron wrote:
> >>>>> Hi all,
> >>>>>
> >>>>> I would like to discuss the following on today's call:
> >>>>>
> >>>>> 1. Gerrit vs. mailing list
> >>>
> >>> Gerrit is an inhibiter for some contributors.
> >>> One approach to solve this improve gerrit:
> >>> - Gerrit should send the patch when it notified of a change. This may
> >>>    attract more reviewers.
> >>
> >> I'm happy to inform that Gal has sent a patch for this to upstream
> >> gerrit:
> >> https://gerrit-review.googlesource.com/#/c/34861/
> >> Add unified diff to newchange mail template.
> >>
> >
> > Any eta on getting the gerrit notifications of changes to include the
> > full patch in the email?
>
>  You can +1 them in googlesource, maybe it helps ;-) 
indeed, please help push them upstream...
https://gerrit-review.googlesource.com/#/c/34861/
https://gerrit-review.googlesource.com/#/c/34862/

> >
> > I'm definitely happy to see notification on new posts and changes; helps
> > me see what new activity is happening, but I'd really enjoy seeing the
> > the patch series attached (via threading) as well.
>
>  Itamar, I know Red Hat hates to do it, but can we take these patches to
>  ovirt's gerrit before they are accepted upstream? 
yes we can.
after i'll upgrade it to 2.3, which i prefer to do after i return from 
PTO in case there are some issues with the upgrade.
so ETA end of the month for clean upgrade to 2.3, then after we see all 
is ok, let's say another week to upgrade to the version with these patches.

>  Regards,
>  Dan.

minutes: today's call

[Ryan Harper]

* Itamar Heim <iheim(a)redhat.com&gt; [2012-05-16 10:26]:
>  On 05/16/2012 06:11 PM, Dan Kenigsberg wrote:
>  >On Wed, May 16, 2012 at 09:43:57AM -0500, Ryan Harper wrote:
>  >>* Dan Kenigsberg&lt;danken(a)redhat.com&gt;  [2012-05-07 05:42]:
>  >>>On Mon, Apr 23, 2012 at 05:52:13PM +0300, Dan Kenigsberg wrote:
>  >>>>On Mon, Apr 23, 2012 at 07:34:14AM -0500, Adam Litke wrote:
>  >>>>>On Mon, Apr 23, 2012 at 04:17:18AM -0400, Ayal Baron wrote:
>  >>>>>>Hi all,
>  >>>>>>
>  >>>>>>I would like to discuss the following on today's call:
>  >>>>>>
>  >>>>>>1. Gerrit vs. mailing list
>  >>>>
>  >>>>Gerrit is an inhibiter for some contributors.
>  >>>>One approach to solve this improve gerrit:
>  >>>>- Gerrit should send the patch when it notified of a change. This may
>  >>>>   attract more reviewers.
>  >>>
>  >>>I'm happy to inform that Gal has sent a patch for this to upstream
>  >>>gerrit:
>  >>>https://gerrit-review.googlesource.com/#/c/34861/
>  >>>Add unified diff to newchange mail template.
>  >>>
>  >>
>  >>Any eta on getting the gerrit notifications of changes to include the
>  >>full patch in the email?
>  >
>  >You can +1 them in googlesource, maybe it helps ;-)
>  
>  indeed, please help push them upstream...
>  https://gerrit-review.googlesource.com/#/c/34861/
>  https://gerrit-review.googlesource.com/#/c/34862/
>  
>  >
>  >>
>  >>I'm definitely happy to see notification on new posts and changes; helps
>  >>me see what new activity is happening, but I'd really enjoy seeing the
>  >>the patch series attached (via threading) as well.
>  >
>  >Itamar, I know Red Hat hates to do it, but can we take these patches to
>  >ovirt's gerrit before they are accepted upstream?
>  
>  yes we can.
>  after i'll upgrade it to 2.3, which i prefer to do after i return
>  from PTO in case there are some issues with the upgrade.
>  so ETA end of the month for clean upgrade to 2.3, then after we see
>  all is ok, let's say another week to upgrade to the version with
>  these patches. 
It's about 6 weeks later.  Dan's been asking for more review in vdsm;
I know that I'd be able to review quite a bit more if I can get patches
via email instead of the webui.

Can we get this enabled?


-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh(a)us.ibm.com

minutes: today's call

On 07/18/2012 06:24 PM, Ryan Harper wrote:
>  * Itamar Heim <iheim(a)redhat.com&gt; [2012-05-16 10:26]:
> > On 05/16/2012 06:11 PM, Dan Kenigsberg wrote:
> >> On Wed, May 16, 2012 at 09:43:57AM -0500, Ryan Harper wrote:
> >>> * Dan Kenigsberg&lt;danken(a)redhat.com&gt;  [2012-05-07 05:42]:
> >>>> On Mon, Apr 23, 2012 at 05:52:13PM +0300, Dan Kenigsberg wrote:
> >>>>> On Mon, Apr 23, 2012 at 07:34:14AM -0500, Adam Litke wrote:
> >>>>>> On Mon, Apr 23, 2012 at 04:17:18AM -0400, Ayal Baron wrote:
> >>>>>>> Hi all,
> >>>>>>>
> >>>>>>> I would like to discuss the following on today's call:
> >>>>>>>
> >>>>>>> 1. Gerrit vs. mailing list
> >>>>>
> >>>>> Gerrit is an inhibiter for some contributors.
> >>>>> One approach to solve this improve gerrit:
> >>>>> - Gerrit should send the patch when it notified of a change. This
> may
> >>>>>    attract more reviewers.
> >>>>
> >>>> I'm happy to inform that Gal has sent a patch for this to upstream
> >>>> gerrit:
> >>>> https://gerrit-review.googlesource.com/#/c/34861/
> >>>> Add unified diff to newchange mail template.
> >>>>
> >>>
> >>> Any eta on getting the gerrit notifications of changes to include the
> >>> full patch in the email?
> >>
> >> You can +1 them in googlesource, maybe it helps ;-)
> >
> > indeed, please help push them upstream...
> > https://gerrit-review.googlesource.com/#/c/34861/
> > https://gerrit-review.googlesource.com/#/c/34862/
> >
> >>
> >>>
> >>> I'm definitely happy to see notification on new posts and changes; helps
> >>> me see what new activity is happening, but I'd really enjoy seeing the
> >>> the patch series attached (via threading) as well.
> >>
> >> Itamar, I know Red Hat hates to do it, but can we take these patches to
> >> ovirt's gerrit before they are accepted upstream?
> >
> > yes we can.
> > after i'll upgrade it to 2.3, which i prefer to do after i return
> > from PTO in case there are some issues with the upgrade.
> > so ETA end of the month for clean upgrade to 2.3, then after we see
> > all is ok, let's say another week to upgrade to the version with
> > these patches.
>
>  It's about 6 weeks later.  Dan's been asking for more review in vdsm;
>  I know that I'd be able to review quite a bit more if I can get patches
>  via email instead of the webui.
>
>  Can we get this enabled?
>
>  
eyal/attila - any ETA on testing gerrit 2.4 (.2 by now) so we can 
upgrade to it?

minutes: today's call

I'm in favor on doing it next monday.
(not too healthy to do upgrades before the weekend...).

We'll need to send email to rhev-devel + qe for an estimated downtime of 1 hour for
gerrit.eng.lab.tlv.redhat.com.

Eyal.

----- Original Message -----
>  From: "Itamar Heim" <iheim(a)redhat.com&gt;
>  To: "Ryan Harper" <ryanh(a)us.ibm.com&gt;
>  Cc: "Dan Kenigsberg" <danken(a)redhat.com&gt;, "Adam Litke"
> <agl(a)us.ibm.com&gt;, "Anthony Liguori" <aliguori(a)us.ibm.com&gt;,
>  "VDSM Project Development" <vdsm-devel(a)lists.fedorahosted.org&gt;,
> "Eyal Edri" <eedri(a)redhat.com&gt;, "Attila Darazs"
>  <adarazs(a)redhat.com&gt;, "Moran Goldboim" <mgoldboi(a)redhat.com&gt;
>  Sent: Wednesday, July 18, 2012 7:48:01 PM
>  Subject: Re: [vdsm] minutes: today's call
>  
>  On 07/18/2012 06:24 PM, Ryan Harper wrote:
>  > * Itamar Heim <iheim(a)redhat.com&gt; [2012-05-16 10:26]:
>  >> On 05/16/2012 06:11 PM, Dan Kenigsberg wrote:
>  >>> On Wed, May 16, 2012 at 09:43:57AM -0500, Ryan Harper wrote:
>  >>>> * Dan Kenigsberg&lt;danken(a)redhat.com&gt;  [2012-05-07 05:42]:
>  >>>>> On Mon, Apr 23, 2012 at 05:52:13PM +0300, Dan Kenigsberg wrote:
>  >>>>>> On Mon, Apr 23, 2012 at 07:34:14AM -0500, Adam Litke wrote:
>  >>>>>>> On Mon, Apr 23, 2012 at 04:17:18AM -0400, Ayal Baron wrote:
>  >>>>>>>> Hi all,
>  >>>>>>>>
>  >>>>>>>> I would like to discuss the following on today's
> call:
>  >>>>>>>>
>  >>>>>>>> 1. Gerrit vs. mailing list
>  >>>>>>
>  >>>>>> Gerrit is an inhibiter for some contributors.
>  >>>>>> One approach to solve this improve gerrit:
>  >>>>>> - Gerrit should send the patch when it notified of a change.
>  >>>>>> This may
>  >>>>>>    attract more reviewers.
>  >>>>>
>  >>>>> I'm happy to inform that Gal has sent a patch for this to
>  >>>>> upstream
>  >>>>> gerrit:
>  >>>>> https://gerrit-review.googlesource.com/#/c/34861/
>  >>>>> Add unified diff to newchange mail template.
>  >>>>>
>  >>>>
>  >>>> Any eta on getting the gerrit notifications of changes to
>  >>>> include the
>  >>>> full patch in the email?
>  >>>
>  >>> You can +1 them in googlesource, maybe it helps ;-)
>  >>
>  >> indeed, please help push them upstream...
>  >> https://gerrit-review.googlesource.com/#/c/34861/
>  >> https://gerrit-review.googlesource.com/#/c/34862/
>  >>
>  >>>
>  >>>>
>  >>>> I'm definitely happy to see notification on new posts and
>  >>>> changes; helps
>  >>>> me see what new activity is happening, but I'd really enjoy
>  >>>> seeing the
>  >>>> the patch series attached (via threading) as well.
>  >>>
>  >>> Itamar, I know Red Hat hates to do it, but can we take these
>  >>> patches to
>  >>> ovirt's gerrit before they are accepted upstream?
>  >>
>  >> yes we can.
>  >> after i'll upgrade it to 2.3, which i prefer to do after i return
>  >> from PTO in case there are some issues with the upgrade.
>  >> so ETA end of the month for clean upgrade to 2.3, then after we
>  >> see
>  >> all is ok, let's say another week to upgrade to the version with
>  >> these patches.
>  >
>  > It's about 6 weeks later.  Dan's been asking for more review in
>  > vdsm;
>  > I know that I'd be able to review quite a bit more if I can get
>  > patches
>  > via email instead of the webui.
>  >
>  > Can we get this enabled?
>  >
>  >
>  
>  eyal/attila - any ETA on testing gerrit 2.4 (.2 by now) so we can
>  upgrade to it?
>  
>

minutes: today's call

[Ryan Harper]

* Eyal Edri <eedri(a)redhat.com&gt; [2012-07-18 11:59]:
>  I'm in favor on doing it next monday.
>  (not too healthy to do upgrades before the weekend...).
>  
>  We'll need to send email to rhev-devel + qe for an estimated downtime of 1 hour for
> gerrit.eng.lab.tlv.redhat.com.
>   
Any update?

>  Eyal.
>  
>  ----- Original Message -----
>  > From: "Itamar Heim" <iheim(a)redhat.com&gt;
>  > To: "Ryan Harper" <ryanh(a)us.ibm.com&gt;
>  > Cc: "Dan Kenigsberg" <danken(a)redhat.com&gt;, "Adam Litke"
> <agl(a)us.ibm.com&gt;, "Anthony Liguori" <aliguori(a)us.ibm.com&gt;,
>  > "VDSM Project Development" <vdsm-devel(a)lists.fedorahosted.org&gt;,
> "Eyal Edri" <eedri(a)redhat.com&gt;, "Attila Darazs"
>  > <adarazs(a)redhat.com&gt;, "Moran Goldboim" <mgoldboi(a)redhat.com&gt;
>  > Sent: Wednesday, July 18, 2012 7:48:01 PM
>  > Subject: Re: [vdsm] minutes: today's call
>  > 
>  > On 07/18/2012 06:24 PM, Ryan Harper wrote:
>  > > * Itamar Heim <iheim(a)redhat.com&gt; [2012-05-16 10:26]:
>  > >> On 05/16/2012 06:11 PM, Dan Kenigsberg wrote:
>  > >>> On Wed, May 16, 2012 at 09:43:57AM -0500, Ryan Harper wrote:
>  > >>>> * Dan Kenigsberg&lt;danken(a)redhat.com&gt;  [2012-05-07 05:42]:
>  > >>>>> On Mon, Apr 23, 2012 at 05:52:13PM +0300, Dan Kenigsberg
> wrote:
>  > >>>>>> On Mon, Apr 23, 2012 at 07:34:14AM -0500, Adam Litke
> wrote:
>  > >>>>>>> On Mon, Apr 23, 2012 at 04:17:18AM -0400, Ayal Baron
> wrote:
>  > >>>>>>>> Hi all,
>  > >>>>>>>>
>  > >>>>>>>> I would like to discuss the following on
> today's call:
>  > >>>>>>>>
>  > >>>>>>>> 1. Gerrit vs. mailing list
>  > >>>>>>
>  > >>>>>> Gerrit is an inhibiter for some contributors.
>  > >>>>>> One approach to solve this improve gerrit:
>  > >>>>>> - Gerrit should send the patch when it notified of a
> change.
>  > >>>>>> This may
>  > >>>>>>    attract more reviewers.
>  > >>>>>
>  > >>>>> I'm happy to inform that Gal has sent a patch for this to
>  > >>>>> upstream
>  > >>>>> gerrit:
>  > >>>>> https://gerrit-review.googlesource.com/#/c/34861/
>  > >>>>> Add unified diff to newchange mail template.
>  > >>>>>
>  > >>>>
>  > >>>> Any eta on getting the gerrit notifications of changes to
>  > >>>> include the
>  > >>>> full patch in the email?
>  > >>>
>  > >>> You can +1 them in googlesource, maybe it helps ;-)
>  > >>
>  > >> indeed, please help push them upstream...
>  > >> https://gerrit-review.googlesource.com/#/c/34861/
>  > >> https://gerrit-review.googlesource.com/#/c/34862/
>  > >>
>  > >>>
>  > >>>>
>  > >>>> I'm definitely happy to see notification on new posts and
>  > >>>> changes; helps
>  > >>>> me see what new activity is happening, but I'd really enjoy
>  > >>>> seeing the
>  > >>>> the patch series attached (via threading) as well.
>  > >>>
>  > >>> Itamar, I know Red Hat hates to do it, but can we take these
>  > >>> patches to
>  > >>> ovirt's gerrit before they are accepted upstream?
>  > >>
>  > >> yes we can.
>  > >> after i'll upgrade it to 2.3, which i prefer to do after i return
>  > >> from PTO in case there are some issues with the upgrade.
>  > >> so ETA end of the month for clean upgrade to 2.3, then after we
>  > >> see
>  > >> all is ok, let's say another week to upgrade to the version with
>  > >> these patches.
>  > >
>  > > It's about 6 weeks later.  Dan's been asking for more review in
>  > > vdsm;
>  > > I know that I'd be able to review quite a bit more if I can get
>  > > patches
>  > > via email instead of the webui.
>  > >
>  > > Can we get this enabled?
>  > >
>  > >
>  > 
>  > eyal/attila - any ETA on testing gerrit 2.4 (.2 by now) so we can
>  > upgrade to it?
>  > 
>  >  
-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh(a)us.ibm.com

minutes: today's call

On 07/25/2012 04:36 PM, Ryan Harper wrote:
>  * Eyal Edri <eedri(a)redhat.com&gt; [2012-07-18 11:59]:
> > I'm in favor on doing it next monday.
> > (not too healthy to do upgrades before the weekend...).
> >
> > We'll need to send email to rhev-devel + qe for an estimated downtime of 1 hour
> for gerrit.eng.lab.tlv.redhat.com.
> >
>
>  Any update? 
I've sent an update earlier today to infra that i'm planning to upgrade 
gerrit to 2.4.2 coming sunday.
after a few days of a clean upgrade, I'll do the patched version of it.

> > Eyal.
> >
> > ----- Original Message -----
> >> From: "Itamar Heim" <iheim(a)redhat.com&gt;
> >> To: "Ryan Harper" <ryanh(a)us.ibm.com&gt;
> >> Cc: "Dan Kenigsberg" <danken(a)redhat.com&gt;, "Adam Litke"
> <agl(a)us.ibm.com&gt;, "Anthony Liguori" <aliguori(a)us.ibm.com&gt;,
> >> "VDSM Project Development" <vdsm-devel(a)lists.fedorahosted.org&gt;,
> "Eyal Edri" <eedri(a)redhat.com&gt;, "Attila Darazs"
> >> <adarazs(a)redhat.com&gt;, "Moran Goldboim"
> <mgoldboi(a)redhat.com&gt;
> >> Sent: Wednesday, July 18, 2012 7:48:01 PM
> >> Subject: Re: [vdsm] minutes: today's call
> >>
> >> On 07/18/2012 06:24 PM, Ryan Harper wrote:
> >>> * Itamar Heim <iheim(a)redhat.com&gt; [2012-05-16 10:26]:
> >>>> On 05/16/2012 06:11 PM, Dan Kenigsberg wrote:
> >>>>> On Wed, May 16, 2012 at 09:43:57AM -0500, Ryan Harper wrote:
> >>>>>> * Dan Kenigsberg&lt;danken(a)redhat.com&gt;  [2012-05-07 05:42]:
> >>>>>>> On Mon, Apr 23, 2012 at 05:52:13PM +0300, Dan Kenigsberg
> wrote:
> >>>>>>>> On Mon, Apr 23, 2012 at 07:34:14AM -0500, Adam Litke
> wrote:
> >>>>>>>>> On Mon, Apr 23, 2012 at 04:17:18AM -0400, Ayal Baron
> wrote:
> >>>>>>>>>> Hi all,
> >>>>>>>>>>
> >>>>>>>>>> I would like to discuss the following on
> today's call:
> >>>>>>>>>>
> >>>>>>>>>> 1. Gerrit vs. mailing list
> >>>>>>>>
> >>>>>>>> Gerrit is an inhibiter for some contributors.
> >>>>>>>> One approach to solve this improve gerrit:
> >>>>>>>> - Gerrit should send the patch when it notified of a
> change.
> >>>>>>>> This may
> >>>>>>>>     attract more reviewers.
> >>>>>>>
> >>>>>>> I'm happy to inform that Gal has sent a patch for this
> to
> >>>>>>> upstream
> >>>>>>> gerrit:
> >>>>>>> https://gerrit-review.googlesource.com/#/c/34861/
> >>>>>>> Add unified diff to newchange mail template.
> >>>>>>>
> >>>>>>
> >>>>>> Any eta on getting the gerrit notifications of changes to
> >>>>>> include the
> >>>>>> full patch in the email?
> >>>>>
> >>>>> You can +1 them in googlesource, maybe it helps ;-)
> >>>>
> >>>> indeed, please help push them upstream...
> >>>> https://gerrit-review.googlesource.com/#/c/34861/
> >>>> https://gerrit-review.googlesource.com/#/c/34862/
> >>>>
> >>>>>
> >>>>>>
> >>>>>> I'm definitely happy to see notification on new posts and
> >>>>>> changes; helps
> >>>>>> me see what new activity is happening, but I'd really enjoy
> >>>>>> seeing the
> >>>>>> the patch series attached (via threading) as well.
> >>>>>
> >>>>> Itamar, I know Red Hat hates to do it, but can we take these
> >>>>> patches to
> >>>>> ovirt's gerrit before they are accepted upstream?
> >>>>
> >>>> yes we can.
> >>>> after i'll upgrade it to 2.3, which i prefer to do after i return
> >>>> from PTO in case there are some issues with the upgrade.
> >>>> so ETA end of the month for clean upgrade to 2.3, then after we
> >>>> see
> >>>> all is ok, let's say another week to upgrade to the version with
> >>>> these patches.
> >>>
> >>> It's about 6 weeks later.  Dan's been asking for more review in
> >>> vdsm;
> >>> I know that I'd be able to review quite a bit more if I can get
> >>> patches
> >>> via email instead of the webui.
> >>>
> >>> Can we get this enabled?
> >>>
> >>>
> >>
> >> eyal/attila - any ETA on testing gerrit 2.4 (.2 by now) so we can
> >> upgrade to it?
> >>
> >>
>

minutes: today's call

[Ryan Harper]

* Itamar Heim <iheim(a)redhat.com&gt; [2012-07-25 08:50]:
>  On 07/25/2012 04:36 PM, Ryan Harper wrote:
>  >* Eyal Edri <eedri(a)redhat.com&gt; [2012-07-18 11:59]:
>  >>I'm in favor on doing it next monday.
>  >>(not too healthy to do upgrades before the weekend...).
>  >>
>  >>We'll need to send email to rhev-devel + qe for an estimated downtime of 1
> hour for gerrit.eng.lab.tlv.redhat.com.
>  >>
>  >
>  >Any update?
>  
>  I've sent an update earlier today to infra that i'm planning to
>  upgrade gerrit to 2.4.2 coming sunday.
>  after a few days of a clean upgrade, I'll do the patched version of it. 
How'd the upgrade go?  any ETA for when the patched version will show
up?


Ryan

>  
>  >
>  >>Eyal.
>  >>
>  >>----- Original Message -----
>  >>>From: "Itamar Heim" <iheim(a)redhat.com&gt;
>  >>>To: "Ryan Harper" <ryanh(a)us.ibm.com&gt;
>  >>>Cc: "Dan Kenigsberg" <danken(a)redhat.com&gt;, "Adam
> Litke" <agl(a)us.ibm.com&gt;, "Anthony Liguori"
> <aliguori(a)us.ibm.com&gt;,
>  >>>"VDSM Project Development"
> <vdsm-devel(a)lists.fedorahosted.org&gt;, "Eyal Edri" <eedri(a)redhat.com&gt;,
> "Attila Darazs"
>  &gt;&gt;&gt;&lt;adarazs(a)redhat.com&gt;, "Moran Goldboim"
> <mgoldboi(a)redhat.com&gt;
>  >>>Sent: Wednesday, July 18, 2012 7:48:01 PM
>  >>>Subject: Re: [vdsm] minutes: today's call
>  >>>
>  >>>On 07/18/2012 06:24 PM, Ryan Harper wrote:
>  >>>>* Itamar Heim <iheim(a)redhat.com&gt; [2012-05-16 10:26]:
>  >>>>>On 05/16/2012 06:11 PM, Dan Kenigsberg wrote:
>  >>>>>>On Wed, May 16, 2012 at 09:43:57AM -0500, Ryan Harper wrote:
>  >>>>>>>* Dan Kenigsberg&lt;danken(a)redhat.com&gt;  [2012-05-07
> 05:42]:
>  >>>>>>>>On Mon, Apr 23, 2012 at 05:52:13PM +0300, Dan Kenigsberg
> wrote:
>  >>>>>>>>>On Mon, Apr 23, 2012 at 07:34:14AM -0500, Adam Litke
> wrote:
>  >>>>>>>>>>On Mon, Apr 23, 2012 at 04:17:18AM -0400, Ayal
> Baron wrote:
>  >>>>>>>>>>>Hi all,
>  >>>>>>>>>>>
>  >>>>>>>>>>>I would like to discuss the following on
> today's call:
>  >>>>>>>>>>>
>  >>>>>>>>>>>1. Gerrit vs. mailing list
>  >>>>>>>>>
>  >>>>>>>>>Gerrit is an inhibiter for some contributors.
>  >>>>>>>>>One approach to solve this improve gerrit:
>  >>>>>>>>>- Gerrit should send the patch when it notified of a
> change.
>  >>>>>>>>>This may
>  >>>>>>>>>    attract more reviewers.
>  >>>>>>>>
>  >>>>>>>>I'm happy to inform that Gal has sent a patch for
> this to
>  >>>>>>>>upstream
>  >>>>>>>>gerrit:
>  >>>>>>>>https://gerrit-review.googlesource.com/#/c/34861/
>  >>>>>>>>Add unified diff to newchange mail template.
>  >>>>>>>>
>  >>>>>>>
>  >>>>>>>Any eta on getting the gerrit notifications of changes to
>  >>>>>>>include the
>  >>>>>>>full patch in the email?
>  >>>>>>
>  >>>>>>You can +1 them in googlesource, maybe it helps ;-)
>  >>>>>
>  >>>>>indeed, please help push them upstream...
>  >>>>>https://gerrit-review.googlesource.com/#/c/34861/
>  >>>>>https://gerrit-review.googlesource.com/#/c/34862/
>  >>>>>
>  >>>>>>
>  >>>>>>>
>  >>>>>>>I'm definitely happy to see notification on new posts
> and
>  >>>>>>>changes; helps
>  >>>>>>>me see what new activity is happening, but I'd really
> enjoy
>  >>>>>>>seeing the
>  >>>>>>>the patch series attached (via threading) as well.
>  >>>>>>
>  >>>>>>Itamar, I know Red Hat hates to do it, but can we take these
>  >>>>>>patches to
>  >>>>>>ovirt's gerrit before they are accepted upstream?
>  >>>>>
>  >>>>>yes we can.
>  >>>>>after i'll upgrade it to 2.3, which i prefer to do after i
> return
>  >>>>>from PTO in case there are some issues with the upgrade.
>  >>>>>so ETA end of the month for clean upgrade to 2.3, then after we
>  >>>>>see
>  >>>>>all is ok, let's say another week to upgrade to the version with
>  >>>>>these patches.
>  >>>>
>  >>>>It's about 6 weeks later.  Dan's been asking for more review in
>  >>>>vdsm;
>  >>>>I know that I'd be able to review quite a bit more if I can get
>  >>>>patches
>  >>>>via email instead of the webui.
>  >>>>
>  >>>>Can we get this enabled?
>  >>>>
>  >>>>
>  >>>
>  >>>eyal/attila - any ETA on testing gerrit 2.4 (.2 by now) so we can
>  >>>upgrade to it?
>  >>>
>  >>>
>  >
>   
-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh(a)us.ibm.com

minutes: today's call

On 08/01/2012 04:20 PM, Ryan Harper wrote:
>  * Itamar Heim <iheim(a)redhat.com&gt; [2012-07-25 08:50]:
> > On 07/25/2012 04:36 PM, Ryan Harper wrote:
> >> * Eyal Edri <eedri(a)redhat.com&gt; [2012-07-18 11:59]:
> >>> I'm in favor on doing it next monday.
> >>> (not too healthy to do upgrades before the weekend...).
> >>>
> >>> We'll need to send email to rhev-devel + qe for an estimated downtime of
> 1 hour for gerrit.eng.lab.tlv.redhat.com.
> >>>
> >>
> >> Any update?
> >
> > I've sent an update earlier today to infra that i'm planning to
> > upgrade gerrit to 2.4.2 coming sunday.
> > after a few days of a clean upgrade, I'll do the patched version of it.
>
>  How'd the upgrade go?  any ETA for when the patched version will show
>  up? 
too early to say - gerrit already required a restart today after hanging.
Gal already created a patched version for me to deploy, but i want to 
see the gerrit behavior for a few more days before i apply it.
(btw, i think gerrit 2.5 has some improvements over the original patches 
(like max size, etc.), but we'll wait with them for 2.5 i guess.


>  Ryan
>
> >
> >>
> >>> Eyal.
> >>>
> >>> ----- Original Message -----
> >>>> From: "Itamar Heim" <iheim(a)redhat.com&gt;
> >>>> To: "Ryan Harper" <ryanh(a)us.ibm.com&gt;
> >>>> Cc: "Dan Kenigsberg" <danken(a)redhat.com&gt;, "Adam
> Litke" <agl(a)us.ibm.com&gt;, "Anthony Liguori"
> <aliguori(a)us.ibm.com&gt;,
> >>>> "VDSM Project Development"
> <vdsm-devel(a)lists.fedorahosted.org&gt;, "Eyal Edri" <eedri(a)redhat.com&gt;,
> "Attila Darazs"
> >>>> <adarazs(a)redhat.com&gt;, "Moran Goldboim"
> <mgoldboi(a)redhat.com&gt;
> >>>> Sent: Wednesday, July 18, 2012 7:48:01 PM
> >>>> Subject: Re: [vdsm] minutes: today's call
> >>>>
> >>>> On 07/18/2012 06:24 PM, Ryan Harper wrote:
> >>>>> * Itamar Heim <iheim(a)redhat.com&gt; [2012-05-16 10:26]:
> >>>>>> On 05/16/2012 06:11 PM, Dan Kenigsberg wrote:
> >>>>>>> On Wed, May 16, 2012 at 09:43:57AM -0500, Ryan Harper wrote:
> >>>>>>>> * Dan Kenigsberg&lt;danken(a)redhat.com&gt;  [2012-05-07
> 05:42]:
> >>>>>>>>> On Mon, Apr 23, 2012 at 05:52:13PM +0300, Dan
> Kenigsberg wrote:
> >>>>>>>>>> On Mon, Apr 23, 2012 at 07:34:14AM -0500, Adam
> Litke wrote:
> >>>>>>>>>>> On Mon, Apr 23, 2012 at 04:17:18AM -0400,
> Ayal Baron wrote:
> >>>>>>>>>>>> Hi all,
> >>>>>>>>>>>>
> >>>>>>>>>>>> I would like to discuss the following on
> today's call:
> >>>>>>>>>>>>
> >>>>>>>>>>>> 1. Gerrit vs. mailing list
> >>>>>>>>>>
> >>>>>>>>>> Gerrit is an inhibiter for some contributors.
> >>>>>>>>>> One approach to solve this improve gerrit:
> >>>>>>>>>> - Gerrit should send the patch when it notified
> of a change.
> >>>>>>>>>> This may
> >>>>>>>>>>     attract more reviewers.
> >>>>>>>>>
> >>>>>>>>> I'm happy to inform that Gal has sent a patch for
> this to
> >>>>>>>>> upstream
> >>>>>>>>> gerrit:
> >>>>>>>>> https://gerrit-review.googlesource.com/#/c/34861/
> >>>>>>>>> Add unified diff to newchange mail template.
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>> Any eta on getting the gerrit notifications of changes
> to
> >>>>>>>> include the
> >>>>>>>> full patch in the email?
> >>>>>>>
> >>>>>>> You can +1 them in googlesource, maybe it helps ;-)
> >>>>>>
> >>>>>> indeed, please help push them upstream...
> >>>>>> https://gerrit-review.googlesource.com/#/c/34861/
> >>>>>> https://gerrit-review.googlesource.com/#/c/34862/
> >>>>>>
> >>>>>>>
> >>>>>>>>
> >>>>>>>> I'm definitely happy to see notification on new posts
> and
> >>>>>>>> changes; helps
> >>>>>>>> me see what new activity is happening, but I'd really
> enjoy
> >>>>>>>> seeing the
> >>>>>>>> the patch series attached (via threading) as well.
> >>>>>>>
> >>>>>>> Itamar, I know Red Hat hates to do it, but can we take these
> >>>>>>> patches to
> >>>>>>> ovirt's gerrit before they are accepted upstream?
> >>>>>>
> >>>>>> yes we can.
> >>>>>> after i'll upgrade it to 2.3, which i prefer to do after i
> return
> >>>>> >from PTO in case there are some issues with the upgrade.
> >>>>>> so ETA end of the month for clean upgrade to 2.3, then after we
> >>>>>> see
> >>>>>> all is ok, let's say another week to upgrade to the version
> with
> >>>>>> these patches.
> >>>>>
> >>>>> It's about 6 weeks later.  Dan's been asking for more review
> in
> >>>>> vdsm;
> >>>>> I know that I'd be able to review quite a bit more if I can get
> >>>>> patches
> >>>>> via email instead of the webui.
> >>>>>
> >>>>> Can we get this enabled?
> >>>>>
> >>>>>
> >>>>
> >>>> eyal/attila - any ETA on testing gerrit 2.4 (.2 by now) so we can
> >>>> upgrade to it?
> >>>>
> >>>>
> >>
> >
>

minutes: today's call

[Ryan Harper]

* Itamar Heim <iheim(a)redhat.com&gt; [2012-08-01 08:27]:
>  On 08/01/2012 04:20 PM, Ryan Harper wrote:
>  >* Itamar Heim <iheim(a)redhat.com&gt; [2012-07-25 08:50]:
>  >>On 07/25/2012 04:36 PM, Ryan Harper wrote:
>  >>>* Eyal Edri <eedri(a)redhat.com&gt; [2012-07-18 11:59]:
>  >>>>I'm in favor on doing it next monday.
>  >>>>(not too healthy to do upgrades before the weekend...).
>  >>>>
>  >>>>We'll need to send email to rhev-devel + qe for an estimated downtime
> of 1 hour for gerrit.eng.lab.tlv.redhat.com.
>  >>>>
>  >>>
>  >>>Any update?
>  >>
>  >>I've sent an update earlier today to infra that i'm planning to
>  >>upgrade gerrit to 2.4.2 coming sunday.
>  >>after a few days of a clean upgrade, I'll do the patched version of it.
>  >
>  >How'd the upgrade go?  any ETA for when the patched version will show
>  >up?
>  
>  too early to say - gerrit already required a restart today after hanging.
>  Gal already created a patched version for me to deploy, but i want
>  to see the gerrit behavior for a few more days before i apply it.
>  (btw, i think gerrit 2.5 has some improvements over the original
>  patches (like max size, etc.), but we'll wait with them for 2.5 i
>  guess. 
How's gerrit behaving?  Ready for the patched version?

Thanks!

Ryan



>  
>  
>  >
>  >
>  >Ryan
>  >
>  >>
>  >>>
>  >>>>Eyal.
>  >>>>
>  >>>>----- Original Message -----
>  >>>>>From: "Itamar Heim" <iheim(a)redhat.com&gt;
>  >>>>>To: "Ryan Harper" <ryanh(a)us.ibm.com&gt;
>  >>>>>Cc: "Dan Kenigsberg" <danken(a)redhat.com&gt;, "Adam
> Litke" <agl(a)us.ibm.com&gt;, "Anthony Liguori"
> <aliguori(a)us.ibm.com&gt;,
>  >>>>>"VDSM Project Development"
> <vdsm-devel(a)lists.fedorahosted.org&gt;, "Eyal Edri" <eedri(a)redhat.com&gt;,
> "Attila Darazs"
>  &gt;&gt;&gt;&gt;&gt;&lt;adarazs(a)redhat.com&gt;, "Moran Goldboim"
> <mgoldboi(a)redhat.com&gt;
>  >>>>>Sent: Wednesday, July 18, 2012 7:48:01 PM
>  >>>>>Subject: Re: [vdsm] minutes: today's call
>  >>>>>
>  >>>>>On 07/18/2012 06:24 PM, Ryan Harper wrote:
>  >>>>>>* Itamar Heim <iheim(a)redhat.com&gt; [2012-05-16 10:26]:
>  >>>>>>>On 05/16/2012 06:11 PM, Dan Kenigsberg wrote:
>  >>>>>>>>On Wed, May 16, 2012 at 09:43:57AM -0500, Ryan Harper
> wrote:
>  >>>>>>>>>* Dan Kenigsberg&lt;danken(a)redhat.com&gt; 
> [2012-05-07 05:42]:
>  >>>>>>>>>>On Mon, Apr 23, 2012 at 05:52:13PM +0300, Dan
> Kenigsberg wrote:
>  >>>>>>>>>>>On Mon, Apr 23, 2012 at 07:34:14AM -0500,
> Adam Litke wrote:
>  >>>>>>>>>>>>On Mon, Apr 23, 2012 at 04:17:18AM -0400,
> Ayal Baron wrote:
>  >>>>>>>>>>>>>Hi all,
>  >>>>>>>>>>>>>
>  >>>>>>>>>>>>>I would like to discuss the following
> on today's call:
>  >>>>>>>>>>>>>
>  >>>>>>>>>>>>>1. Gerrit vs. mailing list
>  >>>>>>>>>>>
>  >>>>>>>>>>>Gerrit is an inhibiter for some
> contributors.
>  >>>>>>>>>>>One approach to solve this improve gerrit:
>  >>>>>>>>>>>- Gerrit should send the patch when it
> notified of a change.
>  >>>>>>>>>>>This may
>  >>>>>>>>>>>    attract more reviewers.
>  >>>>>>>>>>
>  >>>>>>>>>>I'm happy to inform that Gal has sent a patch
> for this to
>  >>>>>>>>>>upstream
>  >>>>>>>>>>gerrit:
>
> >>>>>>>>>>https://gerrit-review.googlesource.com/#/c/34861/
>  >>>>>>>>>>Add unified diff to newchange mail template.
>  >>>>>>>>>>
>  >>>>>>>>>
>  >>>>>>>>>Any eta on getting the gerrit notifications of
> changes to
>  >>>>>>>>>include the
>  >>>>>>>>>full patch in the email?
>  >>>>>>>>
>  >>>>>>>>You can +1 them in googlesource, maybe it helps ;-)
>  >>>>>>>
>  >>>>>>>indeed, please help push them upstream...
>  >>>>>>>https://gerrit-review.googlesource.com/#/c/34861/
>  >>>>>>>https://gerrit-review.googlesource.com/#/c/34862/
>  >>>>>>>
>  >>>>>>>>
>  >>>>>>>>>
>  >>>>>>>>>I'm definitely happy to see notification on new
> posts and
>  >>>>>>>>>changes; helps
>  >>>>>>>>>me see what new activity is happening, but I'd
> really enjoy
>  >>>>>>>>>seeing the
>  >>>>>>>>>the patch series attached (via threading) as well.
>  >>>>>>>>
>  >>>>>>>>Itamar, I know Red Hat hates to do it, but can we take
> these
>  >>>>>>>>patches to
>  >>>>>>>>ovirt's gerrit before they are accepted upstream?
>  >>>>>>>
>  >>>>>>>yes we can.
>  >>>>>>>after i'll upgrade it to 2.3, which i prefer to do after
> i return
>  >>>>>>>from PTO in case there are some issues with the upgrade.
>  >>>>>>>so ETA end of the month for clean upgrade to 2.3, then after
> we
>  >>>>>>>see
>  >>>>>>>all is ok, let's say another week to upgrade to the
> version with
>  >>>>>>>these patches.
>  >>>>>>
>  >>>>>>It's about 6 weeks later.  Dan's been asking for more
> review in
>  >>>>>>vdsm;
>  >>>>>>I know that I'd be able to review quite a bit more if I can
> get
>  >>>>>>patches
>  >>>>>>via email instead of the webui.
>  >>>>>>
>  >>>>>>Can we get this enabled?
>  >>>>>>
>  >>>>>>
>  >>>>>
>  >>>>>eyal/attila - any ETA on testing gerrit 2.4 (.2 by now) so we can
>  >>>>>upgrade to it?
>  >>>>>
>  >>>>>
>  >>>
>  >>
>  >
>   
-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh(a)us.ibm.com

minutes: today's call

[Ryan Harper]

* Ryan Harper <ryanh(a)us.ibm.com&gt; [2012-08-08 09:38]:
>  * Itamar Heim <iheim(a)redhat.com&gt; [2012-08-01 08:27]:
>  > On 08/01/2012 04:20 PM, Ryan Harper wrote:
>  > >* Itamar Heim <iheim(a)redhat.com&gt; [2012-07-25 08:50]:
>  > >>On 07/25/2012 04:36 PM, Ryan Harper wrote:
>  > >>>* Eyal Edri <eedri(a)redhat.com&gt; [2012-07-18 11:59]:
>  > >>>>I'm in favor on doing it next monday.
>  > >>>>(not too healthy to do upgrades before the weekend...).
>  > >>>>
>  > >>>>We'll need to send email to rhev-devel + qe for an estimated
> downtime of 1 hour for gerrit.eng.lab.tlv.redhat.com.
>  > >>>>
>  > >>>
>  > >>>Any update?
>  > >>
>  > >>I've sent an update earlier today to infra that i'm planning to
>  > >>upgrade gerrit to 2.4.2 coming sunday.
>  > >>after a few days of a clean upgrade, I'll do the patched version of it.
>  > >
>  > >How'd the upgrade go?  any ETA for when the patched version will show
>  > >up?
>  > 
>  > too early to say - gerrit already required a restart today after hanging.
>  > Gal already created a patched version for me to deploy, but i want
>  > to see the gerrit behavior for a few more days before i apply it.
>  > (btw, i think gerrit 2.5 has some improvements over the original
>  > patches (like max size, etc.), but we'll wait with them for 2.5 i
>  > guess.
>  
>  How's gerrit behaving?  Ready for the patched version? 
Any update?

-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh(a)us.ibm.com

minutes: today's call

On 08/15/2012 04:13 PM, Ryan Harper wrote:
>  * Ryan Harper <ryanh(a)us.ibm.com&gt; [2012-08-08 09:38]:
> > * Itamar Heim <iheim(a)redhat.com&gt; [2012-08-01 08:27]:
> >> On 08/01/2012 04:20 PM, Ryan Harper wrote:
> >>> * Itamar Heim <iheim(a)redhat.com&gt; [2012-07-25 08:50]:
> >>>> On 07/25/2012 04:36 PM, Ryan Harper wrote:
> >>>>> * Eyal Edri <eedri(a)redhat.com&gt; [2012-07-18 11:59]:
> >>>>>> I'm in favor on doing it next monday.
> >>>>>> (not too healthy to do upgrades before the weekend...).
> >>>>>>
> >>>>>> We'll need to send email to rhev-devel + qe for an estimated
> downtime of 1 hour for gerrit.eng.lab.tlv.redhat.com.
> >>>>>>
> >>>>>
> >>>>> Any update?
> >>>>
> >>>> I've sent an update earlier today to infra that i'm planning to
> >>>> upgrade gerrit to 2.4.2 coming sunday.
> >>>> after a few days of a clean upgrade, I'll do the patched version of
> it.
> >>>
> >>> How'd the upgrade go?  any ETA for when the patched version will show
> >>> up?
> >>
> >> too early to say - gerrit already required a restart today after hanging.
> >> Gal already created a patched version for me to deploy, but i want
> >> to see the gerrit behavior for a few more days before i apply it.
> >> (btw, i think gerrit 2.5 has some improvements over the original
> >> patches (like max size, etc.), but we'll wait with them for 2.5 i
> >> guess.
> >
> > How's gerrit behaving?  Ready for the patched version?
>
>  Any update?
>  
done?
http://lists.ovirt.org/pipermail/infra/2012-August/000828.html

minutes: today's call

[Ryan Harper]

* Itamar Heim <iheim(a)redhat.com&gt; [2012-08-15 08:15]:
>  On 08/15/2012 04:13 PM, Ryan Harper wrote:
>  >* Ryan Harper <ryanh(a)us.ibm.com&gt; [2012-08-08 09:38]:
>  >>* Itamar Heim <iheim(a)redhat.com&gt; [2012-08-01 08:27]:
>  >>>On 08/01/2012 04:20 PM, Ryan Harper wrote:
>  >>>>* Itamar Heim <iheim(a)redhat.com&gt; [2012-07-25 08:50]:
>  >>>>>On 07/25/2012 04:36 PM, Ryan Harper wrote:
>  >>>>>>* Eyal Edri <eedri(a)redhat.com&gt; [2012-07-18 11:59]:
>  >>>>>>>I'm in favor on doing it next monday.
>  >>>>>>>(not too healthy to do upgrades before the weekend...).
>  >>>>>>>
>  >>>>>>>We'll need to send email to rhev-devel + qe for an
> estimated downtime of 1 hour for gerrit.eng.lab.tlv.redhat.com.
>  >>>>>>>
>  >>>>>>
>  >>>>>>Any update?
>  >>>>>
>  >>>>>I've sent an update earlier today to infra that i'm planning
> to
>  >>>>>upgrade gerrit to 2.4.2 coming sunday.
>  >>>>>after a few days of a clean upgrade, I'll do the patched version
> of it.
>  >>>>
>  >>>>How'd the upgrade go?  any ETA for when the patched version will
> show
>  >>>>up?
>  >>>
>  >>>too early to say - gerrit already required a restart today after hanging.
>  >>>Gal already created a patched version for me to deploy, but i want
>  >>>to see the gerrit behavior for a few more days before i apply it.
>  >>>(btw, i think gerrit 2.5 has some improvements over the original
>  >>>patches (like max size, etc.), but we'll wait with them for 2.5 i
>  >>>guess.
>  >>
>  >>How's gerrit behaving?  Ready for the patched version?
>  >
>  >Any update?
>  >
>  
>  done?
>  http://lists.ovirt.org/pipermail/infra/2012-August/000828.html 
The one morning I don't look at my gerrit email and indeed it is.
Thanks for getting this working!


Did we look at getting replies to the emails showing up as comments?


-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh(a)us.ibm.com

minutes: today's call

On 08/15/2012 04:21 PM, Ryan Harper wrote:
>  * Itamar Heim <iheim(a)redhat.com&gt; [2012-08-15 08:15]:
> > On 08/15/2012 04:13 PM, Ryan Harper wrote:
> >> * Ryan Harper <ryanh(a)us.ibm.com&gt; [2012-08-08 09:38]:
> >>> * Itamar Heim <iheim(a)redhat.com&gt; [2012-08-01 08:27]:
> >>>> On 08/01/2012 04:20 PM, Ryan Harper wrote:
> >>>>> * Itamar Heim <iheim(a)redhat.com&gt; [2012-07-25 08:50]:
> >>>>>> On 07/25/2012 04:36 PM, Ryan Harper wrote:
> >>>>>>> * Eyal Edri <eedri(a)redhat.com&gt; [2012-07-18 11:59]:
> >>>>>>>> I'm in favor on doing it next monday.
> >>>>>>>> (not too healthy to do upgrades before the weekend...).
> >>>>>>>>
> >>>>>>>> We'll need to send email to rhev-devel + qe for an
> estimated downtime of 1 hour for gerrit.eng.lab.tlv.redhat.com.
> >>>>>>>>
> >>>>>>>
> >>>>>>> Any update?
> >>>>>>
> >>>>>> I've sent an update earlier today to infra that i'm
> planning to
> >>>>>> upgrade gerrit to 2.4.2 coming sunday.
> >>>>>> after a few days of a clean upgrade, I'll do the patched
> version of it.
> >>>>>
> >>>>> How'd the upgrade go?  any ETA for when the patched version will
> show
> >>>>> up?
> >>>>
> >>>> too early to say - gerrit already required a restart today after
> hanging.
> >>>> Gal already created a patched version for me to deploy, but i want
> >>>> to see the gerrit behavior for a few more days before i apply it.
> >>>> (btw, i think gerrit 2.5 has some improvements over the original
> >>>> patches (like max size, etc.), but we'll wait with them for 2.5 i
> >>>> guess.
> >>>
> >>> How's gerrit behaving?  Ready for the patched version?
> >>
> >> Any update?
> >>
> >
> > done?
> > http://lists.ovirt.org/pipermail/infra/2012-August/000828.html
>
>  The one morning I don't look at my gerrit email and indeed it is.
>  Thanks for getting this working!
>
>
>  Did we look at getting replies to the emails showing up as comments?
>
>  
not yet. much more complex and no cycles for this right now.

a problem with pepe8

a comment exceed 80 characters,  and it is a url link.
such as
# 
http://aaaaaaaaaaaa/bbbbbbbbbbbbbb/cccccccccccc/dddddddddddd/eeeeeeeeeeee...

how can I do?
is this OK?
# "http:/aaaaaaaaaaaa/bbbbbbbbbbbbbb/cccccccccccc/
# dddddddddddd/eeeeeeeeeeeeeee/fffffffffffffffffff/"
# (the link is too long to fit in one line, copy it and paste it to one 
line)

a problem with pepe8

On Fri, May 18, 2012 at 03:56:05PM +0800, ShaoHe Feng wrote:
>  a comment exceed 80 characters,  and it is a url link.
>  such as
>  #
> http://aaaaaaaaaaaa/bbbbbbbbbbbbbb/cccccccccccc/dddddddddddd/eeeeeeeeeeee...
>  
>  how can I do?
>  is this OK?
>  # "http:/aaaaaaaaaaaa/bbbbbbbbbbbbbb/cccccccccccc/
>  # dddddddddddd/eeeeeeeeeeeeeee/fffffffffffffffffff/"
>  # (the link is too long to fit in one line, copy it and paste it to
>  one line) 
It would be nice if we could annotate the source code to disable certain checks
in places such as this.  Clearly the rigid line length restriction would result
in a less readable comment if followed here.

-- 
Adam Litke <agl(a)us.ibm.com&gt;
IBM Linux Technology Center

a problem with pepe8

[Dan Kenigsberg]

On Fri, May 18, 2012 at 06:57:10AM -0500, Adam Litke wrote:
>  On Fri, May 18, 2012 at 03:56:05PM +0800, ShaoHe Feng wrote:
>  > a comment exceed 80 characters,  and it is a url link.
>  > such as
>  > #
> http://aaaaaaaaaaaa/bbbbbbbbbbbbbb/cccccccccccc/dddddddddddd/eeeeeeeeeeee...
>  > 
>  > how can I do?
>  > is this OK?
>  > # "http:/aaaaaaaaaaaa/bbbbbbbbbbbbbb/cccccccccccc/
>  > # dddddddddddd/eeeeeeeeeeeeeee/fffffffffffffffffff/"
>  > # (the link is too long to fit in one line, copy it and paste it to
>  > one line)
>  
>  It would be nice if we could annotate the source code to disable certain checks
>  in places such as this.  Clearly the rigid line length restriction would result
>  in a less readable comment if followed here. 
Agreed. PEP-0008 is here to help us. If the script that enforces it is
actually hurts readability in a certain case, we should not use it.

Please fix other PEP-0008 issues in the file, and try to filter out the
url warning. If impossible, the module would not be whitelisted.

a problem with pepe8

On 05/18/2012 08:30 PM, Dan Kenigsberg wrote:
>  On Fri, May 18, 2012 at 06:57:10AM -0500, Adam Litke wrote:
> > On Fri, May 18, 2012 at 03:56:05PM +0800, ShaoHe Feng wrote:
> >> a comment exceed 80 characters,  and it is a url link.
> >> such as
> >> #
> http://aaaaaaaaaaaa/bbbbbbbbbbbbbb/cccccccccccc/dddddddddddd/eeeeeeeeeeee...
> >>
> >> how can I do?
> >> is this OK?
> >> # "http:/aaaaaaaaaaaa/bbbbbbbbbbbbbb/cccccccccccc/
> >> # dddddddddddd/eeeeeeeeeeeeeee/fffffffffffffffffff/"
> >> # (the link is too long to fit in one line, copy it and paste it to
> >> one line)
> > It would be nice if we could annotate the source code to disable certain checks
> > in places such as this.  Clearly the rigid line length restriction would result
> > in a less readable comment if followed here.
>  Agreed. PEP-0008 is here to help us. If the script that enforces it is
>  actually hurts readability in a certain case, we should not use it.
>
>  Please fix other PEP-0008 issues in the file, and try to filter out the
>  url warning. If impossible, the module would not be whitelisted.
>  
yes, pep8 has a option "--ignore=errors", but if this option is given 
when all the same type errors will be ignored.

a problem with pepe8

[Dan Kenigsberg]

On Fri, May 18, 2012 at 09:47:43PM +0800, ShaoHe Feng wrote:
>  On 05/18/2012 08:30 PM, Dan Kenigsberg wrote:
>  >On Fri, May 18, 2012 at 06:57:10AM -0500, Adam Litke wrote:
>  >>On Fri, May 18, 2012 at 03:56:05PM +0800, ShaoHe Feng wrote:
>  >>>a comment exceed 80 characters,  and it is a url link.
>  >>>such as
>  >>>#
> http://aaaaaaaaaaaa/bbbbbbbbbbbbbb/cccccccccccc/dddddddddddd/eeeeeeeeeeee...
>  >>>
>  >>>how can I do?
>  >>>is this OK?
>  >>># "http:/aaaaaaaaaaaa/bbbbbbbbbbbbbb/cccccccccccc/
>  >>># dddddddddddd/eeeeeeeeeeeeeee/fffffffffffffffffff/"
>  >>># (the link is too long to fit in one line, copy it and paste it to
>  >>>one line)
>  >>It would be nice if we could annotate the source code to disable certain checks
>  >>in places such as this.  Clearly the rigid line length restriction would result
>  >>in a less readable comment if followed here.
>  >Agreed. PEP-0008 is here to help us. If the script that enforces it is
>  >actually hurts readability in a certain case, we should not use it.
>  >
>  >Please fix other PEP-0008 issues in the file, and try to filter out the
>  >url warning. If impossible, the module would not be whitelisted.
>  >
>  yes, pep8 has a option "--ignore=errors", but if this option is
>  given when all the same type errors will be ignored. 
Hey, it is opensource. You can hack it to ignore specific error (and
push upstream, and wait until it's in Fedora), or you can `grep -v` its
output.
can grep the output
>  
>

a problem with pepe8

On 05/18/2012 09:58 PM, Dan Kenigsberg wrote:
>  On Fri, May 18, 2012 at 09:47:43PM +0800, ShaoHe Feng wrote:
> > On 05/18/2012 08:30 PM, Dan Kenigsberg wrote:
> >> On Fri, May 18, 2012 at 06:57:10AM -0500, Adam Litke wrote:
> >>> On Fri, May 18, 2012 at 03:56:05PM +0800, ShaoHe Feng wrote:
> >>>> a comment exceed 80 characters,  and it is a url link.
> >>>> such as
> >>>> #
> http://aaaaaaaaaaaa/bbbbbbbbbbbbbb/cccccccccccc/dddddddddddd/eeeeeeeeeeee...
> >>
> > > 
> >>>> how can I do?
> >>>> is this OK?
> >>>> # "http:/aaaaaaaaaaaa/bbbbbbbbbbbbbb/cccccccccccc/
> >>>> # dddddddddddd/eeeeeeeeeeeeeee/fffffffffffffffffff/"
> >>>> # (the link is too long to fit in one line, copy it and paste it to
> >>>> one line)
> >>> It would be nice if we could annotate the source code to disable certain
> checks
> >>> in places such as this.  Clearly the rigid line length restriction would
> result
> >>> in a less readable comment if followed here.
> >> Agreed. PEP-0008 is here to help us. If the script that enforces it is
> >> actually hurts readability in a certain case, we should not use it.
> > > 
> >> Please fix other PEP-0008 issues in the file, and
> try to filter out the
> >> url warning. If impossible, the module would not be whitelisted.
> > > 
> > yes, pep8 has a option "--ignore=errors",
> but if this option is
> > given when all the same type errors will be ignored.
>  Hey, it is opensource. You can hack it to ignore specific error (and
>  push upstream, and wait until it's in Fedora), or you can `grep -v` its
>  output.
>  can grep the output 
thank you.  a good way.
grep -v -e "\s*#\s\+http:"  to ignore url that is too long
> >