vdsm-patches September 2014

vdsm-patches@lists.fedorahosted.org

47 participants
582 discussions

Change in vdsm[master]: getVMFullList fails when processing externally managed vms
by Jenkins CI RO 01 Sep '14

01 Sep '14

oVirt Jenkins CI Server has posted comments on this change. Change subject: getVMFullList fails when processing externally managed vms ...................................................................... Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11250/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12192/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12039/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia728691880771388b6179e85a97df3f303aeddf8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[master]: tool: remove unused NotRootError.
by mtayer＠redhat.com 01 Sep '14

01 Sep '14

mooli tayer has uploaded a new change for review. Change subject: tool: remove unused NotRootError. ...................................................................... tool: remove unused NotRootError. Change-Id: I8e86dd38e3a871d55ffc5cb67d5f4596ec4dc3a6 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M lib/vdsm/tool/configurators/libvirt.py M lib/vdsm/tool/configurators/sanlock.py 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/32256/1 diff --git a/lib/vdsm/tool/configurators/libvirt.py b/lib/vdsm/tool/configurators/libvirt.py index 0f88b32..1b7556b 100644 --- a/lib/vdsm/tool/configurators/libvirt.py +++ b/lib/vdsm/tool/configurators/libvirt.py @@ -27,7 +27,6 @@ from vdsm.config import config from .. import \ - NotRootError, \ service, \ validate_ovirt_certs from . import \ diff --git a/lib/vdsm/tool/configurators/sanlock.py b/lib/vdsm/tool/configurators/sanlock.py index 0c847a3..1c2b3dd 100644 --- a/lib/vdsm/tool/configurators/sanlock.py +++ b/lib/vdsm/tool/configurators/sanlock.py @@ -21,7 +21,6 @@ import grp import pwd -from .. import NotRootError from .import \ CONFIGURED, \ InvalidConfig, \ -- To view, visit http://gerrit.ovirt.org/32256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8e86dd38e3a871d55ffc5cb67d5f4596ec4dc3a6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>

3 7

Change in vdsm[ovirt-3.5]: Use stdout for regular output message in removeConf func
by ybronhei＠redhat.com 01 Sep '14

01 Sep '14

Hello mooli tayer, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/32205 to review the following change. Change subject: Use stdout for regular output message in removeConf func ...................................................................... Use stdout for regular output message in removeConf func Change-Id: Ifce4153e28697d100ae551cdb6c735a07dd90434 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/31941 Reviewed-by: mooli tayer <mtayer(a)redhat.com> Reviewed-by: Dan Kenigsberg <danken(a)redhat.com> --- M lib/vdsm/tool/configurator.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/05/32205/1 diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py index 83e7d41..6d497ae 100644 --- a/lib/vdsm/tool/configurator.py +++ b/lib/vdsm/tool/configurator.py @@ -154,7 +154,7 @@ for c in args.modules: try: c.removeConf() - sys.stderr.write( + sys.stdout.write( "removed configuration of module %s successfully\n" % c.getName() ) -- To view, visit http://gerrit.ovirt.org/32205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifce4153e28697d100ae551cdb6c735a07dd90434 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>

3 5

Change in vdsm[master]: beautify and better __exit__ strategy
by ykleinbe＠redhat.com 01 Sep '14

01 Sep '14

Yoav Kleinberger has uploaded a new change for review. Change subject: beautify and better __exit__ strategy ...................................................................... beautify and better __exit__ strategy 1. cleaned up the code a bit, added external runner script 2. __exit__ now cleans up the LVs left by the test - this is still not perfect due to sanlock issues Change-Id: I72a336ea08605f7acac807313f8c5a46cd14ab57 Signed-off-by: Yoav Kleinberger <ykleinbe(a)redhat.com> --- A run_new_functional_tests.sh M tests/functional/new/basic_storage_domain_test.py M tests/functional/new/testlib/testcontexts/iscsi.py 3 files changed, 20 insertions(+), 41 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/32252/1 diff --git a/run_new_functional_tests.sh b/run_new_functional_tests.sh new file mode 100755 index 0000000..af59981 --- /dev/null +++ b/run_new_functional_tests.sh @@ -0,0 +1,2 @@ +#!/bin/bash +sudo PYTHONPATH=lib:vdsm:tests/functional/new nosetests -s --nologcapture tests/functional/new/basic_storage_domain_test.py diff --git a/tests/functional/new/basic_storage_domain_test.py b/tests/functional/new/basic_storage_domain_test.py index 37937ae..b50f2a9 100644 --- a/tests/functional/new/basic_storage_domain_test.py +++ b/tests/functional/new/basic_storage_domain_test.py @@ -1,35 +1,19 @@ -############## import sys -sys.path.insert(0, 'lib') -sys.path.insert(0, 'vdsm') -############## import uuid import storage.volume import storage.image import logging -logging.basicConfig(level=logging.DEBUG, format='%(asctime)s TEST %(levelname)s: %(message)s') -from .testlib import vdsmtestcontext -from .testlib import controlvdsm +from testlib import vdsmtestcontext +from testlib import controlvdsm -class TestBasicLocalFSStorageDomain: +class TestBasicStorageDomain: + @classmethod + def setup_class(cls): + logging.basicConfig(level=logging.DEBUG, format='%(asctime)s TEST %(levelname)s: %(message)s') + def setup(self): controlVDSM = controlvdsm.ControlVDSM() controlVDSM.cleanup() - - def notest_create_and_destroy_storage_domain(self): - with vdsmtestcontext.vdsmTestContext('localfs') as (vdsm, verify): - storageServerID = vdsm.connectStorageServer() - verify.storageServerConnected() - - domainID = vdsm.createStorageDomain() - verify.storageDomainCreated(domainID) - - vdsm.formatStorageDomain(domainID) - verify.storageDomainGone(domainID) - -#what's this when using ISCSI? - vdsm.disconnectStorageServer(storageServerID) - verify.storageServerDisconnected() def test_create_volume(self): with vdsmtestcontext.vdsmTestContext('iscsi') as (vdsm, verify): @@ -46,7 +30,7 @@ vdsm.spmStart() verify.spmStarted(poolID) - vdsm.activateStorageDomain() + vdsm.activateStorageDomain(domainID, poolID) GIGABYTE = 1024 ** 3 taskID = vdsm.createVolume(1 * GIGABYTE) verify.volumeCreated(taskID) diff --git a/tests/functional/new/testlib/testcontexts/iscsi.py b/tests/functional/new/testlib/testcontexts/iscsi.py index c81ceff..2df2429 100644 --- a/tests/functional/new/testlib/testcontexts/iscsi.py +++ b/tests/functional/new/testlib/testcontexts/iscsi.py @@ -18,23 +18,10 @@ class Verify(base.Verify): def __init__(self, iqn, volumeGroup, vdsm, volumeID): -### store iqn here self._iqn = iqn self._volumeGroup = volumeGroup self._vdsm = vdsm self._volumeID = volumeID - - def assertPathExists(self, path, link = False): - if link: - assert os.path.lexists(path) - else: - assert os.path.exists(path) - - def assertPathDoesNotExist(self, path, link = False): - if link: - assert not os.path.lexists(path) - else: - assert not os.path.exists(path) def storageServerConnected(self): targetNameFiles = glob.glob('/sys/devices/platform/host*/session*/iscsi_session/*/targetname') @@ -107,7 +94,6 @@ self._storageFile = os.path.join(self._testDirectory, 'testfile') self._fileioBackstore = self._randomName('backfile') logging.info('using %s, %s' % (self._fileioBackstore, self._storageFile)) -#### self._targetcli('/backstores/fileio create %s %s 30G' % (self._fileioBackstore, self._storageFile)) self._targetcli('/iscsi create %s' % self._iqn) self._targetcli('/iscsi/%s/tpg1/luns create /backstores/fileio/%s' % (self._iqn, self._fileioBackstore)) @@ -116,6 +102,13 @@ return self, Verify(self._iqn, self._volumeGroup, self._vdsm, self._volumeID) def __exit__(self, *args): + doubleDashed = self._volumeGroup['uuid'].replace('-', '--') + mapperDevices = glob.glob('/dev/mapper/%s*' % doubleDashed ) + [ '/dev/mapper/%s' % self._lunGUID ] + for device in mapperDevices: + logging.info('removing %s' % device) + result = subprocess.call('sudo dmsetup remove %s' % device, shell=True) + if result != 0: + logging.warning('could not remove %s' % device) self._targetcli( '/iscsi delete %s' % self._iqn ) self._targetcli( '/backstores/fileio delete %s' % self._fileioBackstore ) shutil.rmtree(self._testDirectory) @@ -175,8 +168,8 @@ result = self._vdsm.spmStart(self._poolID, -1, '-1', SCSI_FENCING_DEPRECATED, RECOVERY_MODE_DEPRECATED) self.verifyVDSMSuccess(result) - def activateStorageDomain(self): - result = self._vdsm.activateStorageDomain(self._domainID(), self._poolID) + def activateStorageDomain(self, domainID, poolID): + result = self._vdsm.activateStorageDomain(domainID,poolID) self.verifyVDSMSuccess(result) def _createVG(self): @@ -185,6 +178,7 @@ logging.info('createVG returned %s' % result) self.verifyVDSMSuccess(result) self._volumeGroup[ 'vgs_uuid' ] = result[ 'uuid' ] + self._lunGUID = lun['GUID'] def _newUUID(self): return str(uuid.uuid4()) @@ -194,7 +188,6 @@ self._createStorageDomain() return self._volumeGroup['uuid'] -##### def embed(self,msg): print 'embedding: %s' % msg import IPython -- To view, visit http://gerrit.ovirt.org/32252 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I72a336ea08605f7acac807313f8c5a46cd14ab57 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger <ykleinbe(a)redhat.com>

2 1

Change in vdsm[master]: vdsm-tool: use geteuid() instead of getuid() for root check.
by mtayer＠redhat.com 01 Sep '14

01 Sep '14

mooli tayer has uploaded a new change for review. Change subject: vdsm-tool: use geteuid() instead of getuid() for root check. ...................................................................... vdsm-tool: use geteuid() instead of getuid() for root check. Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M lib/vdsm/tool/configurator.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/31317/1 diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py index 90e8616..2dbd48e 100644 --- a/lib/vdsm/tool/configurator.py +++ b/lib/vdsm/tool/configurator.py @@ -676,7 +676,7 @@ def requiresRoot(func): @functools.wraps(func) def wrapper(*args, **kwargs): - if os.getuid() != 0: + if os.geteuid() != 0: raise NotRootError() func(*args, **kwargs) return wrapper -- To view, visit http://gerrit.ovirt.org/31317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0a54af5737cf47e3f5e8ab62339bddd978ceddb9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>

6 23

Change in vdsm[master]: vdsm-tool: changing root checking in configurator.
by mtayer＠redhat.com 01 Sep '14

01 Sep '14

mooli tayer has uploaded a new change for review. Change subject: vdsm-tool: changing root checking in configurator. ...................................................................... vdsm-tool: changing root checking in configurator. Checking for root as we currently do in configure of libvirt and sanlock is not enough. Currently this will fail during the isConfigured() check since it does not have premissions to the files it attempts to check: "OSError: No such file or directory: /etc/libvirt/libvirtd.conf" It is easy to see that this check is needed for all the exposed methods of configurator. I'm suggesting to do it in the exposed verbs in a uniform manner. Change-Id: I52967e30f677e4537b83c2db442963e3eadecb55 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M lib/vdsm/tool/configurator.py 1 file changed, 16 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/31293/1 diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py index 8136613..475fa62 100644 --- a/lib/vdsm/tool/configurator.py +++ b/lib/vdsm/tool/configurator.py @@ -20,6 +20,7 @@ import argparse import errno import filecmp +import functools import grp import os import pwd @@ -105,9 +106,6 @@ return ["vdsmd", "supervdsmd", "libvirtd"] def configure(self): - if os.getuid() != 0: - raise NotRootError() - self._sysvToUpstart() if utils.isOvirtNode(): @@ -607,9 +605,6 @@ """ Configure sanlock process groups """ - if os.getuid() != 0: - raise NotRootError() - rc, out, err = utils.execCmd( ( '/usr/sbin/usermod', @@ -678,13 +673,25 @@ ) +def assertRoot(func): + @functools.wraps(func) + def inner(*args, **kwargs): + if os.getuid() != 0: + raise NotRootError() + func(*args, **kwargs) + return inner + + @expose("configure") +@assertRoot def configure(*args): """ configure [-h|...] Configure external services for vdsm Invoke with -h for complete usage. """ + + args = _parse_args(*args) configurer_to_trigger = [] @@ -726,6 +733,7 @@ @expose("is-configured") +@assertRoot def isconfigured(*args): """ is-configured [-h|...] @@ -763,6 +771,7 @@ @expose("validate-config") +@assertRoot def validate_config(*args): """ validate-config [-h|...] @@ -788,6 +797,7 @@ @expose("remove-config") +@assertRoot def remove_config(*args): """ Remove vdsm configuration from conf files -- To view, visit http://gerrit.ovirt.org/31293 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I52967e30f677e4537b83c2db442963e3eadecb55 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>

6 38

Change in vdsm[ovirt-3.5]: tool: Create configurators once
by ybronhei＠redhat.com 01 Sep '14

01 Sep '14

Hello Nir Soffer, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/32204 to review the following change. Change subject: tool: Create configurators once ...................................................................... tool: Create configurators once Commit e5e80540e8 replaced the configurators dict with a function, creating a configuration dict on each call. The code added in this commit invoke the function many times for each run on the tool, creating 10's of instances of the configurators. This change is not needed to acomplish the purpuse of that patch, and is rather pointless. This patch reverts the unrelated change, keeping the configurations in a module constant. This change also simplify the tests. Change-Id: I6e0e258dc28557661bf85734f000e43f20b1e512 Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/31739 Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com> Reviewed-by: Dan Kenigsberg <danken(a)redhat.com> --- M lib/vdsm/tool/configurator.py M tests/toolTests.py 2 files changed, 23 insertions(+), 24 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/32204/1 diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py index 83e7d41..c40375e 100644 --- a/lib/vdsm/tool/configurator.py +++ b/lib/vdsm/tool/configurator.py @@ -33,12 +33,11 @@ sanlock -def _getConfigurers(): - return dict((m.getName(), m) for m in ( - certificates.Certificates(), - libvirt.Libvirt(), - sanlock.Sanlock(), - )) +_CONFIGURATORS = dict((m.getName(), m) for m in ( + certificates.Certificates(), + libvirt.Libvirt(), + sanlock.Sanlock(), +)) @expose("configure") @@ -177,9 +176,9 @@ while queue: next_ = queue.popleft() try: - requiredNames = _getConfigurers()[next_].getRequires() + requiredNames = _CONFIGURATORS[next_].getRequires() except KeyError: - available = ', '.join(sorted(_getConfigurers())) + available = ', '.join(sorted(_CONFIGURATORS)) raise UsageError( "error: argument --module: invalid choice: %s\n" "(available: %s)\n" % (next_, available) @@ -203,7 +202,7 @@ while modulesNames: for c in modulesNames: - requires = _getConfigurers()[c].getRequires() + requires = _CONFIGURATORS[c].getRequires() if requires.issubset(set(sortedModules)): modulesNames.remove(c) sortedModules.append(c) @@ -228,7 +227,7 @@ '(e.g %s).\n' 'If non is specified, operation will run for ' 'all related modules.' - % _getConfigurers().keys() + % _CONFIGURATORS.keys() ), ) if action == "configure": @@ -242,10 +241,10 @@ args = parser.parse_args(args) if not args.modules: - args.modules = _getConfigurers().keys() + args.modules = _CONFIGURATORS.keys() args.modules = _sort_modules(_add_dependencies(args.modules)) - args.modules = [_getConfigurers()[cName] for cName in args.modules] + args.modules = [_CONFIGURATORS[cName] for cName in args.modules] return args diff --git a/tests/toolTests.py b/tests/toolTests.py index 502af03..51ad8ed 100644 --- a/tests/toolTests.py +++ b/tests/toolTests.py @@ -57,8 +57,8 @@ @monkeypatch.MonkeyPatch( configurator, - '_getConfigurers', - lambda: { + '_CONFIGURATORS', + { 'a': MockModuleConfigurator('a', set(['b'])), 'b': MockModuleConfigurator('b', set(['a'])) } @@ -72,8 +72,8 @@ @monkeypatch.MonkeyPatch( configurator, - '_getConfigurers', - lambda: { + '_CONFIGURATORS', + { 'a': MockModuleConfigurator('a', set(['b', 'd'])), 'b': MockModuleConfigurator('b', set(['c'])), 'c': MockModuleConfigurator('c', set(['e', 'd'])), @@ -94,8 +94,8 @@ @monkeypatch.MonkeyPatch( configurator, - '_getConfigurers', - lambda: { + '_CONFIGURATORS', + { 'a': MockModuleConfigurator('a', set()), 'b': MockModuleConfigurator('b', set()), 'c': MockModuleConfigurator('c', set()) @@ -106,8 +106,8 @@ @monkeypatch.MonkeyPatch( configurator, - '_getConfigurers', - lambda: { + '_CONFIGURATORS', + { 'a': MockModuleConfigurator('a', set(['b', 'c'])), 'b': MockModuleConfigurator('b', set()), 'c': MockModuleConfigurator('c', set()) @@ -125,8 +125,8 @@ @monkeypatch.MonkeyPatch( configurator, - '_getConfigurers', - lambda: { + '_CONFIGURATORS', + { 'a': MockModuleConfigurator('a', set()), 'b': MockModuleConfigurator('b', set()), 'c': MockModuleConfigurator('c', set()) @@ -145,8 +145,8 @@ @monkeypatch.MonkeyPatch( configurator, - '_getConfigurers', - lambda: { + '_CONFIGURATORS', + { 'libvirt': MockModuleConfigurator('libvirt', set()), 'sanlock': MockModuleConfigurator('sanlock', set()), } -- To view, visit http://gerrit.ovirt.org/32204 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6e0e258dc28557661bf85734f000e43f20b1e512 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>

4 6

Change in vdsm[ovirt-3.5]: libvirtd.log: time to be less verbose
by mtayer＠redhat.com 01 Sep '14

01 Sep '14

mooli tayer has uploaded a new change for review. Change subject: libvirtd.log: time to be less verbose ...................................................................... libvirtd.log: time to be less verbose After several years, we can drop log verbosity to libvirt's default. Currently, libvirt logs are filling up ovirt-nodes that run dozens of VMs. Change-Id: I251c2534d3284aa95bffa56143c449d5de887008 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1125237 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/31135 Tested-by: mooli tayer <mtayer(a)redhat.com> Reviewed-by: Francesco Romani <fromani(a)redhat.com> (cherry picked from commit da2d0403de40f89da30f0618d903e707632cc445) --- M lib/vdsm/tool/configurators/libvirt.py 1 file changed, 0 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/32244/1 diff --git a/lib/vdsm/tool/configurators/libvirt.py b/lib/vdsm/tool/configurators/libvirt.py index da19da2..86f24e4 100644 --- a/lib/vdsm/tool/configurators/libvirt.py +++ b/lib/vdsm/tool/configurators/libvirt.py @@ -340,14 +340,6 @@ 'auth_unix_rw': '"sasl"', 'host_uuid': '"' + str(uuid.uuid4()) + '"', 'keepalive_interval': -1, - # FIXME until we are confident with libvirt - # integration, let us have a verbose log - 'log_outputs': ( - '"1:file:/var/log/libvirt/libvirtd.log"'), - 'log_filters': ( - '"3:virobject 3:virfile 2:virnetlink ' - '3:cgroup 3:event 3:json 1:libvirt ' - '1:util 1:qemu"'), }, }, { -- To view, visit http://gerrit.ovirt.org/32244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I251c2534d3284aa95bffa56143c449d5de887008 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>

3 4

Change in vdsm[master]: libvirtd.log: time to be less verbose
by Dan Kenigsberg 01 Sep '14

01 Sep '14

Dan Kenigsberg has uploaded a new change for review. Change subject: libvirtd.log: time to be less verbose ...................................................................... libvirtd.log: time to be less verbose After several years, we can drop log verbosity to libvirt's default. Currently, libvirt logs are filling up ovirt-nodes that run dozens of VMs. Change-Id: I251c2534d3284aa95bffa56143c449d5de887008 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M lib/vdsm/tool/configurator.py 1 file changed, 1 insertion(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/31135/1 diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py index 8136613..636babf 100644 --- a/lib/vdsm/tool/configurator.py +++ b/lib/vdsm/tool/configurator.py @@ -349,7 +349,7 @@ # version != PACKAGE_VERSION since we do not want to update configuration # on every update. see 'configuration versioning:' at Configfile.py for # details. - CONF_VERSION = '4.13.0' + CONF_VERSION = '4.17.0' PKI_DIR = os.path.join(SYSCONF_PATH, 'pki/vdsm') CA_FILE = os.path.join(PKI_DIR, 'certs/cacert.pem') @@ -388,14 +388,6 @@ 'auth_unix_rw': '"sasl"', 'host_uuid': '"' + str(uuid.uuid4()) + '"', 'keepalive_interval': -1, - # FIXME until we are confident with libvirt - # integration, let us have a verbose log - 'log_outputs': ( - '"1:file:/var/log/libvirt/libvirtd.log"'), - 'log_filters': ( - '"3:virobject 3:virfile 2:virnetlink ' - '3:cgroup 3:event 3:json 1:libvirt ' - '1:util 1:qemu"'), }, }, { -- To view, visit http://gerrit.ovirt.org/31135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I251c2534d3284aa95bffa56143c449d5de887008 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

6 21

Change in vdsm[ovirt-3.5]: Force flag not optional for detach storage domain
by Jenkins CI RO 01 Sep '14

01 Sep '14

oVirt Jenkins CI Server has posted comments on this change. Change subject: Force flag not optional for detach storage domain ...................................................................... Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/125/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0b7b34464ec83bbf408df61c0193cd17e193e00 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches September 2014