Change in vdsm[master]: tmp
by automation＠ovirt.org
automation(a)ovirt.org has posted comments on this change.
Change subject: tmp
......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/39548
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47c816e9d453dca595fc7abb4a84b301c34fc624
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
9 years, 1 month
Change in vdsm[master]: tmp
by automation＠ovirt.org
automation(a)ovirt.org has posted comments on this change.
Change subject: tmp
......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/39547
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67a2fa5af269a4e7043c1bda9eb24b9f3f8ea248
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
9 years, 1 month
Change in vdsm[master]: tmp5
by automation＠ovirt.org
automation(a)ovirt.org has posted comments on this change.
Change subject: tmp5
......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/39546
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I46f61df9350b111e0ddee681ce073345709d3b56
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
9 years, 1 month
Change in vdsm[master]: SDM: add the copyVolumeData command
by automation＠ovirt.org
automation(a)ovirt.org has posted comments on this change.
Change subject: SDM: add the copyVolumeData command
......................................................................
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/38501
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30e44a6332ec343f64793b0fedaf9ef75a872cac
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 1 month
Change in vdsm[ovirt-3.5]: Hack to fix vdsm-tool import issues during upgrade
by ybronhei＠redhat.com
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Hack to fix vdsm-tool import issues during upgrade
In oVirt 3.5 we started to install vdsm site-packages under /usr/lib
(python_sitelib). In sys.path the import order first check under
/usr/lib64. While upgrading vdsm 3.4 to 3.5 we perform configure call in
%postun which calls vdsm-tool, vdsm-tool tries to import vdsm.tool which
exists both under /usr/lib and under /usr/lib64 in this specific case
before all vdsm 3.4 files were removed. In such case we get failures all
over.
This patch hacks the import part and takes care of importing vdsm.tool
from the /usr/lib on upgrade. This will be needed also in ovirt-3.6 if we
want to support upgrade between 3.4 to 3.6.
Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Label: OVIRT-3.5 ONLY
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M vdsm-tool/vdsm-tool
1 file changed, 22 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/39408/1
diff --git a/vdsm-tool/vdsm-tool b/vdsm-tool/vdsm-tool
index 8fa3bc5..e46bb21 100755
--- a/vdsm-tool/vdsm-tool
+++ b/vdsm-tool/vdsm-tool
@@ -28,8 +28,30 @@
import syslog
import traceback
+########################################################################
+# Ugly hack for 3.5 which switches the use of /usr/lib64 to /usr/lib.
+#
+# To avoid loading vdsm-tool verbs from old location (/usr/lib64)
+# we need to explicit import vdsm.tool from /usr/lib.
+# On upgrade from 3.4-3.5 when this directory change first introduced
+# we load vdsm.tool from /usr/lib64 before 3.4 package got removed.
+#
+# This leads to upgrade errors on vdsm-tool calls. With this ugly fix
+# I first add to path /usr/lib, import and then remove sys.path changes.
+# If I don't remove the changes it leads to other issues when
+# importing seobject.
+########################################################################
+
+sys.path.insert(0, '/usr/lib/python2.6/site-packages')
+sys.path.insert(0, '/usr/lib/python2.7/site-packages')
+
import vdsm.tool
+sys.path.pop(0)
+sys.path.pop(0)
+
+########################################################################
+
tool_modules = []
tool_command = {}
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
9 years, 1 month
Change in vdsm[master]: Hack to fix vdsm-tool import issues during upgrade
by ybronhei＠redhat.com
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Hack to fix vdsm-tool import issues during upgrade
In oVirt 3.5 (vdsm 4.16) we started to install vdsm site-packages under /usr/lib
(python_sitelib). In sys.path the import order first check under
/usr/lib64. While upgrading vdsm 3.4 to 3.5 we perform configure call in
%postun which calls vdsm-tool, vdsm-tool tries to import vdsm.tool which
exists both under /usr/lib and under /usr/lib64 in this specific case
before all vdsm 3.4 files were removed. In such case we get failures all
over.
This patch hacks the import part and takes care of importing vdsm.tool
from the /usr/lib on upgrade.
Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1200467
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M vdsm-tool/vdsm-tool
1 file changed, 22 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/39410/1
diff --git a/vdsm-tool/vdsm-tool b/vdsm-tool/vdsm-tool
index 8fa3bc5..e46bb21 100755
--- a/vdsm-tool/vdsm-tool
+++ b/vdsm-tool/vdsm-tool
@@ -28,8 +28,30 @@
import syslog
import traceback
+########################################################################
+# Ugly hack for 3.5 which switches the use of /usr/lib64 to /usr/lib.
+#
+# To avoid loading vdsm-tool verbs from old location (/usr/lib64)
+# we need to explicit import vdsm.tool from /usr/lib.
+# On upgrade from 3.4-3.5 when this directory change first introduced
+# we load vdsm.tool from /usr/lib64 before 3.4 package got removed.
+#
+# This leads to upgrade errors on vdsm-tool calls. With this ugly fix
+# I first add to path /usr/lib, import and then remove sys.path changes.
+# If I don't remove the changes it leads to other issues when
+# importing seobject.
+########################################################################
+
+sys.path.insert(0, '/usr/lib/python2.6/site-packages')
+sys.path.insert(0, '/usr/lib/python2.7/site-packages')
+
import vdsm.tool
+sys.path.pop(0)
+sys.path.pop(0)
+
+########################################################################
+
tool_modules = []
tool_command = {}
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
9 years, 1 month
Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...
by ibarkan＠redhat.com
Ido Barkan has posted comments on this change.
Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
......................................................................
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/38281/13/lib/vdsm/tool/dump_volume_chains.py
File lib/vdsm/tool/dump_volume_chains.py:
Line 201:
Line 202: _LINE_FORMAT = '{0:^13}{1}'
Line 203:
Line 204:
Line 205: def _print_vol_info(child, volumes_info):
> _print_vol_info only needs to know about a single volume info
Done
Line 206: info_fmt = "status: {status}, voltype: {voltype}, format: {format}, " \
Line 207: "legality: {legality}, type: {type}"
Line 208: try:
Line 209: formatted_info = info_fmt.format(**volumes_info[child])
--
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vladik Romanovsky <vladik.romanovsky(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
9 years, 1 month
Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...
by Jenkins CI RO
oVirt Jenkins CI Server has posted comments on this change.
Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
......................................................................
Patch Set 15:
Build Started (6/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/...
--
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vladik Romanovsky <vladik.romanovsky(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 1 month
Change in vdsm[master]: storage: introducing vdsm-dump-chains script (part of vdsm-t...
by Jenkins CI RO
oVirt Jenkins CI Server has posted comments on this change.
Change subject: storage: introducing vdsm-dump-chains script (part of vdsm-tool)
......................................................................
Patch Set 15:
Build Started (5/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1...
--
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vladik Romanovsky <vladik.romanovsky(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 1 month
