Change in vdsm[master]: tests: Fix wrong usage of @broken_on_ci
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Fix wrong usage of @broken_on_ci
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/67326
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2f23c3facee68366a0eee8e8f858d29f3272977
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months
Change in vdsm[master]: API: move vm parameters fixup in a method
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: API: move vm parameters fixup in a method
......................................................................
Patch Set 10: Code-Review+2 Verified+1
copying score from ps3
--
To view, visit https://gerrit.ovirt.org/66416
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia46a63ac8f321860a5718d1af9c412e537646cc9
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months
Change in vdsm[master]: API: move vmParams validation in a method
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: API: move vmParams validation in a method
......................................................................
API: move vmParams validation in a method
API.VM.create does some parameter validation, raising
errors if some key parameter are missing.
This patch moves this code on its own submethod.
Change-Id: I7a5cae5a1b5382764eab9b6e302ad6e128210c93
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M vdsm/API.py
1 file changed, 20 insertions(+), 17 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/66415
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a5cae5a1b5382764eab9b6e302ad6e128210c93
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in vdsm[master]: API: use exceptions in the VM.create flow
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: API: use exceptions in the VM.create flow
......................................................................
API: use exceptions in the VM.create flow
This is possible using the recently added api.method decorator,
and makes the code tidier.
Change-Id: Ib2ddda1f102e1d6d4d44ef0f0ff192a99dfdd520
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M vdsm/API.py
1 file changed, 20 insertions(+), 27 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/66412
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2ddda1f102e1d6d4d44ef0f0ff192a99dfdd520
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in vdsm[master]: API: use exceptions in the VM.create flow
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: API: use exceptions in the VM.create flow
......................................................................
Patch Set 10: Code-Review+2 Verified+1
copying score from ps3
--
To view, visit https://gerrit.ovirt.org/66412
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2ddda1f102e1d6d4d44ef0f0ff192a99dfdd520
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months
Change in vdsm[master]: tests: add tests for API.VM.create()
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: add tests for API.VM.create()
......................................................................
tests: add tests for API.VM.create()
The API.VM.create() method has a pretty complex flow.
Let's add some tests to allow refactoring, and for added safety.
Change-Id: I45583c7e939627f750527f70a3edc03ccc4f0db0
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
A tests/API_test.py
M tests/Makefile.am
2 files changed, 200 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67160
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45583c7e939627f750527f70a3edc03ccc4f0db0
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in vdsm[master]: autoconf: made vdsmrepo customizable
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: autoconf: made vdsmrepo customizable
......................................................................
Patch Set 21:
(1 comment)
https://gerrit.ovirt.org/#/c/67248/21/configure.ac
File configure.ac:
Line 267: AC_SUBST([vdsmbackupdir], ['${vdsmlogdir}/backup'])
Line 268: AC_SUBST([vdsmexecdir], ['${libexecdir}/vdsm'])
Line 269: AC_SUBST([vdsmhooksdir], ['${vdsmexecdir}/hooks'])
Line 270: AC_SUBST([vdsmtsdir], ['${sysconfdir}/pki/vdsm'])
Line 271: AC_SUBST([vdsmrepo], [${with_storage_repo}])
I don't like the lack of symmetry between this and the rest of the substitutions here. Why do we need to evaluate the the shell variable here, but postpone it for others?
There's a little mess with VDSMREPO vdsmrepo and with_storage_repo. The mess precedes your patch, but I hope you can reduce it.
ps. using quoteless variables in shell scripts is dangerous (they break on whitespace). So if we end up with your current solution, please have
AC_SUBST([vdsmrepo], ["${with_storage_repo}"])
Line 272: AC_SUBST([vdsmpylibdir], ['${pythondir}/vdsm'])
Line 273: AC_SUBST([vdsmnetinfodir], ['${vdsmpylibdir}/network/netinfo'])
Line 274: AC_SUBST([vdsmtooldir], ['${vdsmpylibdir}/tool'])
Line 275: AC_SUBST([configuratorsdir], ['${vdsmtooldir}/configurators'])
--
To view, visit https://gerrit.ovirt.org/67248
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2498e473a11a180254326c6ad9ed9b117bdaec7
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 5 months
Change in vdsm[master]: python3: Enable storage mount tests on python 3
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: python3: Enable storage mount tests on python 3
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/67335
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d289c79bad858826bf74ee943420f636ed21b82
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months
Change in vdsm[master]: testValidation: Add @skipif decorator
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: testValidation: Add @skipif decorator
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/67334
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71a2ae262482edc8acf303f18eac6f9035e710bc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months
Change in vdsm[master]: tests: add tests for API.VM.create()
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: add tests for API.VM.create()
......................................................................
Patch Set 9: Code-Review+2 Continuous-Integration+1 Verified+1
unrelated infra failure
16:22:27 ERROR: test_import_modules(('a.py', 'b.py', 'a.pyc', '_my.py'), ('a', 'b', '_my')) (moduleloader_test.ImportModulesTest)
16:22:27 ----------------------------------------------------------------------
16:22:27 Traceback (most recent call last):
16:22:27 File "/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/tests/testlib.py", line 135, in wrapper
16:22:27 return f(self, *args)
16:22:27 File "/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/tests/moduleloader_test.py", line 51, in test_import_modules
16:22:27 with self._setup_test_modules(files) as module_name:
16:22:27 File "/usr/lib64/python3.5/contextlib.py", line 59, in __enter__
16:22:27 return next(self.gen)
16:22:27 File "/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/tests/moduleloader_test.py", line 42, in _setup_test_modules
16:22:27 yield importlib.import_module(os.path.basename(path))
16:22:27 File "/usr/lib64/python3.5/importlib/__init__.py", line 126, in import_module
16:22:27 return _bootstrap._gcd_import(name[level:], package, level)
16:22:27 File "<frozen importlib._bootstrap>", line 986, in _gcd_import
16:22:27 File "<frozen importlib._bootstrap>", line 969, in _find_and_load
16:22:27 File "<frozen importlib._bootstrap>", line 956, in _find_and_load_unlocked
16:22:27 ImportError: No module named 'tmpqxxp4u80'
--
To view, visit https://gerrit.ovirt.org/67160
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45583c7e939627f750527f70a3edc03ccc4f0db0
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months