Change in vdsm[master]: Revert "sudoers: Remove uneeded rules"
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Revert "sudoers: Remove uneeded rules"
......................................................................
Patch Set 1: Code-Review-1
CI failure would go away once you rebase on master
09:23:24 49 E305 expected 2 blank lines after class or function definition, found 1
09:23:24 8 F999 dictionary key 'ewma' repeated with different values
I'm sorry for breaking hosted engine, but I think that the extra sudo permission should be shipped with HE.
--
To view, visit https://gerrit.ovirt.org/67290
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbe388e491168c97c6ae5e631bd2513bae96c3ed
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months
Change in vdsm[master]: shell_helper: allow nondefault rpmdir
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: shell_helper: allow nondefault rpmdir
......................................................................
shell_helper: allow nondefault rpmdir
Change-Id: Ic2dcc05a922d30abbfd8373f5788e237d8126c6c
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M contrib/shell_helper
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/67191/1
diff --git a/contrib/shell_helper b/contrib/shell_helper
index 2d4dc65..4cbf140 100755
--- a/contrib/shell_helper
+++ b/contrib/shell_helper
@@ -3,14 +3,15 @@
# .zshrc.
VDSM_DIR=~/code/vdsm
+RPMDIR=`rpm --eval %_rpmdir`
_latest_version() {
- ls ~/rpmbuild/RPMS/*/vdsm* -t -w 1 | head -1 | sed 's/.*vdsm-[a-z]*-//;s/.noarch.rpm//'
+ ls "$RPMDIR"/*/vdsm* -t -w 1 | head -1 | sed 's/.*vdsm-[a-z]*-//;s/.noarch.rpm//'
}
_latest_rpms() {
local VERSION=$(_latest_version)
- find ~/rpmbuild/RPMS/ -iname "*$VERSION*.rpm" | egrep "vdsm-[0-9]|python|cli|xmlrpc|jsonrpc|tests|infra|api|hook-vmfex-dev"
+ find "$RPMDIR"/ -iname "*$VERSION*.rpm" | egrep "vdsm-[0-9]|python|cli|xmlrpc|jsonrpc|tests|infra|api|hook-vmfex-dev"
}
vdsm_configure_force() {
--
To view, visit https://gerrit.ovirt.org/67191
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2dcc05a922d30abbfd8373f5788e237d8126c6c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years, 5 months
Change in vdsm[master]: net: NetworkManager python binding - Connection Settings
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: NetworkManager python binding - Connection Settings
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/67216/4//COMMIT_MSG
Commit Message:
Line 10: Starting by exposing the connection settings interface, through which
Line 11: it is possible to list and iterate through the available connections.
Line 12:
Line 13: In NM terms, a connection is a configuration setting instance of a given
Line 14: device.
"""
dbus-python (based on DBus-GLib)
New applications should use pydbus, txdbus or GDBus/QtDBus bindings. See above.
"""
why are we using a dead library (please explain in the commit message).
Nevertheless, I see that someone is building python3-dbus for el7 these days: http://koji.fedoraproject.org/koji/buildinfo?buildID=816312 in few more days I expect it to hit epel repositories
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-3606e79612
Line 15:
Line 16: Change-Id: Ie5d38679e3c60d998980b310c61f34fb61bf394a
--
To view, visit https://gerrit.ovirt.org/67216
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5d38679e3c60d998980b310c61f34fb61bf394a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 5 months
Change in vdsm[master]: net: NetworkManager python binding - Connection Settings
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: NetworkManager python binding - Connection Settings
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/67216/4/automation/check-patch.packages.fc24
File automation/check-patch.packages.fc24:
Line 1: autoconf
Line 2: automake
Line 3: dbus-python
you should pull also the py3 package for
14:21:49 File "/home/jenkins/workspace/vdsm_master_check-patch-fc24-x86_64/vdsm/lib/vdsm/network/nm/nmdbus/__init__.py", line 21, in <module>
14:21:49 import dbus
14:21:49 ImportError: No module named 'dbus'
Line 4: gdb
Line 5: git
Line 6: libguestfs-tools-c
Line 7: libselinux-python3
--
To view, visit https://gerrit.ovirt.org/67216
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5d38679e3c60d998980b310c61f34fb61bf394a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 5 months
Change in vdsm[master]: Using vm_name instead of uuid in vm metrics report
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Using vm_name instead of uuid in vm metrics report
......................................................................
Using vm_name instead of uuid in vm metrics report
The name is reported by libvirt and more useful for metrics. The uuid has no
meaning for the user, its an engine's internal value.
Change-Id: I285cc74fbb5a3a5012c3a37a9a57f60f30050606
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M lib/vdsm/virt/vmstats.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/66234/1
diff --git a/lib/vdsm/virt/vmstats.py b/lib/vdsm/virt/vmstats.py
index f5dc15f..6ab3ac4 100644
--- a/lib/vdsm/virt/vmstats.py
+++ b/lib/vdsm/virt/vmstats.py
@@ -194,8 +194,8 @@
data = {}
try:
for vm_uuid in vms_stats:
- prefix = "vms." + vm_uuid
stat = vms_stats[vm_uuid]
+ prefix = "vms." + stat['vmName']
data[prefix + '.cpu.user'] = stat['cpuUser']
data[prefix + '.cpu.sys'] = stat['cpuSys']
data[prefix + '.cpu.usage'] = stat['cpuUsage']
--
To view, visit https://gerrit.ovirt.org/66234
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I285cc74fbb5a3a5012c3a37a9a57f60f30050606
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
7 years, 5 months
Change in vdsm[master]: autoconf: made vdsmrepo customizable
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: autoconf: made vdsmrepo customizable
......................................................................
Patch Set 9: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/67248/9/automation/build-artifacts.sh
File automation/build-artifacts.sh:
PS9, Line 11: check-patch.sh
It would be safer to place the new path also there.
https://gerrit.ovirt.org/#/c/67248/9/configure.ac
File configure.ac:
Line 267: AC_SUBST([vdsmbackupdir], ['${vdsmlogdir}/backup'])
Line 268: AC_SUBST([vdsmexecdir], ['${libexecdir}/vdsm'])
Line 269: AC_SUBST([vdsmhooksdir], ['${vdsmexecdir}/hooks'])
Line 270: AC_SUBST([vdsmtsdir], ['${sysconfdir}/pki/vdsm'])
Line 271: AC_SUBST([vdsmrepo], ['${with_storage_repo}'])
you should also use @vdsmrepo@ in vdsm.spec.in, so that it is used in the configure all therein. Without it, make rpm would not do the right thing.
Line 272: AC_SUBST([vdsmpylibdir], ['${pythondir}/vdsm'])
Line 273: AC_SUBST([vdsmnetinfodir], ['${vdsmpylibdir}/network/netinfo'])
Line 274: AC_SUBST([vdsmtooldir], ['${vdsmpylibdir}/tool'])
Line 275: AC_SUBST([configuratorsdir], ['${vdsmtooldir}/configurators'])
--
To view, visit https://gerrit.ovirt.org/67248
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2498e473a11a180254326c6ad9ed9b117bdaec7
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 5 months
Change in vdsm[master]: vdsm: log proper tag for messages comming from vdsm-logrotate
by Tomas Golembiovsky
Tomas Golembiovsky has uploaded a new change for review.
Change subject: vdsm: log proper tag for messages comming from vdsm-logrotate
......................................................................
vdsm: log proper tag for messages comming from vdsm-logrotate
The log messages comming from vdsm-logrotate were improperly tagged as
'logrotate'. To avoid confusion with real logrotate we should properly
mark our messages as vdsm-logrotate.
Change-Id: I75e1eae3e75928034edaa24bbcd6fae44920c22d
Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com>
---
M vdsm/vdsm-logrotate
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/65604/1
diff --git a/vdsm/vdsm-logrotate b/vdsm/vdsm-logrotate
index e44e079..0c84ca3 100755
--- a/vdsm/vdsm-logrotate
+++ b/vdsm/vdsm-logrotate
@@ -12,14 +12,14 @@
EXITVALUE=$?
if [ $EXITVALUE != 0 ]; then
- /usr/bin/logger -t logrotate "ALERT exited abnormally with [$EXITVALUE]"
+ /usr/bin/logger -t vdsm-logrotate "ALERT logrotate exited abnormally with [$EXITVALUE]"
fi
if [ -d /var/log/core ] ; then
/usr/bin/find /var/log/core -type f -name '*xz' -mtime +7 -exec /bin/rm -f '{}' \;
RET=$?
if [ $RET != 0 ]; then
- /usr/bin/logger -t logrotate "ALERT clean old core files exited abnormally with [$RET]"
+ /usr/bin/logger -t vdsm-logrotate "ALERT clean old core files exited abnormally with [$RET]"
EXITVALUE=$RET
fi
fi
@@ -28,7 +28,7 @@
/usr/bin/find /var/log/vdsm/import -type f -mtime +30 -exec /bin/rm -f '{}' \;
RET=$?
if [ $RET != 0 ]; then
- /usr/bin/logger -t logrotate "ALERT clean of old import log files exited abnormally with [$RET]"
+ /usr/bin/logger -t vdsm-logrotate "ALERT clean of old import log files exited abnormally with [$RET]"
EXITVALUE=$RET
fi
fi
--
To view, visit https://gerrit.ovirt.org/65604
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I75e1eae3e75928034edaa24bbcd6fae44920c22d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
7 years, 5 months
Change in vdsm[master]: vdsm: report correct exit value in vdsm-logrotate
by Tomas Golembiovsky
Tomas Golembiovsky has uploaded a new change for review.
Change subject: vdsm: report correct exit value in vdsm-logrotate
......................................................................
vdsm: report correct exit value in vdsm-logrotate
The exit code was reported improperly. If all but the last command had
failed we would still return 0. Now we are reporting exit code of last
failed command or 0 when all exited successfully.
Change-Id: I29df6cac36c64be2bf20337ab096ec471d864ca5
Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com>
---
M vdsm/vdsm-logrotate
1 file changed, 8 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/65603/1
diff --git a/vdsm/vdsm-logrotate b/vdsm/vdsm-logrotate
index a29cbe5..e44e079 100755
--- a/vdsm/vdsm-logrotate
+++ b/vdsm/vdsm-logrotate
@@ -17,17 +17,19 @@
if [ -d /var/log/core ] ; then
/usr/bin/find /var/log/core -type f -name '*xz' -mtime +7 -exec /bin/rm -f '{}' \;
- EXITVALUE=$?
- if [ $EXITVALUE != 0 ]; then
- /usr/bin/logger -t logrotate "ALERT clean old core files exited abnormally with [$EXITVALUE]"
+ RET=$?
+ if [ $RET != 0 ]; then
+ /usr/bin/logger -t logrotate "ALERT clean old core files exited abnormally with [$RET]"
+ EXITVALUE=$RET
fi
fi
if [ -d /var/log/vdsm/import ] ; then
/usr/bin/find /var/log/vdsm/import -type f -mtime +30 -exec /bin/rm -f '{}' \;
- EXITVALUE=$?
- if [ $EXITVALUE != 0 ]; then
- /usr/bin/logger -t logrotate "ALERT clean of old import log files exited abnormally with [$EXITVALUE]"
+ RET=$?
+ if [ $RET != 0 ]; then
+ /usr/bin/logger -t logrotate "ALERT clean of old import log files exited abnormally with [$RET]"
+ EXITVALUE=$RET
fi
fi
--
To view, visit https://gerrit.ovirt.org/65603
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I29df6cac36c64be2bf20337ab096ec471d864ca5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
7 years, 5 months
Change in vdsm[master]: libvirt: Workaround missing VIR_DOMAIN_EVENT_ID_JOB_COMPLETED
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: libvirt: Workaround missing VIR_DOMAIN_EVENT_ID_JOB_COMPLETED
......................................................................
libvirt: Workaround missing VIR_DOMAIN_EVENT_ID_JOB_COMPLETED
In a previous patch, we assigned a callback to
VIR_DOMAIN_EVENT_ID_JOB_COMPLETED. However, that constant is not available in
libvirt versions used in RHEL/CentOS 7.2 and the callback registration crashes
there. So we must fake the constant until we depend on libvirt 2.0.
Change-Id: Ib8d3c6a71b4cf694b96cc278adbe9dd5ade62d18
Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com>
---
M lib/vdsm/libvirtconnection.py
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Michal Skrivanek: Looks good to me, but someone else must approve
Milan Zamazal: Verified
--
To view, visit https://gerrit.ovirt.org/67244
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8d3c6a71b4cf694b96cc278adbe9dd5ade62d18
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in vdsm[master]: libvirt: Workaround missing VIR_DOMAIN_EVENT_ID_JOB_COMPLETED
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: libvirt: Workaround missing VIR_DOMAIN_EVENT_ID_JOB_COMPLETED
......................................................................
Patch Set 2: Code-Review+2
disgusting, but let us unbreak the build.
--
To view, visit https://gerrit.ovirt.org/67244
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8d3c6a71b4cf694b96cc278adbe9dd5ade62d18
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months