Change in vdsm[master]: autoconf: made vdsmrepo customizable
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: autoconf: made vdsmrepo customizable
......................................................................
Patch Set 7: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/67248/7/configure.ac
File configure.ac:
Line 416
Line 417
Line 418
Line 419
Line 420
you should not touch these lines
--
To view, visit https://gerrit.ovirt.org/67248
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2498e473a11a180254326c6ad9ed9b117bdaec7
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 6 months
Change in vdsm[refs/meta/config]: Modify Permissions for VDSM project
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Modify Permissions for VDSM project
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/66573/4/project.config
File project.config:
PS4, Line 59: submit = group vdsm-master-maintainers
can we have an online review of this change? this seems to grant submit rights to all vdsm-master-maintainers, instead of only the vdsm-maintainers group.
--
To view, visit https://gerrit.ovirt.org/66573
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I62c7be095056102c0701f1c6017dbae53dcd0a17
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: refs/meta/config
Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-HasComments: Yes
7 years, 6 months
Change in vdsm[master]: tests: add tests for API.VM.create()
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: add tests for API.VM.create()
......................................................................
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/67160/6/tests/API_test.py
File tests/API_test.py:
Line 44: 'memSize': 8 * 1024,
Line 45: 'vmType': 'kvm',
Line 46: 'display': 'qxl',
Line 47: 'kvmEnable': 'true',
Line 48: 'nicModel': 'rtl8139,pv',
I find it wrong to add this abomination now.
My best approach is probably to get https://gerrit.ovirt.org/#/c/67165/ verified and merged asap; I just cannot find the time to verify it against engine and convince Piotr that it is same.
Line 49: }
Line 50: with MonkeyPatchScope([(API, 'clientIF', self.cif)]):
Line 51: self.vm = API.VM(self.uuid)
Line 52: # to make testing easier
--
To view, visit https://gerrit.ovirt.org/67160
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45583c7e939627f750527f70a3edc03ccc4f0db0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 6 months
Change in vdsm[master]: spec: bridge-utils are required for tests
by fabiand＠redhat.com
Fabian Deutsch has uploaded a new change for review.
Change subject: spec: bridge-utils are required for tests
......................................................................
spec: bridge-utils are required for tests
Change-Id: I115f7e9d01fa74c36ef535f85474ffb16177f429
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/62612/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 392b071..c23cde5 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -89,6 +89,7 @@
BuildRequires: rpm-python
BuildRequires: python-blivet
BuildRequires: sanlock-python
+BuildRequires: bridge-utils
%if 0%{?with_openvswitch}
BuildRequires: openvswitch >= 2.0.0
@@ -253,7 +254,6 @@
%endif
Requires: psmisc >= 22.6-15
-Requires: bridge-utils
Requires: sos
Requires: tree
Requires: dosfstools
--
To view, visit https://gerrit.ovirt.org/62612
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I115f7e9d01fa74c36ef535f85474ffb16177f429
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
7 years, 6 months
Change in vdsm[master]: autoconf: made vdsmrepo customizable
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: autoconf: made vdsmrepo customizable
......................................................................
Patch Set 5: Code-Review-1
(6 comments)
https://gerrit.ovirt.org/#/c/67248/5//COMMIT_MSG
Commit Message:
PS5, Line 9: accept
accepts
PS5, Line 14: rhel
Fedora's
https://gerrit.ovirt.org/#/c/67248/5/automation/build-artifacts.sh
File automation/build-artifacts.sh:
Line 9: cp $PWD/automation/index.html "$EXPORTS"
Line 10:
Line 11: # autogen may already have been executed by check-patch.sh
Line 12: if [ ! -f Makefile ]; then
Line 13: ./autogen.sh --system --enable-hooks --enable-vhostmd --with-data-center='/rhev/data-center/'
I love short lines, even in Bash
Line 14: fi
Line 15:
Line 16: make
Line 17:
https://gerrit.ovirt.org/#/c/67248/5/configure.ac
File configure.ac:
Line 397
Line 398
Line 399
Line 400
Line 401
these seem inadvertant changes. please rebase on top of current master.
PS5, Line 243: data-center
"data-center" is an ambiguous name. I suggest to call this "storage-repo"
Line 267: AC_SUBST([vdsmbackupdir], ['${vdsmlogdir}/backup'])
Line 268: AC_SUBST([vdsmexecdir], ['${libexecdir}/vdsm'])
Line 269: AC_SUBST([vdsmhooksdir], ['${vdsmexecdir}/hooks'])
Line 270: AC_SUBST([vdsmtsdir], ['${sysconfdir}/pki/vdsm'])
Line 271: AC_SUBST([vdsmrepo], ['${with_data_center'])
missing closing brace
Line 272: AC_SUBST([vdsmpylibdir], ['${pythondir}/vdsm'])
Line 273: AC_SUBST([vdsmnetinfodir], ['${vdsmpylibdir}/network/netinfo'])
Line 274: AC_SUBST([vdsmtooldir], ['${vdsmpylibdir}/tool'])
Line 275: AC_SUBST([configuratorsdir], ['${vdsmtooldir}/configurators'])
--
To view, visit https://gerrit.ovirt.org/67248
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2498e473a11a180254326c6ad9ed9b117bdaec7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 6 months
Change in vdsm[master]: libvirt: Workaround missing VIR_DOMAIN_EVENT_ID_JOB_COMPLETED
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: libvirt: Workaround missing VIR_DOMAIN_EVENT_ID_JOB_COMPLETED
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/67244/1/lib/vdsm/libvirtconnection.py
File lib/vdsm/libvirtconnection.py:
Line 37:
Line 38: # TODO: Remove this once we depend on libvirt 2.0
Line 39: if not hasattr(libvirt, 'VIR_DOMAIN_EVENT_ID_JOB_COMPLETED'):
Line 40: libvirt.VIR_DOMAIN_EVENT_ID_JOB_COMPLETED = 'fake'
Line 41:
I know that (1) this is very urgent and (2) I'm to blame for this horrible hack. but now that I see how bad it looks
_EVENTS = (current events)
if not hasattr(libvirt, 'VIR_DOMAIN_EVENT_ID_JOB_COMPLETED'):
_EVENTS += (libvirt.VIR_DOMAIN_EVENT_ID_JOB_COMPLETED, )
but I'd let Francesco decide.
Line 42:
Line 43: class _EventLoop:
Line 44: def __init__(self):
Line 45: self.run = False
--
To view, visit https://gerrit.ovirt.org/67244
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8d3c6a71b4cf694b96cc278adbe9dd5ade62d18
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 6 months
Change in vdsm[ovirt-4.0]: net: only set values once with ifacquire
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: only set values once with ifacquire
......................................................................
net: only set values once with ifacquire
Change-Id: Ia06edd7d0e6572ca88dd7f77edf4e57172ea18c9
Signed-off-by: Petr Horáček <phoracek(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1379115
Reviewed-on: https://gerrit.ovirt.org/66281
Continuous-Integration: Jenkins CI
Reviewed-by: Edward Haas <edwardh(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
(cherry picked from commit 765ecea1613de1dbda02a10aa1cf82aee50a12ab)
---
M lib/vdsm/network/ifacquire.py
M tests/network/ifacquire_test.py
2 files changed, 33 insertions(+), 12 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/66566
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia06edd7d0e6572ca88dd7f77edf4e57172ea18c9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in vdsm[master]: net: restore ovs switch bonds early
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: restore ovs switch bonds early
......................................................................
net: restore ovs switch bonds early
OVS switch uses SysFS handled linux bondings. SysFS are not persisted
across reboots, therefore we need to restore OVS bonds manually.
Change-Id: I81afb0b89452e0d9d8d208a6e5a5f636af4c7b2a
Signed-off-by: Petr Horáček <phoracek(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1379115
---
M lib/vdsm/network/netrestore.py
A tests/network/func_netrestore_test.py
M tests/network/netfunctestlib.py
3 files changed, 73 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/66335
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I81afb0b89452e0d9d8d208a6e5a5f636af4c7b2a
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in vdsm[master]: net: support the ability to change the switch type for a host
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: support the ability to change the switch type for a host
......................................................................
net: support the ability to change the switch type for a host
Mixing of switch types is not allowed. The only way how to change
from one switch type to another is to executed setupNetworks command,
that will change all currently configured network and bonds to another
switch type.
Change-Id: Ia090277ee3c4995f0a313a032ae651ba55dc8989
Bug-Url: https://bugzilla.redhat.com/1362399
Signed-off-by: Petr Horáček <phoracek(a)redhat.com>
---
M lib/vdsm/network/api.py
M lib/vdsm/network/netswitch.py
A tests/network/func_switch_type_change_test.py
3 files changed, 391 insertions(+), 8 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/62330
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia090277ee3c4995f0a313a032ae651ba55dc8989
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in vdsm[master]: net: support the ability to change the switch type for a host
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: support the ability to change the switch type for a host
......................................................................
Patch Set 30: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62330
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia090277ee3c4995f0a313a032ae651ba55dc8989
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 6 months