Change in vdsm[master]: readme: fix markdown
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: readme: fix markdown
......................................................................
readme: fix markdown
Change-Id: I1d3e2086a1d47f63d13c7fe2f06183351e55304d
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M README.md
1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/67350/1
diff --git a/README.md b/README.md
index 87a337b..bd57382 100644
--- a/README.md
+++ b/README.md
@@ -51,9 +51,8 @@
To check if the Vdsm is properly configured to run containers, just do:
-# vdsClient -s 0 getVdsCaps | grep containers
-
- containers = True
+ # vdsClient -s 0 getVdsCaps | grep containers
+ containers = True
This means that this Vdsm could also run docker containers.
@@ -61,7 +60,7 @@
You just need to set a few custom properties. Run this command
on your Engine host:
-# engine-config -s UserDefinedVMProperties='volumeMap=^[a-zA-Z_-]+:[a-zA-Z_-]+$;containerImage=^[a-zA-Z]+(://|)[a-zA-Z]+$;containerType=^docker$' --cver=4.1
+ # engine-config -s UserDefinedVMProperties='volumeMap=^[a-zA-Z_-]+:[a-zA-Z_-]+$;containerImage=^[a-zA-Z]+(://|)[a-zA-Z]+$;containerType=^docker$' --cver=4.1
replace --cver=4.1 with the version of the Engine you are using.
There is no need to configure the regular expressions to match your environment,
--
To view, visit https://gerrit.ovirt.org/67350
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d3e2086a1d47f63d13c7fe2f06183351e55304d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years, 5 months
Change in vdsm[master]: testValidation: Add @skipif decorator
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: testValidation: Add @skipif decorator
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/67334/1/tests/testValidation.py
File tests/testValidation.py:
Line 120:
Line 121: return wrapper
Line 122:
Line 123:
Line 124: def skipif(cond, reason="Test cannnot run"):
should deafult reason value include the condition? I think it's meaningful info to provide
Line 125: def wrap(f):
Line 126: @wraps(f)
Line 127: def wrapper(*args, **kwargs):
Line 128: if cond:
--
To view, visit https://gerrit.ovirt.org/67334
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71a2ae262482edc8acf303f18eac6f9035e710bc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 5 months
Change in vdsm[master]: tests: Remove invalid pyc file tests
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: Remove invalid pyc file tests
......................................................................
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/67339/1//COMMIT_MSG
Commit Message:
Line 7: tests: Remove invalid pyc file tests
Line 8:
Line 9: moduleloader test was creating empty (invalid) "a.pyc" file. Existance
Line 10: of an invalid "a.pyc" file may casue the test to fail if "a.pyc" file is
Line 11: newer then the "a.py". This depends on the resolution of the file system
we create a.py and a.pyc at the same time in the test flow.. I don't understand if this scenario is something that you actually see or something that you worry about?
Line 12: timestamps and the timing.
Line 13:
Line 14: Since import of pyc files is not the subject of this test, I removed the
Line 15: pyc file from the test data.
Line 11: newer then the "a.py". This depends on the resolution of the file system
Line 12: timestamps and the timing.
Line 13:
Line 14: Since import of pyc files is not the subject of this test, I removed the
Line 15: pyc file from the test data.
this is. I want to load the module only once, having pyc and py for the same module name, with a wrong code, can cause wrong behavior that I prefer to test
Line 16:
Line 17: Change-Id: Iffd6371a5f4ace637ea99d4a91550a277cbf3f72
--
To view, visit https://gerrit.ovirt.org/67339
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffd6371a5f4ace637ea99d4a91550a277cbf3f72
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 5 months
Change in vdsm[master]: tests: Remove invalid pyc file tests
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: Remove invalid pyc file tests
......................................................................
Patch Set 1:
add the composer of the code as well for the review next time
--
To view, visit https://gerrit.ovirt.org/67339
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffd6371a5f4ace637ea99d4a91550a277cbf3f72
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months
Change in vdsm[master]: spbackends: simplify over-general evaluation
by Dan Kenigsberg
Dan Kenigsberg has uploaded a new change for review.
Change subject: spbackends: simplify over-general evaluation
......................................................................
spbackends: simplify over-general evaluation
The removed code is too clever for the use case of only two values.
Change-Id: I775c4a6003a03c6b65bee3abc8559a88e3eaec01
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/storage/spbackends.py
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/41253/1
diff --git a/vdsm/storage/spbackends.py b/vdsm/storage/spbackends.py
index 953e01e..f6ce02b 100644
--- a/vdsm/storage/spbackends.py
+++ b/vdsm/storage/spbackends.py
@@ -229,8 +229,11 @@
def setSpmStatus(self, lVer=None, spmId=None):
self.invalidateMetadata()
- metaParams = dict(filter(lambda kv: kv[1] is not None,
- ((PMDK_LVER, lVer), (PMDK_SPM_ID, spmId))))
+ metaParams = {}
+ if lVer is not None:
+ metaParams[PMDK_LVER] = lVer
+ if spmId is not None:
+ metaParams[PMDK_SPM_ID] = spmId
self._metadata.update(metaParams)
@unsecured
--
To view, visit https://gerrit.ovirt.org/41253
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I775c4a6003a03c6b65bee3abc8559a88e3eaec01
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years, 5 months
Change in vdsm[master]: tests: Remove invalid pyc file tests
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Remove invalid pyc file tests
......................................................................
Patch Set 1: Code-Review+1
I've never seen
ImportError: bad magic number
in this test's failure, but I suspect the fix is needed
--
To view, visit https://gerrit.ovirt.org/67339
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffd6371a5f4ace637ea99d4a91550a277cbf3f72
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months
Change in vdsm[master]: dumpStorageTable: remove module and all references
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: dumpStorageTable: remove module and all references
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/67345
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d71e08315688537d1c200e7e60d7e0df6d5512c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marina Kalinin <mkalinin(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Vladik Romanovsky <vladik.romanovsky(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months
Change in vdsm[master]: autoconf: made vdsmrepo customizable
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: autoconf: made vdsmrepo customizable
......................................................................
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/67248/23/configure.ac
File configure.ac:
Line 267: AC_SUBST([vdsmbackupdir], ['${vdsmlogdir}/backup'])
Line 268: AC_SUBST([vdsmexecdir], ['${libexecdir}/vdsm'])
Line 269: AC_SUBST([vdsmhooksdir], ['${vdsmexecdir}/hooks'])
Line 270: AC_SUBST([vdsmtsdir], ['${sysconfdir}/pki/vdsm'])
Line 271: AC_SUBST([vdsmrepo], ["${with_storage_repo}"])
please note the doublequote comment was my tiniest.
could you check if out current issue is related to the fact that @vdsmrepo@ is the only lowercase macro in vdsm.spec? Could you use VDSMREPO instead?
Line 272: AC_SUBST([vdsmpylibdir], ['${pythondir}/vdsm'])
Line 273: AC_SUBST([vdsmnetinfodir], ['${vdsmpylibdir}/network/netinfo'])
Line 274: AC_SUBST([vdsmtooldir], ['${vdsmpylibdir}/tool'])
Line 275: AC_SUBST([configuratorsdir], ['${vdsmtooldir}/configurators'])
--
To view, visit https://gerrit.ovirt.org/67248
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2498e473a11a180254326c6ad9ed9b117bdaec7
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 5 months
Change in vdsm[master]: caps: Report status of installation of HE components
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: caps: Report status of installation of HE components
......................................................................
Patch Set 7:
thanks for your patch. would it not make sense to share some code with lib/vdsm/host/api.py's _getHaInfo()? I think that a cleaner way to report if the package is installed is to add it to KEY_PACKAGES in osversion.
--
To view, visit https://gerrit.ovirt.org/66606
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5b8cc75fd31c63fa7021e90c77b66a80b091749
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months
Change in vdsm[master]: tests: Fix wrong usage of @broken_on_ci
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Fix wrong usage of @broken_on_ci
......................................................................
tests: Fix wrong usage of @broken_on_ci
Both @brokentest and @broken_on_ci must be actually called. If they are
not called, the test is practically disabled and will never run.
The recommend usage is:
@broken_on_ci(msg="why this test is disabled on ci...")
def test_flaky(self):
...
Fixes commit b2ee97f30c9f (tests: Mark some scheduler tests as broken on
CI) to use @broken_on_ci() with a descriptive message.
Change-Id: Ia2f23c3facee68366a0eee8e8f858d29f3272977
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M tests/scheduleTests.py
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Milan Zamazal: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/67326
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2f23c3facee68366a0eee8e8f858d29f3272977
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months