vdsm-patches February 2017

vdsm-patches@lists.fedorahosted.org

1 participants
297 discussions

Change in vdsm[master]: net test: Add net qos test to the new func tests.
by Code Review 10 Feb '17

10 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net test: Add net qos test to the new func tests. ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/71675 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I308de9bbce4ee6e7b2e34e419cba7b48d6c24962 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: Revert "vdsm: remove 3.6 supported engine"
by Code Review 10 Feb '17

10 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has uploaded a new change for review. Change subject: Revert "vdsm: remove 3.6 supported engine" ...................................................................... Revert "vdsm: remove 3.6 supported engine" This reverts commit 7a173cc62e5b0fc79ab68198c75896e4ac751a37 I am not familiar with a specific bug showing up when Engine is 3.6 and host is 4.y. This combination is actually very important for hosted-engine upgrade from 3.6 to 4.0. We must test and support 3.6 Engine and 4.0 hosts, fix specific bugs that might pop up; not to disable this combination in its entirety. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1403846 Change-Id: Iea066a04da25e765d65f36b2e67d0034ca9f458e --- M lib/vdsm/dsaversion.py.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/71888/1 diff --git a/lib/vdsm/dsaversion.py.in b/lib/vdsm/dsaversion.py.in index 7a00333..bf500c1 100644 --- a/lib/vdsm/dsaversion.py.in +++ b/lib/vdsm/dsaversion.py.in @@ -32,6 +32,6 @@ 'version_name': version_name, 'software_version': software_version, 'software_revision': software_revision, - 'supportedENGINEs': ['4.0', '4.1'], + 'supportedENGINEs': ['3.6', '4.0', '4.1'], 'clusterLevels': ['3.6', '4.0', '4.1'], } -- To view, visit https://gerrit.ovirt.org/71888 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iea066a04da25e765d65f36b2e67d0034ca9f458e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

1 4

Change in vdsm[master]: tests: make vmfakelib independent from clientIF
by Code Review 10 Feb '17

10 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: make vmfakelib independent from clientIF ...................................................................... tests: make vmfakelib independent from clientIF We don't actually need to subclass clientIF, except in clientIF tests proper. This removes one useless dependency, making the tests less coupled. Change-Id: I7ddf3ec41fbd0aa06077441b461877f5b20f19d7 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M tests/clientif_test.py M tests/vmfakelib.py 2 files changed, 42 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/70609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ddf3ec41fbd0aa06077441b461877f5b20f19d7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[ovirt-4.1]: automation: don't skip localsync if it is unavailable
by Code Review 10 Feb '17

10 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: automation: don't skip localsync if it is unavailable ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/71996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c0086856b2795a951faea293145eaf4ef69d92e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: virt: Fix of NoSuchVM misspelling in memory hotunplug
by Code Review 10 Feb '17

10 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Fix of NoSuchVM misspelling in memory hotunplug ...................................................................... virt: Fix of NoSuchVM misspelling in memory hotunplug Change-Id: Ib602c15f540846158353a406c76a0444b97c38c4 Bug-Url: https://bugzilla.redhat.com/1228543 Backport-To: 4.1 Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com> --- M vdsm/API.py M vdsm/virt/vm.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Milan Zamazal: Verified -- To view, visit https://gerrit.ovirt.org/71785 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib602c15f540846158353a406c76a0444b97c38c4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: virt: Make Memory device XML more complete
by Code Review 10 Feb '17

10 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Make Memory device XML more complete ...................................................................... virt: Make Memory device XML more complete Memory.getXML() doesn't identify the memory device completely. This may in theory cause problems with memory hotunplug. According to libvirt documentation, complete device definition is required for hotunplug. Although the current definition is actually accepted, it doesn't identify the memory device uniquely. Assume there are two memory devices with the same size and on the same node. One of them can't be hotunplugged for some reason, e.g. it hasn't been onlined as movable, while the other one is fine. However, if libvirt selects the first device on the hotunplug request then the second device can never be hotunplugged. This patch adds the missing information to the Memory device XML to make it uniquely identified and the information for libvirt complete. Since the additional device attributes are not available before memory hotplug, they are inserted only if they are available. Change-Id: Ib7037bc9b36fa3e0ead24d93cf236ed0b46aba80 Backport-To: 4.1 Bug-Url: https://bugzilla.redhat.com/1228543 Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com> --- M lib/vdsm/virt/vmdevices/core.py 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Milan Zamazal: Verified -- To view, visit https://gerrit.ovirt.org/71877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7037bc9b36fa3e0ead24d93cf236ed0b46aba80 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: use os.path.join with P_VDSM_RUN
by Code Review 09 Feb '17

09 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has uploaded a new change for review. Change subject: use os.path.join with P_VDSM_RUN ...................................................................... use os.path.join with P_VDSM_RUN In three places the code assumes that P_VDSM_RUN ends with a slash. Using os.path.join makes the code a bit more robust to common slash forgetfulness. This makes it possible to make a couple of tests slightly less ugly. Change-Id: I51b14fca58345430a8556301b781e9f55713a55b Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M lib/vdsm/constants.py.in M lib/vdsm/network/dhclient_monitor.py M lib/vdsm/network/ifacetracking.py M tests/vm_test.py M tests/vmfakelib.py M tests/vmrecovery_test.py 6 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/70313/1 diff --git a/lib/vdsm/constants.py.in b/lib/vdsm/constants.py.in index 44a36b9..e109bc6 100644 --- a/lib/vdsm/constants.py.in +++ b/lib/vdsm/constants.py.in @@ -80,7 +80,7 @@ P_VDSM_HOOKS = '@HOOKSDIR@/' # NOQA: E501 (potentially long line) P_VDSM_LIB = '@VDSMLIBDIR@/' # NOQA: E501 (potentially long line) P_VDSM_RUN = '@VDSMRUNDIR@/' # NOQA: E501 (potentially long line) -P_VDSM_STORAGE = P_VDSM_RUN + 'storage/' +P_VDSM_STORAGE = os.path.join(P_VDSM_RUN, 'storage/') P_VDSM_CONF = '@CONFDIR@/' # NOQA: E501 (potentially long line) P_VDSM_KEYS = '/etc/pki/vdsm/keys/' P_VDSM_CERT = '/etc/pki/vdsm/certs/vdsmcert.pem' diff --git a/lib/vdsm/network/dhclient_monitor.py b/lib/vdsm/network/dhclient_monitor.py index 4a86960..4e7944e 100644 --- a/lib/vdsm/network/dhclient_monitor.py +++ b/lib/vdsm/network/dhclient_monitor.py @@ -41,7 +41,7 @@ IFACE_KEY = 'iface' -MONITOR_FOLDER = P_VDSM_RUN + 'sourceRoutes' +MONITOR_FOLDER = os.path.join(P_VDSM_RUN, 'sourceRoutes') def start(): diff --git a/lib/vdsm/network/ifacetracking.py b/lib/vdsm/network/ifacetracking.py index ffa3071..d1142b2 100644 --- a/lib/vdsm/network/ifacetracking.py +++ b/lib/vdsm/network/ifacetracking.py @@ -25,7 +25,7 @@ from vdsm.utils import rmFile -TRACKED_INTERFACES_FOLDER = P_VDSM_RUN + 'trackedInterfaces' +TRACKED_INTERFACES_FOLDER = os.path.join(P_VDSM_RUN, 'trackedInterfaces') def add(device_name): diff --git a/tests/vm_test.py b/tests/vm_test.py index c7324cf..b0b2ff5 100644 --- a/tests/vm_test.py +++ b/tests/vm_test.py @@ -106,7 +106,7 @@ def assertBuildCmdLine(self, confToDom): with namedTemporaryDir() as tmpDir: - with MonkeyPatchScope([(constants, 'P_VDSM_RUN', tmpDir + '/')]): + with MonkeyPatchScope([(constants, 'P_VDSM_RUN', tmpDir)]): for conf, expectedXML in confToDom: expectedXML = expectedXML % conf diff --git a/tests/vmfakelib.py b/tests/vmfakelib.py index c240c19..5a5e630 100644 --- a/tests/vmfakelib.py +++ b/tests/vmfakelib.py @@ -240,7 +240,7 @@ cif=None, create_device_objects=False, post_copy=None): with namedTemporaryDir() as tmpDir: - with MonkeyPatchScope([(constants, 'P_VDSM_RUN', tmpDir + '/'), + with MonkeyPatchScope([(constants, 'P_VDSM_RUN', tmpDir), (libvirtconnection, 'get', Connection), (containersconnection, 'get', Connection), (vm.Vm, 'send_status_event', diff --git a/tests/vmrecovery_test.py b/tests/vmrecovery_test.py index 2c8cc15..d69c872 100644 --- a/tests/vmrecovery_test.py +++ b/tests/vmrecovery_test.py @@ -140,7 +140,7 @@ @contextlib.contextmanager def setup_env(self): with fake.VM() as testvm, namedTemporaryDir() as tmpdir: - with MonkeyPatchScope([(constants, 'P_VDSM_RUN', tmpdir + '/')]): + with MonkeyPatchScope([(constants, 'P_VDSM_RUN', tmpdir)]): yield testvm, tmpdir @@ -188,7 +188,7 @@ def test_clean_vm_files(self): with fake.VM() as testvm, namedTemporaryDir() as tmpdir: - with MonkeyPatchScope([(constants, 'P_VDSM_RUN', tmpdir + '/')]): + with MonkeyPatchScope([(constants, 'P_VDSM_RUN', tmpdir)]): stored = recovery.File(testvm.id) stored.save(testvm) @@ -212,7 +212,7 @@ with namedTemporaryDir() as tmpdir: with MonkeyPatchScope([ - (constants, 'P_VDSM_RUN', tmpdir + '/'), + (constants, 'P_VDSM_RUN', tmpdir), (recovery, '_list_domains', lambda: []), (containersconnection, 'recovery', lambda: []), ]): -- To view, visit https://gerrit.ovirt.org/70313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I51b14fca58345430a8556301b781e9f55713a55b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

1 3

Change in vdsm[ovirt-4.1]: automation: fixing check-merged's incorrect local repo sourc...
by Code Review 09 Feb '17

09 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: automation: fixing check-merged's incorrect local repo source path. ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/71995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53603d61b036914baafdab860b13fda32ffeca19 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: virt: Fix of wrong exit code on host shutdown
by Code Review 09 Feb '17

09 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Fix of wrong exit code on host shutdown ...................................................................... virt: Fix of wrong exit code on host shutdown In case of a host shutdown previously we did not send the ERROR exit_code however NORMAL which was incorrect. Due to a bug in the ovirt-engine the behavior was coincidentally restored and the issue hasn't been uncovered during the implementation of the host shutdown detection. This patch will no ensure that the ERROR exit_code is sent on a detected host shutdown. Change-Id: I397f1e069d650b39070b38ac1c5de07f2a76a1f2 Backport-To: 4.1 Bug-Url: https://bugzilla.redhat.com/1341106 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M vdsm/virt/vm.py 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified Francesco Romani: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I397f1e069d650b39070b38ac1c5de07f2a76a1f2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: xmlrpc: Fail xmlrpc requests
by Code Review 09 Feb '17

09 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: xmlrpc: Fail xmlrpc requests ...................................................................... xmlrpc: Fail xmlrpc requests As first step in xmlrpc removal, override POST handler to send an error for any xmlrpc request. We belive that all xmlrpc users were fixed to use jsonrpc, but it we are wrong it will be easy to revert this patch. Change-Id: I6b6d6cef7ba16dd92281c61c2f9fa9035b9043b3 Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- M lib/vdsm/rpc/bindingxmlrpc.py 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Verified Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Irit Goihman: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/71811 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b6d6cef7ba16dd92281c61c2f9fa9035b9043b3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

← Newer
1
...
17
18
19
20
21
22
23
...
30
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches February 2017