Change in vdsm[master]: check-merged: define a var as local
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: check-merged: define a var as local
......................................................................
check-merged: define a var as local
bash's default is ugly. variables should be defined as local unless
there's a good reason to expose them.
Change-Id: Ib8eeac6714fc7d540b3793f0fae33d1d8776deb4
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M automation/check-merged.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/71697/1
diff --git a/automation/check-merged.sh b/automation/check-merged.sh
index e06352b..32ef4a5 100755
--- a/automation/check-merged.sh
+++ b/automation/check-merged.sh
@@ -84,7 +84,7 @@
function run {
mkdir "$EXPORTS"/lago-logs
- failed=0
+ local failed=0
lago start "$VM_NAME"
--
To view, visit https://gerrit.ovirt.org/71697
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib8eeac6714fc7d540b3793f0fae33d1d8776deb4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years, 4 months
Change in vdsm[master]: Upgrade test - add more old repos to upgrade from
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Upgrade test - add more old repos to upgrade from
......................................................................
Upgrade test - add more old repos to upgrade from
This patch adds master snapshot repo to the test.
Change-Id: I62124b45b8084c49c678e03287aa71f8eabb7f70
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M tests/functional/upgrade_vdsm_test.py
1 file changed, 9 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/67788/1
diff --git a/tests/functional/upgrade_vdsm_test.py b/tests/functional/upgrade_vdsm_test.py
index 792acf7..6d7433c 100644
--- a/tests/functional/upgrade_vdsm_test.py
+++ b/tests/functional/upgrade_vdsm_test.py
@@ -21,8 +21,10 @@
from vdsm.tool.service import service_start, service_status, service_stop
from testlib import VdsmTestCase
+from testlib import permutations, expandPermutations
-el7_ovirt36_repo = 'http://resources.ovirt.org/pub/ovirt-3.6/rpm/el7/'
+_EL7_OVIRT36_REPO_URL = 'http://resources.ovirt.org/pub/ovirt-3.6/rpm/el7/'
+_EL7_MASTER_REPO_URL = 'http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/el7/'
def run_command(command):
@@ -56,19 +58,21 @@
run_command(['yum', 'install', '-y', 'vdsm'])
service_start('vdsmd')
- def service_up_test(self):
+ @permutations((_EL7_MASTER_REPO_URL, _EL7_OVIRT36_REPO_URL))
+ def service_up_test(self, old_repo):
service_start('vdsmd')
vdsm_version = run_command(['rpm', '-q', 'vdsm'])
- downgrade_vdsm(el7_ovirt36_repo)
+ downgrade_vdsm(old_repo)
upgrade_vdsm()
self.assertEqual(run_command(['rpm', '-q', 'vdsm']), vdsm_version)
self.assertEqual(service_status('vdsmd'), 0)
- def service_down_test(self):
+ @permutations((_EL7_MASTER_REPO_URL, _EL7_OVIRT36_REPO_URL))
+ def service_down_test(self, old_repo):
service_stop('vdsmd')
vdsm_version = run_command(['rpm', '-q', 'vdsm'])
- downgrade_vdsm(el7_ovirt36_repo)
+ downgrade_vdsm(old_repo)
upgrade_vdsm()
self.assertEqual(run_command(['rpm', '-q', 'vdsm']), vdsm_version)
--
To view, visit https://gerrit.ovirt.org/67788
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I62124b45b8084c49c678e03287aa71f8eabb7f70
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
7 years, 4 months
Change in vdsm[master]: api: move vdsmapi to lib
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: api: move vdsmapi to lib
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/67835
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95a7caf4fa354c7bea7e8f15533d5748182ed5fc
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[master]: lvm-conf: Handle lvmetad failed state
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: lvm-conf: Handle lvmetad failed state
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/71677
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I83d4ffcca510f77ec229f2b077ec822b00d68de2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[master]: api: move vdsmapi to lib
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: api: move vdsmapi to lib
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/67835
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95a7caf4fa354c7bea7e8f15533d5748182ed5fc
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[ovirt-4.1]: automation: repos files should point to ovirt-4.1
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: automation: repos files should point to ovirt-4.1
......................................................................
Patch Set 1:
I see that we still have issues with f25 and master repo is broken as well... please ack verified if fc24 and el7 are fine. looks alright to me
--
To view, visit https://gerrit.ovirt.org/71710
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8df18dfd505592050ce263925a5bd33ba431f61a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[ovirt-4.1]: automation: repos files should point to ovirt-4.1
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: automation: repos files should point to ovirt-4.1
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/71710
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8df18dfd505592050ce263925a5bd33ba431f61a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[ovirt-4.0]: hooks: Add localdisk hook
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: Add localdisk hook
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/71712/1/vdsm_hooks/localdisk/README
File vdsm_hooks/localdisk/README:
Line 50: The VM must be pinned to host. Any migration will cause the VM to try to
Line 51: start with local disks that are not available on the new host.
Line 52:
Line 53: The operator need to configure the engine UserDefinedVMProperties to support
Line 54: 'localdisk' with value 'lvm'
better be more specific:
engine-config -s UserDefinedVMProperties='localdisk=^(lvm)?$'
Line 55:
Line 56: TODO:
--
To view, visit https://gerrit.ovirt.org/71712
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6ad8e8ebb4cd71bff02157f28cd2be5c31ac35
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 4 months
Change in vdsm[ovirt-4.1]: check-patch: retire snapshot repo in favor of 'tested'
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: check-patch: retire snapshot repo in favor of 'tested'
......................................................................
Patch Set 1: Code-Review+2 Verified+1
ok, ok. this patch does not make things worse.
--
To view, visit https://gerrit.ovirt.org/71686
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec022ce45b268442140a35038b3accba9f8733f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[master]: vdsm-client: unbreak vdsm upgrade
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm-client: unbreak vdsm upgrade
......................................................................
vdsm-client: unbreak vdsm upgrade
mark vdsm-cli as obsolete when upgrading vdsm.
According to https://fedoraproject.org/wiki/Packaging:Guidelines
in "Renaming/Replacing Existing Packages" section:
In case a new package replaces an old one we should mark
Provides: oldpackagename = $provEVR
Obsoletes: oldpackagename < $obsEVR
Change-Id: If94eaffecac5e2f1849f3a352dd9457530612840
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Jakub Niedermertl: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, but someone else must approve
Irit Goihman: Verified
Dan Kenigsberg: Looks good to me, approved; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/71700
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If94eaffecac5e2f1849f3a352dd9457530612840
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months